Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sensor: vl53l0x: Warning message when building in ext/hal/st/lib/sensor/vl53l0x #10134

Closed
erwango opened this issue Sep 20, 2018 · 0 comments
Closed

sensor: vl53l0x: Warning message when building in ext/hal/st/lib/sensor/vl53l0x #10134

erwango opened this issue Sep 20, 2018 · 0 comments
Assignees
@erwango
Labels
area: Sensors Sensors bug The issue is a bug, or the PR is fixing a bug platform: STM32 ST Micro STM32 priority: low Low impact/importance bug

Comments

@erwango
Copy link
Member

erwango commented Sep 20, 2018

When building samples using vl53l0x sensors,
following warning message pops up:

[95/130] Building C object zephyr/drivers/sensor/vl53l0x/CMakeFiles/drivers__sensor__vl53l0x.dir/vl53l0x.c.obj
In file included from ../../../../../ext/hal/st/lib/sensor/vl53l0x/api/core/inc/vl53l0x_device.h:37:0,
                 from ../../../../../ext/hal/st/lib/sensor/vl53l0x/api/core/inc/vl53l0x_def.h:90,
                 from ../../../../../ext/hal/st/lib/sensor/vl53l0x/api/core/inc/vl53l0x_api_strings.h:32,
                 from ../../../../../ext/hal/st/lib/sensor/vl53l0x/api/core/inc/vl53l0x_api.h:32,
                 from /local/mcu/zephyr/zephyr-project/drivers/sensor/vl53l0x/vl53l0x.c:19:
../../../../../drivers/sensor/vl53l0x/vl53l0x_types.h:29:9: note: #pragma message: Review type definition of STDINT define for your platform
  #pragma message("Review type definition of STDINT define for your platform")
@erwango erwango added priority: low Low impact/importance bug area: Sensors Sensors labels Sep 20, 2018
@MaureenHelm MaureenHelm added the bug The issue is a bug, or the PR is fixing a bug label Sep 25, 2018
erwango added a commit to erwango/zephyr that referenced this issue Feb 15, 2019
@erwango
drivers/sensor/vl53l0x: Remove unnecessary lib include check
7473567 
vl53l0x driver is using an external library to build, located under:
ext/hal/st/lib/sensor/vl53l0x.
This library is expecting stdint.h lib to be available and to
secure this for driver library inclusion work, a stdint.h file
header check was done. This check was based on assumptions on possible
header names for stdint.h.
Due to recent renaming of the zephyr header files, this check was
returning a false positive, generating warning at compilation.

Rather than updated with new header names, remove this check, since
driver porting is completed and stdint.h inclusion is actually
done.

Fixes zephyrproject-rtos#10134

Signed-off-by: Erwan Gouriou <erwan.gouriou@linaro.org>
@erwango erwango mentioned this issue Feb 15, 2019
Merged
@erwango erwango added the platform: STM32 ST Micro STM32 label Feb 15, 2019
galak pushed a commit that referenced this issue Feb 19, 2019
@erwango @galak
drivers/sensor/vl53l0x: Remove unnecessary lib include check
c55c188 
vl53l0x driver is using an external library to build, located under:
ext/hal/st/lib/sensor/vl53l0x.
This library is expecting stdint.h lib to be available and to
secure this for driver library inclusion work, a stdint.h file
header check was done. This check was based on assumptions on possible
header names for stdint.h.
Due to recent renaming of the zephyr header files, this check was
returning a false positive, generating warning at compilation.

Rather than updated with new header names, remove this check, since
driver porting is completed and stdint.h inclusion is actually
done.

Fixes #10134

Signed-off-by: Erwan Gouriou <erwan.gouriou@linaro.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erwango erwango

Labels
area: Sensors Sensors bug The issue is a bug, or the PR is fixing a bug platform: STM32 ST Micro STM32 priority: low Low impact/importance bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MaureenHelm @erwango