mcuboot doesn't link into code-partition

[nvlsianpu]

mcuboot doesn't link into code-partition despite it is chosen.

	chosen {
		zephyr,code-partition = &boot_partition;
	};

To Reproduce
build mcuboot against nrf52840_pca10059 zephyr target or any else target which has shifted code-partition.

Expected behavior
linking into code partition.

Impact
mcuboot will not work on XIP target which has mcuboot partition started at offset different than Zero.

Environment

• zephyr SHA 2153c01 (master branch)
• mcuboot SHA mcu-tools/mcuboot@b899f79 (master branch)

mcuboot issue
mcu-tools/mcuboot#444

[nvlsianpu]

I would introduce Kconfig property:

config USE_CODE_PARTITION
	bool "Link application into code partition"

And use it for conditional assignment to FLASH_LOAD_OFFSET and FLASH_LOAD_SIZE the value of
$(dt_hex_val,DT_CODE_PARTITION_OFFSET) (as it is now done with BOOTLOADER_MCUBOOT).

Then BOOTLOADER_MCUBOOT should just select USE_CODE_PARTITION.

Mcuboot project should then select just select USE_CODE_PARTITION

[nvlsianpu]

cc @SebastianBoe

[lemrey]

Can you confirm that this affects other boards?

[nvlsianpu]

I confirm that this is issue for other boards as well.

[mike-scott]

I mentioned this to @carlescufi a while back on Slack. I was having a problems getting binaries built from Zephyr to have the correct flash offset settings.

I eventually got it to work by manually specifying how I wanted mcuboot built:

west build -d build/mcuboot -b nrf52840_pca10059 -s mcuboot/boot/zephyr -- -DCONFIG_FLASH_LOAD_OFFSET=0x1000 -DCONFIG_FLASH_LOAD_SIZE=0xf000

Using this method, I was able to take the .hex file directly and place it on the board using the nRF-Connect GUI tool for Linux.

[nvlsianpu]

@mike-scott Thanks for post this workaround.

[SebastianBoe]

@nvlsianpu : Could you do a PR with your proposed solution?

I'm not familiar enough with these symbols to review unfortunately.

[lemrey]

mcu-tools/mcuboot#445
but another PR should target this repo to fix nrf52840_pca10059 specifically.

[nvlsianpu]

@SebastianBoe
#14620 + mcu-tools/mcuboot#447