Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master reports itself as if it was 1.9.0 release #1558

Closed
pfalcon opened this issue Sep 19, 2017 · 6 comments
Closed

Master reports itself as if it was 1.9.0 release #1558

pfalcon opened this issue Sep 19, 2017 · 6 comments
Assignees
Labels
bug The issue is a bug, or the PR is fixing a bug
Milestone

Comments

@pfalcon
Copy link
Contributor

pfalcon commented Sep 19, 2017

Aka, we need PATCHLEVEL = 99.

@nashif
Copy link
Member

nashif commented Sep 19, 2017

considering to call this 1.10.0-dev or something like that, 1.9.99 while seems not realistic, is a valid dot release that we might reach at some point :-), thoughts?

@nashif nashif added the bug The issue is a bug, or the PR is fixing a bug label Sep 19, 2017
@nashif nashif added this to the v1.10 milestone Sep 19, 2017
@pfalcon
Copy link
Contributor Author

pfalcon commented Sep 20, 2017

Thoughts are: 1.9.99 is not realistic patch release we can reach. However, something like 5.13.99 in a dozen of years may be. If we want to solve that right now without much bikeshedding, let's just use 1.9.999. But that scheme worked pretty well for few releases, so I don't think it should be abandoned out of the blue. (And yep, the whole idea behind it was to be able to detect anything below a release X with just numeric comparisons (e.g. via C preprocessor).

@pfalcon
Copy link
Contributor Author

pfalcon commented Sep 20, 2017

@carlescufi : ^^^, FYI. I believe it was you who raised concerns with "99", I apologize if it was another Nordic guy. Please see if above works for you.

@carlescufi
Copy link
Member

carlescufi commented Sep 20, 2017

I am OK with using 999, the requirements on my side where to have a "build type" (dev, rc or production), which won't be solved by this anyway and it's tracked in an issue.

i.e. I need macros in version.h that allow me to find out the type of build. A string or patchlevel is not enough anyway.

In fact, with the current macros I actually prefer the 999 scheme, because at least one knows that this is a dev build without having to parse a string

@pfalcon
Copy link
Contributor Author

pfalcon commented Sep 20, 2017

which won't be solved by this anyway and it's tracked in an issue.

In fact, with the current macros I actually prefer the 999 scheme, because at least one knows that this is a dev build without having to parse a string

Exactly, and in the corresponding ticket, I gave an idea that we can have:

#if PATCHLEVEL == 99(9)
#define BUILDTYPE "dev"
#endif

@pfalcon
Copy link
Contributor Author

pfalcon commented Sep 20, 2017

Thanks for acking "999" btw.

@nashif nashif added In progress For PRs: is work in progress and should not be merged yet. For issues: Is being worked on to do and removed In progress For PRs: is work in progress and should not be merged yet. For issues: Is being worked on labels Sep 21, 2017
nashif added a commit to nashif/zephyr that referenced this issue Oct 2, 2017
Fixes zephyrproject-rtos#1558

Signed-off-by: Anas Nashif <anas.nashif@intel.com>
@nashif nashif added In progress For PRs: is work in progress and should not be merged yet. For issues: Is being worked on and removed to do labels Oct 2, 2017
@ghost ghost removed the In progress For PRs: is work in progress and should not be merged yet. For issues: Is being worked on label Oct 2, 2017
nashif added a commit that referenced this issue Oct 2, 2017
Fixes #1558

Signed-off-by: Anas Nashif <anas.nashif@intel.com>
@nashif nashif modified the milestones: v1.10, v1.10.0 Oct 3, 2017
nagineni pushed a commit to nagineni/zephyr that referenced this issue Nov 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug, or the PR is fixing a bug
Projects
None yet
Development

No branches or pull requests

3 participants