Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/net/buf fails on qemu_x86_64 #15881

Closed
andrewboie opened this issue May 3, 2019 · 7 comments
Closed

tests/net/buf fails on qemu_x86_64 #15881

andrewboie opened this issue May 3, 2019 · 7 comments
Assignees
Labels
area: Networking bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Milestone

Comments

@andrewboie
Copy link
Contributor

SeaBIOS (version rel-1.12.0-0-ga698c8995f-prebuilt.qemu.org)
Booting from ROM..Running test suite net_buf_test
===================================================================
starting test - net_buf_test_1
PASS - net_buf_test_1
===================================================================
starting test - net_buf_test_2
PASS - net_buf_test_2
===================================================================
starting test - net_buf_test_3

    Assertion failed at ./tests/net/buf/src/main.c:195: net_buf_test_3: (k_sem_take(&sema, TEST_TIMEOUT) == 0 is false)
Timeout while waiting for semaphore
FAIL - net_buf_test_3
===================================================================
starting test - net_buf_test_4

    Assertion failed at ./tests/net/buf/src/main.c:156: test_3_thread: (buf is NULL)
Unable to get buffer

@andrewboie andrewboie added the bug The issue is a bug, or the PR is fixing a bug label May 3, 2019
@andrewboie andrewboie added priority: medium Medium impact/importance bug area: Networking labels May 3, 2019
@jukkar jukkar assigned jhedberg and unassigned jukkar May 3, 2019
@jukkar
Copy link
Member

jukkar commented May 3, 2019

@jhedberg can you check this one? I looked this briefly but did not quite got why the test was failing.

@andrewboie
Copy link
Contributor Author

It's quite plausible that this could ultimately be an x86_64 issue, in which case we should bring to @andyross 's attention

@jukkar
Copy link
Member

jukkar commented Aug 7, 2019

I remember checking net_buf tests briefly earlier but my notes seem to have lost somewhere. After adding some printk()'s to the code, it seems that the semaphores in net_buf_test_3() are not waited and they fail immediately regardless of the timeout value TEST_TIMEOUT. To me it looks the issue is in qemu_x86_64 and not in the net_buf unit test.

@rljordan-zz rljordan-zz assigned andyross and unassigned jhedberg Aug 15, 2019
@andyross
Copy link
Contributor

Swung back by to check this: this passes fine with the fixes in #18531, though it requires that we remove the whitelist so it actuallys runs.

@jenmwms jenmwms added this to the v2.0.0 milestone Aug 23, 2019
@andyross andyross modified the milestones: v2.0.0, v2.1.0 Aug 28, 2019
@andyross
Copy link
Contributor

Bug tracking accounting. Update milestone to match PR

@nashif nashif added priority: low Low impact/importance bug and removed priority: medium Medium impact/importance bug labels Aug 29, 2019
@nashif
Copy link
Member

nashif commented Aug 29, 2019

this platform is not whitelisted for this list and per @andyross the test passes with #18531 if platform is enabled, so lowering priority as there is no impact to the 2.0 release.

@nashif
Copy link
Member

nashif commented Nov 20, 2019

can't reproduce

@nashif nashif closed this as completed Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Networking bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Development

No branches or pull requests

6 participants