Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modules: add a SHA1 check to avoid updating module in the past #16961

Closed
erwango opened this issue Jun 20, 2019 · 2 comments
Closed

Modules: add a SHA1 check to avoid updating module in the past #16961

erwango opened this issue Jun 20, 2019 · 2 comments
Labels
area: Modules area: West West utility Enhancement Changes/Updates/Additions to existing features

Comments

@erwango
Copy link
Member

erwango commented Jun 20, 2019

Is your feature request related to a problem? Please describe.
In case of several PR on going having dependencies on the same module, it could be possible that the module PR are not merged in the same order as the zephyr main repo PRs.
In that case, when merging the last zephyr PR we should not update the module SHA1, otherwise we'll update SHA1 to a predecessor version of the module and latest SHA1 of the module will be removed.

For instance:
zephyr/pull/23 has dependency on module/pull/13
zephyr/pull/25 has dependency on module/pull/15

module/pull/13 is merged first and get SHA1:000001
module/pull/15 is merged second and get SHA1:000002

zephyr/pull/25 is merged first, so west.yml set module SHA1:000002
zephyr/pull/23 is the merged later and west.yml set module SHA1:000001

=> zephyr/pull/25 looses the SHA1 its depends on..

Describe the solution you'd like
Add a script to see if west.yml update is going in the past or going forward.

Describe alternatives you've considered
Check manually and fail randomly

@mbolivar
Copy link
Contributor

I think this is not a west feature as much as a zephyr policy. West is designed to allow projects to move back in time if that is what the user wants.

@erwango
Copy link
Member Author

erwango commented Jun 27, 2019

Actually I didn't think about this proposal as a west feature but a rather github automatic check to help contributors and maintainers.
With multiple PR on going with dependencies on the same module, the exercise is close to a air traffic controller activity. I think we can benefit from an automatic check, and given the number of checks we're doing today, I don't think one more will make any difference.

Also, I understand the possible need to go back in time, though this shouldn't be a common operation, so a warning about it wouldn't be superfluous.

@nashif nashif removed their assignment Dec 18, 2019
@carlescufi carlescufi added area: West West utility Enhancement Changes/Updates/Additions to existing features and removed Feature Request A request for a new feature labels Mar 24, 2020
@mbolivar-nordic mbolivar-nordic removed their assignment Oct 5, 2020
@erwango erwango closed this as completed Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Modules area: West West utility Enhancement Changes/Updates/Additions to existing features
Projects
None yet
Development

No branches or pull requests

7 participants