Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples: net: echo-server: no return packet #17378

Closed
tedd-an opened this issue Jul 6, 2019 · 1 comment · Fixed by #17393
Closed

samples: net: echo-server: no return packet #17378

tedd-an opened this issue Jul 6, 2019 · 1 comment · Fixed by #17393
Assignees
Labels
bug The issue is a bug, or the PR is fixing a bug

Comments

@tedd-an
Copy link
Collaborator

tedd-an commented Jul 6, 2019

Describe the bug
Echo server doesn't reply back the payload to the sender.
It looks like a side effect of this patch according to git bisect - 2a63e34

To Reproduce
Followed steps in https://docs.zephyrproject.org/latest/guides/networking/qemu_setup.html#basic-setup

Send TCP from echo-client

Expected behavior
Echo-server should reply the packet with received payload

Impact
Basic functionality is broken.

Environment (please complete the following information):

  • OS: Qemu_x86
  • Toolchain: Zephyr SDK
@tedd-an tedd-an added the bug The issue is a bug, or the PR is fixing a bug label Jul 6, 2019
jukkar added a commit to jukkar/zephyr that referenced this issue Jul 8, 2019
This reverts commit 2a63e34.

This needs to be reverted as otherwise the type of ssize_t will be
"unsigned long" which is not correct.

    (gdb) ptype ssize_t
    type = unsigned long

For example this check would fail in that case

    ssize_t foo(void)
    {
        return -1;
    }
    ...
    if (foo() < 0) {
        printk("This is never called\n");
    }

Fixes zephyrproject-rtos#17378

Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
@tedd-an
Copy link
Collaborator Author

tedd-an commented Jul 8, 2019

Confirmed that #17393 fixes the issue.

jukkar added a commit that referenced this issue Jul 9, 2019
This reverts commit 2a63e34.

This needs to be reverted as otherwise the type of ssize_t will be
"unsigned long" which is not correct.

    (gdb) ptype ssize_t
    type = unsigned long

For example this check would fail in that case

    ssize_t foo(void)
    {
        return -1;
    }
    ...
    if (foo() < 0) {
        printk("This is never called\n");
    }

Fixes #17378

Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug, or the PR is fixing a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants