Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NRF5340 PA/LNA support #24142

Closed
binkboyd opened this issue Apr 7, 2020 · 8 comments · Fixed by #31336
Closed

NRF5340 PA/LNA support #24142

binkboyd opened this issue Apr 7, 2020 · 8 comments · Fixed by #31336
Assignees

Comments

@binkboyd
Copy link

binkboyd commented Apr 7, 2020

Describe the bug
When enabling PA/LNA pin control the build fails with what appears to be both GPIO and PPID related errors. It doesn't look like the NRF53 PA/LNA code is implemented yet.

To Reproduce
Steps to reproduce the behavior:
1)
add following to hci_rpmsg sample prj.conf, using the
CONFIG_BT_CTLR=y
CONFIG_BT_CTLR_GPIO_PA=y
CONFIG_BT_CTLR_GPIO_PA_PIN=29
CONFIG_BT_CTLR_GPIO_LNA=y
CONFIG_BT_CTLR_GPIO_LNA_PIN=24

west build samples/bluetooth/hci_rpmsg -b nrf5340_dk_nrf5340_cpunet
3)
Fails with lots of error, but seems to be both GPIO and ppi related:
...error: 'NRF_GPIO' undeclared (first use in this function); did you mean 'NRF_GPIOTE'?
#define NRF_GPIO_PA NRF_GPIO

...warning: implicit declaration of function 'hal_enable_palna_ppi_config'; did you mean 'hal_trigger_aar_ppi_config'? [-Wimplicit-function-declaration]

...error: 'HAL_ENABLE_PALNA_PPI' undeclared

Expected behavior
Expected the sample to build and PA/LNA control to work.

Impact
My board is not useable as I have an external amplifier which cannot be controlled by the NRF5340.

Environment (please complete the following information):

  • Latest NCS, so not up to date zephyr - but the affected file (radio.c) is the same as in latest zephyr master (7ba5e01)
@binkboyd binkboyd added the bug The issue is a bug, or the PR is fixing a bug label Apr 7, 2020
@binkboyd binkboyd changed the title NRF5340 PA/LNA doesnæt work NRF5340 PA/LNA doesn't work Apr 7, 2020
@carlescufi carlescufi added area: Bluetooth platform: nRF Nordic nRFx priority: low Low impact/importance bug labels Apr 7, 2020
@carlescufi
Copy link
Member

@anangl would you please take a look at this? It's a matter of porting the PPI to DPPI

@ioannisg
Copy link
Member

Is this really a bug @carlescufi ? PA/LNA support has not been ported yet to nRF5340, so AFAIU, it has never worked, so the ticket should be labeled as feature/enhancement

@carlescufi
Copy link
Member

Yep, agreed @ioannisg. Let's relabel this as hardware support

@carlescufi carlescufi added Hardware Support and removed bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug labels May 26, 2020
@carlescufi carlescufi changed the title NRF5340 PA/LNA doesn't work NRF5340 PA/LNA support May 26, 2020
@github-actions
Copy link

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

@github-actions github-actions bot added the Stale label Jul 26, 2020
@github-actions github-actions bot closed this as completed Aug 9, 2020
@ioannisg ioannisg reopened this Aug 10, 2020
@ioannisg ioannisg reopened this Aug 26, 2020
@ioannisg ioannisg reopened this Sep 17, 2020
@ioannisg ioannisg removed the Stale label Sep 17, 2020
@github-actions
Copy link

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

@github-actions github-actions bot added the Stale label Nov 17, 2020
@SloMusti
Copy link

I have the same issue and would like to use this functionality.

@cvinayak
Copy link
Contributor

@binkboyd and @SloMusti

Please try using #30950 and leave your comments here or in the PR.

Add the following to your application core MCU program, to permit the GPIO to be controlled by network core MCU.

	NRF_P0->PIN_CNF[29] =
		GPIO_PIN_CNF_MCUSEL_NetworkMCU << GPIO_PIN_CNF_MCUSEL_Pos;
	NRF_P0->PIN_CNF[24] =
		GPIO_PIN_CNF_MCUSEL_NetworkMCU << GPIO_PIN_CNF_MCUSEL_Pos;

cvinayak added a commit to cvinayak/zephyr that referenced this issue Jan 8, 2021
Ported the GPIO PA/LNA support for nRF53x by using a DPPI
channel.

Fixes zephyrproject-rtos#24142.

Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
@github-actions
Copy link

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

@github-actions github-actions bot added the Stale label Feb 21, 2021
@cvinayak cvinayak removed the Stale label Feb 23, 2021
cvinayak added a commit to cvinayak/zephyr that referenced this issue Apr 21, 2021
Ported the GPIO PA/LNA support for nRF53x by using a DPPI
channel.

Fixes zephyrproject-rtos#24142.

Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
carlescufi pushed a commit that referenced this issue Apr 21, 2021
Ported the GPIO PA/LNA support for nRF53x by using a DPPI
channel.

Fixes #24142.

Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment