Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/drivers/uart/uart_basic_api configure and config_get fail because not implemented #24355

Closed
jenmwms opened this issue Apr 14, 2020 · 1 comment · Fixed by #24995
Closed

tests/drivers/uart/uart_basic_api configure and config_get fail because not implemented #24355

jenmwms opened this issue Apr 14, 2020 · 1 comment · Fixed by #24995
Assignees
@MaureenHelm
Labels
area: Tests Issues related to a particular existing or missing test area: UART Universal Asynchronous Receiver-Transmitter bug The issue is a bug, or the PR is fixing a bug platform: NXP NXP priority: medium Medium impact/importance bug

Comments

@jenmwms
Copy link
Collaborator

jenmwms commented Apr 14, 2020 •
edited by carlescufi

Description
Multiple platforms fail uart_basic_api the .configure and .config_get tests (in the uart_basic_api test suite), because these functions are just not implemented at all.
To be fixed in the test, handling the case where the functions are not implemented and not failing the test if so.

Originally posted by @jenmwms @pfalcon in #23693 (comment)

To reproduce:

  1. west build -b frdm_k64f tests/drivers/uart/uart_basic_api
  2. west flash
  3. observe error

Expected Behavior
All tests PASS, including configure and config_get.

Actual Behavior
configure and config_get both FAIL

*** Booting Zephyr OS build zephyr-v2.2.0-1466-g1f3c014a1ad3  ***
Running test suite uart_basic_test
===================================================================
starting test - test_uart_configure
                                                                                
    Assertion failed at WEST_TOPDIR/zephyr/tests/drivers/uart/uart_basic_api/sre
                                                                                
FAIL - test_uart_configure                                                      
===================================================================             
starting test - test_uart_config_get                                            
This is a configure_get test.                                                   
                                                                                
    Assertion failed at WEST_TOPDIR/zephyr/tests/drivers/uart/uart_basic_api/sr)
set config error                                                                
FAIL - test_uart_config_get                                                     
===================================================================             
starting test - test_uart_fifo_fill                                             
This is a FIFO test.                                                            
PASS - test_uart_fifo_fill                                                      
===================================================================             
starting test - test_uart_fifo_read                                             
Please send characters to serial console                                        
PASS - test_uart_fifo_read                                                      
===================================================================             
starting test - test_uart_poll_in                                               
Please send characters to serial console                                        
PASS - test_uart_poll_in                                                        
===================================================================             
starting test - test_uart_poll_out                                              
This is a POLL test.                                                            
PASS - test_uart_poll_out                                                       
===================================================================             
Test suite uart_basic_test failed.                                              
===================================================================             
PROJECT EXECUTION FAILED

Environment

  • Fedora 30
  • Zephyr SDK
  • FRDM-K64F
  • 1f3c014
@carlescufi carlescufi added area: UART Universal Asynchronous Receiver-Transmitter bug The issue is a bug, or the PR is fixing a bug platform: NXP NXP labels Apr 21, 2020
@MaureenHelm
Copy link
Member

The mcux uart drivers don't implement the .configure and .config_get driver APIs, and therefore the wrapper functions return null.

@carlescufi carlescufi added area: Tests Issues related to a particular existing or missing test priority: low Low impact/importance bug labels Apr 30, 2020
@carlescufi carlescufi changed the title frdm_k64f fails configure and config_get tests tests/drivers/uart/uart_basic_api configure and config_get fail because not implemented May 5, 2020
@carlescufi carlescufi added priority: medium Medium impact/importance bug and removed priority: low Low impact/importance bug labels May 5, 2020
galak added a commit to galak/zephyr that referenced this issue May 5, 2020
@galak
tests: uart_basic_api: Don't FAIL non-implemented APIs
8ffd4a1 
A number of uart drivers may not implement the uart_configure and
uart_config_get APIs, if we get -ENOTSUP treat that as a skip.

Fixes zephyrproject-rtos#24355

Signed-off-by: Kumar Gala <kumar.gala@linaro.org>
@galak galak mentioned this issue May 5, 2020
Merged
MaureenHelm pushed a commit that referenced this issue May 6, 2020
@galak @MaureenHelm
tests: uart_basic_api: Don't FAIL non-implemented APIs
cbd9c86 
A number of uart drivers may not implement the uart_configure and
uart_config_get APIs, if we get -ENOTSUP treat that as a skip.

Fixes #24355

Signed-off-by: Kumar Gala <kumar.gala@linaro.org>
hakehuang pushed a commit to hakehuang/zephyr that referenced this issue Jun 20, 2020
@galak @hakehuang
tests: uart_basic_api: Don't FAIL non-implemented APIs
3c2ba89 
A number of uart drivers may not implement the uart_configure and
uart_config_get APIs, if we get -ENOTSUP treat that as a skip.

Fixes zephyrproject-rtos#24355

Signed-off-by: Kumar Gala <kumar.gala@linaro.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MaureenHelm MaureenHelm

Labels
area: Tests Issues related to a particular existing or missing test area: UART Universal Asynchronous Receiver-Transmitter bug The issue is a bug, or the PR is fixing a bug platform: NXP NXP priority: medium Medium impact/importance bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tests: uart_basic_api: Don't FAIL non-implemented APIs galak/zephyr
3 participants
@MaureenHelm @carlescufi @jenmwms