Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ieee802154 l2: no length check in frame validation #24970

Closed
tbursztyka opened this issue May 5, 2020 · 0 comments · Fixed by #24971
Closed

ieee802154 l2: no length check in frame validation #24970

tbursztyka opened this issue May 5, 2020 · 0 comments · Fixed by #24971
Assignees
@tbursztyka
Labels
area: IEEE 802.15.4 area: Networking area: Security Security bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug
Milestone
v2.3.0

Comments

@tbursztyka
Copy link
Collaborator

Describe the bug
If length does not fit with the frame format, it will lead to unknown state (crash, security hole... etc..)

Expected behavior
Frame length must be validated as well
@tbursztyka tbursztyka added bug The issue is a bug, or the PR is fixing a bug area: Networking area: Security Security area: IEEE 802.15.4 labels May 5, 2020
@tbursztyka tbursztyka added this to the v2.3.0 milestone May 5, 2020
@tbursztyka tbursztyka self-assigned this May 5, 2020
@tbursztyka tbursztyka mentioned this issue May 5, 2020
Merged
@jukkar jukkar added the priority: medium Medium impact/importance bug label May 5, 2020
tbursztyka pushed a commit to tbursztyka/zephyr that referenced this issue May 7, 2020
net/ieee802154: Validate length on received frames
5e56821 
Frame format was validated, but its length should be also validated
relevantly against the format.

Fixes zephyrproject-rtos#24970

Signed-off-by: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
jukkar pushed a commit that referenced this issue May 7, 2020
@jukkar
net/ieee802154: Validate length on received frames
38970c0 
Frame format was validated, but its length should be also validated
relevantly against the format.

Fixes #24970

Signed-off-by: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
hakehuang pushed a commit to hakehuang/zephyr that referenced this issue Jun 20, 2020
@hakehuang
net/ieee802154: Validate length on received frames
dd96892 
Frame format was validated, but its length should be also validated
relevantly against the format.

Fixes zephyrproject-rtos#24970

Signed-off-by: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
zephyrbot pushed a commit that referenced this issue Mar 17, 2021
@github-actions
net/ieee802154: Validate length on received frames
6e828a2 
Frame format was validated, but its length should be also validated
relevantly against the format.

Fixes #24970

Signed-off-by: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
nashif pushed a commit that referenced this issue Aug 30, 2021
@nashif
net/ieee802154: Validate length on received frames
afe7553 
Frame format was validated, but its length should be also validated
relevantly against the format.

Fixes #24970

Signed-off-by: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tbursztyka tbursztyka

Labels
area: IEEE 802.15.4 area: Networking area: Security Security bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug
Projects
None yet
Milestone
v2.3.0
Development

Successfully merging a pull request may close this issue.

net/ieee802154: Validate length on received frames tbursztyka/zephyr
2 participants
@jukkar @tbursztyka