Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redundant flash shell commands #25055

Closed
nordic-krch opened this issue May 7, 2020 · 4 comments
Closed

Redundant flash shell commands #25055

nordic-krch opened this issue May 7, 2020 · 4 comments
Assignees
@nvlsianpu
Labels
area: Flash area: Shell Shell subsystem Enhancement Changes/Updates/Additions to existing features Good first issue Good for a first time contributor to take priority: low Low impact/importance bug

Comments

@nordic-krch
Copy link
Contributor

Describe the bug
It's rather "bad impression" bug. samples/drivers/flash_shell implements commands to handle flash and there are already generic commands in drivers/flash/flash_shell.c which are not enabled in that example (because they overlap). It would be good to merge those two and clean up the example or even remove it and just enable flash commands in generic shell example.
@nordic-krch nordic-krch added bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug area: Flash area: Shell Shell subsystem labels May 7, 2020
@nordic-krch
Copy link
Contributor Author

@nvlsianpu fyi

@nvlsianpu nvlsianpu self-assigned this May 7, 2020
@github-actions
Copy link

github-actions bot commented Jul 7, 2020

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

@github-actions github-actions bot added the Stale label Jul 7, 2020
@nashif nashif added Enhancement Changes/Updates/Additions to existing features and removed Stale bug The issue is a bug, or the PR is fixing a bug labels Jul 25, 2020
@nashif nashif reopened this Jul 25, 2020
@nashif nashif added the Good first issue Good for a first time contributor to take label Aug 12, 2020
@eugmes
Copy link
Contributor

eugmes commented Sep 29, 2020

It seems that something has changed since this issue was reported. Right now I see two entries for 'flash' when I run the flash_shell sample. CONFIG_FLASH_SHELL is enabled for that sample.

@erwango
Copy link
Member

erwango commented Nov 30, 2022

Duplicate of #14260.
Closing this one as the other one is the most commented

@erwango erwango closed this as completed Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nvlsianpu nvlsianpu

Labels
area: Flash area: Shell Shell subsystem Enhancement Changes/Updates/Additions to existing features Good first issue Good for a first time contributor to take priority: low Low impact/importance bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@nashif @eugmes @nordic-krch @nvlsianpu @erwango