Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gPTP time sync fails if having more than one port #26080

Closed
jukkar opened this issue Jun 9, 2020 · 2 comments
Closed

gPTP time sync fails if having more than one port #26080

jukkar opened this issue Jun 9, 2020 · 2 comments
Assignees
@jukkar
Labels
area: Networking bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug Stale
Milestone
v1.14.3

Comments

@jukkar
Copy link
Member

jukkar commented Jun 9, 2020

Describe the bug
The gPTP time does not sync properly if there are more than one port. One can get multiple ports when having multiple Ethernet controllers with PTP clock support.
@jukkar jukkar added bug The issue is a bug, or the PR is fixing a bug area: Networking labels Jun 9, 2020
@jukkar jukkar added this to the v1.14.3 milestone Jun 9, 2020
@jukkar jukkar self-assigned this Jun 9, 2020
jukkar added a commit to jukkar/zephyr that referenced this issue Jun 9, 2020
@jukkar
net: gptp: Return proper port number for given interface
43ce42c 
The port number is stored starting from 0 in Ethernet context.
But in gPTP, it is an index which starts from 1. So increase
the value by 1 for a value returned from Ethernet context.

Fixes zephyrproject-rtos#26080

Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
@jukkar jukkar mentioned this issue Jun 9, 2020
Merged
@jukkar jukkar added the priority: low Low impact/importance bug label Jun 10, 2020
nashif pushed a commit that referenced this issue Jul 8, 2020
@jukkar @nashif
net: gptp: Return proper port number for given interface
091d47a 
The port number is stored starting from 0 in Ethernet context.
But in gPTP, it is an index which starts from 1. So increase
the value by 1 for a value returned from Ethernet context.

Fixes #26080

Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
@github-actions
Copy link

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

@github-actions github-actions bot added the Stale label Aug 10, 2020
@jukkar
Copy link
Member Author

jukkar commented Aug 10, 2020

Already fixed.

@jukkar jukkar closed this as completed Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jukkar jukkar

Labels
area: Networking bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug Stale
Projects
None yet
Milestone
v1.14.3
Development

No branches or pull requests
1 participant
@jukkar