Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Coverity CID :212961] Side effect in assertion in tests/kernel/threads/thread_apis/src/test_threads_cancel_abort.c #27838

Closed
zephyrbot opened this issue Aug 27, 2020 · 1 comment
Assignees
Labels
bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug

Comments

@zephyrbot
Copy link
Collaborator

Static code scan issues found in file:

https://github.com/zephyrproject-rtos/zephyr/tree/63e858262936c303ccb334ba6db680c3cd135823/tests/kernel/threads/thread_apis/src/test_threads_cancel_abort.c#L231

Category: Incorrect expression
Function: test_abort_from_isr
Component: Tests
CID: 212961

Details:

225         isr_finished = false;
226         k_thread_create(&tdata, tstack, STACK_SIZE, entry_abort_isr,
227                 NULL, NULL, NULL, 0, 0, K_NO_WAIT);
228    
229    
230         k_thread_join(&tdata, K_FOREVER);
>>>     CID 212961:  Incorrect expression  (ASSERT_SIDE_EFFECT)
>>>     Argument "isr_finished" of z_zassert() has a side effect because the variable is volatile.  The containing function might work differently in a non-debug build.
231         zassert_true(isr_finished, "ISR did not complete");

Please fix or provide comments in coverity using the link:

https://scan9.coverity.com/reports.htm#v32951/p12996.

Note: This issue was created automatically. Priority was set based on classification
of the file affected and the impact field in coverity. Assignees were set using the CODEOWNERS file.

@zephyrbot zephyrbot added bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug labels Aug 27, 2020
@nashif
Copy link
Member

nashif commented Aug 27, 2020

false positive

@nashif nashif closed this as completed Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug
Projects
None yet
Development

No branches or pull requests

4 participants