Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.14, v2.4] Bluetooth: Mesh: RPL cleared on LPN disconnect #29858

Closed
trond-snekvik opened this issue Nov 7, 2020 · 2 comments
Closed

[v1.14, v2.4] Bluetooth: Mesh: RPL cleared on LPN disconnect #29858

trond-snekvik opened this issue Nov 7, 2020 · 2 comments
Assignees
Labels
area: Bluetooth Mesh area: Bluetooth bug The issue is a bug, or the PR is fixing a bug priority: high High impact/importance bug
Milestone

Comments

@trond-snekvik
Copy link
Contributor

Whenever the LPN disconnects from a friend, it will clear its replay protection list.

This is invalid behavior, as the RPL should only be cleared on node reset.

Fixed in master in #28062, needs backport to the v1.14 LTS and v2.4.

@trond-snekvik trond-snekvik added bug The issue is a bug, or the PR is fixing a bug area: Bluetooth area: Bluetooth Mesh labels Nov 7, 2020
@trond-snekvik trond-snekvik self-assigned this Nov 7, 2020
trond-snekvik added a commit to trond-snekvik/zephyr that referenced this issue Nov 7, 2020
Moves the clearing of RPL out of the bt_mesh_rx_reset() to avoid it
being called outside of the node reset procedure.

Fixes zephyrproject-rtos#29858 for v1.14.

Signed-off-by: Trond Einar Snekvik <Trond.Einar.Snekvik@nordicsemi.no>
trond-snekvik added a commit to trond-snekvik/zephyr that referenced this issue Nov 7, 2020
Moves the clearing of RPL out of the bt_mesh_rx_reset() to avoid it
being called outside of the node reset procedure.

Fixes zephyrproject-rtos#29858 for v2.4.

Signed-off-by: Trond Einar Snekvik <Trond.Einar.Snekvik@nordicsemi.no>
@nashif nashif modified the milestones: v1.14.2, v1.14.3 Nov 10, 2020
@nashif nashif added the priority: high High impact/importance bug label Nov 10, 2020
@carlescufi carlescufi changed the title Bluetooth: Mesh: RPL cleared on LPN disconnect [v1.14, v2.4] Bluetooth: Mesh: RPL cleared on LPN disconnect Nov 12, 2020
nashif pushed a commit that referenced this issue Jan 10, 2021
Moves the clearing of RPL out of the bt_mesh_rx_reset() to avoid it
being called outside of the node reset procedure.

Fixes #29858 for v1.14.

Signed-off-by: Trond Einar Snekvik <Trond.Einar.Snekvik@nordicsemi.no>
nashif pushed a commit that referenced this issue Jan 10, 2021
Moves the clearing of RPL out of the bt_mesh_rx_reset() to avoid it
being called outside of the node reset procedure.

Fixes #29858 for v2.4.

Signed-off-by: Trond Einar Snekvik <Trond.Einar.Snekvik@nordicsemi.no>
@github-actions
Copy link

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

@github-actions github-actions bot added the Stale label Jan 12, 2021
@nashif nashif removed the Stale label Jan 12, 2021
@nashif
Copy link
Member

nashif commented Jan 12, 2021

afaik, this was fixed and merged already. #29859

@nashif nashif closed this as completed Jan 12, 2021
rxdu pushed a commit to rxdu/zephyr that referenced this issue Feb 27, 2021
Moves the clearing of RPL out of the bt_mesh_rx_reset() to avoid it
being called outside of the node reset procedure.

Fixes zephyrproject-rtos#29858 for v2.4.

Signed-off-by: Trond Einar Snekvik <Trond.Einar.Snekvik@nordicsemi.no>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Bluetooth Mesh area: Bluetooth bug The issue is a bug, or the PR is fixing a bug priority: high High impact/importance bug
Projects
None yet
Development

No branches or pull requests

2 participants