Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARC MetaWare TLS support #29920

Closed
ruuddw opened this issue Nov 10, 2020 · 1 comment · Fixed by #74518
Closed

ARC MetaWare TLS support #29920

ruuddw opened this issue Nov 10, 2020 · 1 comment · Fixed by #74518
Assignees
Labels
area: ARC ARC Architecture Enhancement Changes/Updates/Additions to existing features

Comments

@ruuddw
Copy link
Member

ruuddw commented Nov 10, 2020

Is your enhancement proposal related to a problem? Please describe.
Support for Thread Local Storage (TLS, __thread) has been recently added for the Zephyr toolchain. A quick test reveals that enabling it for MetaWare leads to build errors.

Describe the solution you'd like
TLS support for MetaWare, like for Zephyr ARC GNU toolchain.

Additional context
Enabling "TOOLCHAIN_SUPPORTS_THREAD_LOCAL_STORAGE" gives for tests/kernel/threads/tls:
lldac: error: errno.c:(.debug_info+0x16795): has non-ABS relocation R_ARC_SECTOFF against symbol 'z_errno_var'
lldac: error: main.c:(.debug_info+0x585): has non-ABS relocation R_ARC_SECTOFF against symbol 'thread_data01'

@ruuddw ruuddw added the Enhancement Changes/Updates/Additions to existing features label Nov 10, 2020
@ruuddw ruuddw added the area: ARC ARC Architecture label May 23, 2022
@zephyrbot
Copy link
Collaborator

Hi @evgeniy-paltsev,

This issue, marked as an Enhancement, was opened a while ago and did not get any traction. Please confirm the issue is correctly assigned and re-assign it otherwise.

Please take a moment to review if the issue is still relevant to the project. If it is, please provide feedback and direction on how to move forward. If it is not, has already been addressed, is a duplicate, or is no longer relevant, please close it with a short comment explaining the reason.

Thanks!

kokas-a pushed a commit to kokas-a/zephyr that referenced this issue Jun 19, 2024
Remove obsolete wrokaround with conditional turning off "-g"
flag when Thread Local Starage used.

Recent versions of MetaWare have no issue with linking files with
TSL-related data.

Moreover, pointed workaround breaks userspace for recently added
ARC-V platforms, as they use both TLS and DWARF info while compilaton
process.

Fixes zephyrproject-rtos#29920

Signed-off-by: Nikolay Agishev <agishev@synopsys.com>
kokas-a pushed a commit to kokas-a/zephyr that referenced this issue Jun 19, 2024
Remove obsolete workaround with conditional turning off "-g"
flag when Thread Local Storage used.

Recent versions of MetaWare have no issue with linking files with
TSL-related data.

Moreover, pointed workaround breaks userspace for recently added
ARC-V platforms, as they use both TLS and DWARF info while compilation
process.

Fixes zephyrproject-rtos#29920

Signed-off-by: Nikolay Agishev <agishev@synopsys.com>
kokas-a pushed a commit to kokas-a/zephyr that referenced this issue Jun 19, 2024
Remove obsolete workaround with conditional turning off "-g"
flag when Thread Local Storage used.

Recent versions of MetaWare have no issue with linking files with
TSL-related data.

Moreover, pointed workaround breaks userspace for recently added
ARC-V platforms, as they use both TLS and DWARF info while compilation
process.

Fixes zephyrproject-rtos#29920

Signed-off-by: Nikolay Agishev <agishev@synopsys.com>
aescolar pushed a commit that referenced this issue Jun 21, 2024
Remove obsolete workaround with conditional turning off "-g"
flag when Thread Local Storage used.

Recent versions of MetaWare have no issue with linking files with
TSL-related data.

Moreover, pointed workaround breaks userspace for recently added
ARC-V platforms, as they use both TLS and DWARF info while compilation
process.

Fixes #29920

Signed-off-by: Nikolay Agishev <agishev@synopsys.com>
coreboot-org-bot pushed a commit to coreboot/zephyr-cros that referenced this issue Jun 21, 2024
Remove obsolete workaround with conditional turning off "-g"
flag when Thread Local Storage used.

Recent versions of MetaWare have no issue with linking files with
TSL-related data.

Moreover, pointed workaround breaks userspace for recently added
ARC-V platforms, as they use both TLS and DWARF info while compilation
process.

Fixes zephyrproject-rtos/zephyr#29920

(cherry picked from commit 2d75d7b)

Original-Signed-off-by: Nikolay Agishev <agishev@synopsys.com>
GitOrigin-RevId: 2d75d7b
Change-Id: If21f7e6cca7cc0a6dbd698f1da6769245bbae5c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/zephyr/+/5648171
Commit-Queue: Dawid Niedźwiecki <dawidn@google.com>
Tested-by: ChromeOS Prod (Robot) <chromeos-ci-prod@chromeos-bot.iam.gserviceaccount.com>
Reviewed-by: Dawid Niedźwiecki <dawidn@google.com>
ekleezg pushed a commit to ekleezg/zephyr that referenced this issue Jun 22, 2024
Remove obsolete workaround with conditional turning off "-g"
flag when Thread Local Storage used.

Recent versions of MetaWare have no issue with linking files with
TSL-related data.

Moreover, pointed workaround breaks userspace for recently added
ARC-V platforms, as they use both TLS and DWARF info while compilation
process.

Fixes zephyrproject-rtos#29920

Signed-off-by: Nikolay Agishev <agishev@synopsys.com>
fogzot pushed a commit to dndg/zephyr that referenced this issue Jul 23, 2024
Remove obsolete workaround with conditional turning off "-g"
flag when Thread Local Storage used.

Recent versions of MetaWare have no issue with linking files with
TSL-related data.

Moreover, pointed workaround breaks userspace for recently added
ARC-V platforms, as they use both TLS and DWARF info while compilation
process.

Fixes zephyrproject-rtos#29920

Signed-off-by: Nikolay Agishev <agishev@synopsys.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ARC ARC Architecture Enhancement Changes/Updates/Additions to existing features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants