Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iso bind for slave not working as intended #31179

Closed
Thalley opened this issue Jan 8, 2021 · 1 comment · Fixed by #33766
Closed

iso bind for slave not working as intended #31179

Thalley opened this issue Jan 8, 2021 · 1 comment · Fixed by #33766
Assignees
Labels
area: Bluetooth Audio area: Bluetooth bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Milestone

Comments

@Thalley
Copy link
Collaborator

Thalley commented Jan 8, 2021

Describe the bug
In the ISO shell, there's an iso bind command that binds an ISO with a ACL connection. This also sets the QOS parameters (the CIG parameters). The issue is that the bind needs to be done on both the master and slave, but the QOS parameters should only be done for the master (in fact, the command will always fail for the slave).

Furthermore, in case that the command does fail, it changes the state of the ISO channel. I suppose that errors should revert any changes?

To Reproduce
Steps to reproduce the behavior:

  1. Establish connection between master and slave using the BT audio_shell
  2. Call iso bind on the slave and see that it fails

Expected behavior
Expected that the iso bind command will successfully return after binding the ISO on the slave, and not attempt to set any QOS parameters.

Impact
Since the bind will happen, even with the error, the command can still be used.

Logs and console output
N/A

Environment (please complete the following information):

  • OS: N/A
  • Toolchain N/A
  • Commit SHA: d904f95

Additional context
It has been discussed that setting the QOS parameters should be removed from iso bind and moved to a new command for the master. Alternatively, the command could/should check if the ISO is a master or slave, and act accordingly (i.e. iso bind for slave should just bind and not set parameters).

@Thalley Thalley added the bug The issue is a bug, or the PR is fixing a bug label Jan 8, 2021
@carlescufi carlescufi added the priority: low Low impact/importance bug label Jan 14, 2021
@carlescufi carlescufi added this to the v2.6.0 milestone Jan 28, 2021
@github-actions
Copy link

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Bluetooth Audio area: Bluetooth bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants