Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake -E env: unknown option '-Wno-unique_unit_address_if_enabled' #33693

Closed
nandojve opened this issue Mar 25, 2021 · 5 comments · Fixed by #32753
Closed

cmake -E env: unknown option '-Wno-unique_unit_address_if_enabled' #33693

nandojve opened this issue Mar 25, 2021 · 5 comments · Fixed by #32753
Assignees
Labels
bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Milestone

Comments

@nandojve
Copy link
Member

Describe the bug
The #31960 introduced the pre_dt_board.cmake file in many boards. The new rules add EXTRA_DTC_FLAGS "-Wno-unique_unit_address_if_enabled" to build system. This rules if not proper defined will break make menuconfig.

To Reproduce
Steps to reproduce the behavior:

  1. cd samples/hello_world
  2. west build -b atsamr21_xpro
  3. west build -t menuconfig
  4. See error

Expected behavior
west build -t menuconfig should never be broken by any change in Zephyr configuration.

Impact
It is not possible configure Zephyr without rollback.

Logs and console output

-- west build: running target menuconfig
...
cmake -E env: unknown option '-Wno-unique_unit_address_if_enabled'
...

Environment (please complete the following information):

  • OS: Linux
  • Toolchain Zephyr SDK sdk-0.12.3
  • Commit #mainline

Additional context
It is expected a test that can check broken Kconfig options

@nandojve nandojve added bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug labels Mar 25, 2021
@nandojve nandojve added this to the v2.6.0 milestone Mar 25, 2021
@chrta
Copy link
Collaborator

chrta commented Mar 25, 2021

Is this fixed with #32753 ?

@tejlmand
Copy link
Collaborator

Is this fixed with #32753 ?

I believe so.

@galak galak assigned mbolivar-nordic and unassigned nashif Mar 25, 2021
@nandojve
Copy link
Member Author

Is this fixed with #32753 ?

I believe so.

Works For Me!

@chrta chrta linked a pull request Apr 1, 2021 that will close this issue
@chrta
Copy link
Collaborator

chrta commented Apr 1, 2021

With the merge, this issue is now fixed and can be closed. I verified this with the current master and "Steps to reproduce"

@galak
Copy link
Collaborator

galak commented Apr 1, 2021

Closing this, @nandojve feel free to re-open if there is still an issue.

@galak galak closed this as completed Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants