Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Coverity CID: 220442] Pointless string comparison in tests/lib/c_lib/src/main.c #33794

Closed
zephyrbot opened this issue Mar 29, 2021 · 0 comments · Fixed by #34889
Closed

[Coverity CID: 220442] Pointless string comparison in tests/lib/c_lib/src/main.c #33794

zephyrbot opened this issue Mar 29, 2021 · 0 comments · Fixed by #34889
Assignees
@yingmingx
Labels
bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug
Milestone
v2.6.0

Comments

@zephyrbot
Copy link
Collaborator

Static code scan issues found in file:

https://github.com/zephyrproject-rtos/zephyr/tree/169144afa1826511ee6ec3f53d590b2c0d39d3d4/tests/lib/c_lib/src/main.c

Category: Incorrect expression
Function: test_strncmp
Component: Tests
CID: 220442

Details:

https://github.com/zephyrproject-rtos/zephyr/blob/169144afa1826511ee6ec3f53d590b2c0d39d3d4/tests/lib/c_lib/src/main.c

Please fix or provide comments in coverity using the link:

https://scan9.coverity.com/reports.htm#v29271/p12996.

Note: This issue was created automatically. Priority was set based on classification
of the file affected and the impact field in coverity. Assignees were set using the CODEOWNERS file.
@zephyrbot zephyrbot added bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug labels Mar 29, 2021
@nashif nashif assigned xiaofst and unassigned nashif Mar 29, 2021
@enjiamai enjiamai assigned enjiamai and unassigned xiaofst Apr 3, 2021
@enjiamai enjiamai assigned yingmingx and unassigned enjiamai Apr 21, 2021
@yingmingx yingmingx mentioned this issue May 6, 2021
Merged
yingmingx pushed a commit to yingmingx/zephyr that referenced this issue May 10, 2021
tests: libc: Update libc testcases to solve coverity issues
5501b79 
1. Refine some testcases for testing some libc functions, include
strlen(),strcmp(),strncmp(),memcmp(),memstr(),memcpy(),memmove()
strtol(),strtoul().
2. Change some code to make the code style consistent.

Fixes zephyrproject-rtos#33794
Fixes zephyrproject-rtos#33810
Fixes zephyrproject-rtos#33806

Signed-off-by: Ying ming <mingx.ying@intel.com>
@yingmingx yingmingx linked a pull request May 11, 2021 that will close this issue
tests: libc: Update libc testcases to solve coverity issues #34889
Merged
@galak galak added this to the v2.6.0 milestone May 11, 2021
nashif pushed a commit that referenced this issue May 12, 2021
@nashif
tests: libc: Update libc testcases to solve coverity issues
8e69daf 
1. Refine some testcases for testing some libc functions, include
strlen(),strcmp(),strncmp(),memcmp(),memstr(),memcpy(),memmove()
strtol(),strtoul().
2. Change some code to make the code style consistent.

Fixes #33794
Fixes #33810
Fixes #33806

Signed-off-by: Ying ming <mingx.ying@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yingmingx yingmingx

Labels
bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug
Projects
None yet
Milestone
v2.6.0
Development

Successfully merging a pull request may close this issue.

tests: libc: Update libc testcases to solve coverity issues yingmingx/zephyr
6 participants
@nashif @enjiamai @galak @zephyrbot @yingmingx @xiaofst