Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: kernel: fpu: Several tests related to fpu fail on nrf5340dk_nrf5340_cpuappns #33956

Closed
PerMac opened this issue Apr 1, 2021 · 1 comment · Fixed by #34034
Closed

tests: kernel: fpu: Several tests related to fpu fail on nrf5340dk_nrf5340_cpuappns #33956

PerMac opened this issue Apr 1, 2021 · 1 comment · Fixed by #34034
Assignees
@ioannisg @oyvindronningstad
Labels
area: Kernel area: Tests Issues related to a particular existing or missing test bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug

Comments

@PerMac
Copy link
Member

PerMac commented Apr 1, 2021 •
edited
Loading

Describe the bug
Several tests related to fpu fail on nrf5340dk_nrf5340_cpuappns. The following test scenarios fail to build:

  • benchmark.kernel.application.fp.arm from zephyr/tests/benchmarks/app_kernel/
  • driver.sensor.fpu from zephyr/tests/drivers/sensor/generic
  • kernel.common.stack_protection_arm_fpu_sharing from zephyr/tests/kernel/fatal/exception
  • kernel.fpu_sharing.kernel.fpu_sharing.float_disable.arm and kernel.fpu_sharing.kernel.fpu_sharing.generic.arm from zephyr/tests/kernel/fpu_sharing

To Reproduce
Steps to reproduce the behavior:

  1. have nrf5340dk connected
  2. run `scripts/twister -p nrf5340dk_nrf5340_cpuappns -T
  3. see error
  4. See error

Expected behavior
Tests pass

Impact
Not clear

Logs and console output
Not sure which parts are relevant. The output is very extensive.

Environment (please complete the following information):

  • OS: Ubuntu 18.04
  • Toolchain zephyr sdk 0.12.2
  • Commit SHA or Version used zephyr-v2.5.0-1831-g58a0ba6dbb28
@PerMac PerMac added the bug The issue is a bug, or the PR is fixing a bug label Apr 1, 2021
@PerMac PerMac added area: Kernel area: Tests Issues related to a particular existing or missing test labels Apr 1, 2021
@oyvindronningstad
Copy link
Collaborator

Turns out TFM doesn't support -mfloat-abi=hard. Fixing this is not trivial so it probably won't be done in the foreseeable future. We could set up a relationship between BUILD_WITH_TFM and FP_HARDABI though. @ioannisg @frkv thoughts?

oyvindronningstad added a commit to oyvindronningstad/zephyr that referenced this issue Apr 6, 2021
@oyvindronningstad
arch: arm: Disallow FP_HARDABI when building with TFM
82cffc5 
When building with TFM, the app is linked with libraries built by the
TFM build system. TFM is always built with -msoft-float which is
equivalent to -mfloat-abi=soft. FP_HARDABI adds -mfloat-abi=hard
which gives errors when linking with the libs from TFM since they are
built with a different ABI.

Fixes zephyrproject-rtos#33956

Signed-off-by: Øyvind Rønningstad <oyvind.ronningstad@nordicsemi.no>
@oyvindronningstad oyvindronningstad mentioned this issue Apr 6, 2021
Merged
@galak galak added has-pr priority: medium Medium impact/importance bug labels Apr 6, 2021
ioannisg pushed a commit to ioannisg/zephyr that referenced this issue Apr 9, 2021
@oyvindronningstad @ioannisg
arch: arm: Disallow FP_HARDABI when building with TFM
5292b21 
When building with TFM, the app is linked with libraries built by the
TFM build system. TFM is always built with -msoft-float which is
equivalent to -mfloat-abi=soft. FP_HARDABI adds -mfloat-abi=hard
which gives errors when linking with the libs from TFM since they are
built with a different ABI.

Fixes zephyrproject-rtos#33956

Signed-off-by: Øyvind Rønningstad <oyvind.ronningstad@nordicsemi.no>
Signed-off-by: Ioannis Glaropoulos <Ioannis.Glaropoulos@nordicsemi.no>
galak pushed a commit that referenced this issue Apr 9, 2021
@oyvindronningstad @galak
arch: arm: Disallow FP_HARDABI when building with TFM
80a351e 
When building with TFM, the app is linked with libraries built by the
TFM build system. TFM is always built with -msoft-float which is
equivalent to -mfloat-abi=soft. FP_HARDABI adds -mfloat-abi=hard
which gives errors when linking with the libs from TFM since they are
built with a different ABI.

Fixes #33956

Signed-off-by: Øyvind Rønningstad <oyvind.ronningstad@nordicsemi.no>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ioannisg ioannisg

@oyvindronningstad oyvindronningstad

Labels
area: Kernel area: Tests Issues related to a particular existing or missing test bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

arch: arm: Disallow FP_HARDABI when building with TFM oyvindronningstad/zephyr
4 participants
@ioannisg @oyvindronningstad @galak @PerMac