Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can: mcan: sjw-data devicetree configuration is not written correctly #35949

Closed
Urist-McGit opened this issue Jun 4, 2021 · 0 comments · Fixed by #35948
Closed

can: mcan: sjw-data devicetree configuration is not written correctly #35949

Urist-McGit opened this issue Jun 4, 2021 · 0 comments · Fixed by #35948
Labels
bug The issue is a bug, or the PR is fixing a bug

Comments

@Urist-McGit
Copy link
Contributor

Describe the bug
When setting the sjw-data field on M_CAN devicetree nodes the values are not written in the correct registers.

To Reproduce

  1. Configure sjw-data field on any M_CAN node
  2. Build the example under samples/drivers/can/ with CANFD enabled
  3. Run the example.

Expected behavior
The configured sjw-data is written to the to DBTP register.

Impact
The configured value is not respected. The NBTP register configuration gets destroyed in the process. This may cause the M_CAN module to not work as expected.

Environment :

  • OS: Debian 11 Testing
  • Toolchain: Zephyr SDK
  • Commit SHA: bfd2719

Additional context
I have proposed a fix for this issue here: #35948

@Urist-McGit Urist-McGit added the bug The issue is a bug, or the PR is fixing a bug label Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug, or the PR is fixing a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant