Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPENTHREAD_CUSTOM_PARAMETERS does not seem to work #37502

Closed
neye-zhaw opened this issue Aug 6, 2021 · 2 comments · Fixed by #37532
Closed

OPENTHREAD_CUSTOM_PARAMETERS does not seem to work #37502

neye-zhaw opened this issue Aug 6, 2021 · 2 comments · Fixed by #37532
Assignees
Labels
area: OpenThread bug The issue is a bug, or the PR is fixing a bug

Comments

@neye-zhaw
Copy link

OpenThread defines set with the OPENTHREAD_CUSTOM_PARAMETERS Kconfig
option don't seem to take effect.

Steps to reproduce:

  1. Set a custom parameter
    CONFIG_OPENTHREAD_CUSTOM_PARAMETERS="OPENTHREAD_CONFIG_MLE_CHILD_TIMEOUT_DEFAULT=610"
  2. Check the value with otThreadGetChildTimeout(). The default
    value of 240 is returned.

I'd expect the custom parameters to be applied.

This makes changing some of the OpenThread configuration hard or even impossible.

  • OS: Linux
  • zephyr-sdk-0.12.4
  • zephyr-v2.6.0 (fe7c2ef)

This affects the https://github.com/zephyrproject-rtos/openthread repo.

@neye-zhaw neye-zhaw added the bug The issue is a bug, or the PR is fixing a bug label Aug 6, 2021
@rlubos
Copy link
Contributor

rlubos commented Aug 9, 2021

@neye-zhaw Indeed, OpenThread build system integration, which combines Zephyr and OpenThread build systems, used some obsolete variables from OpenThread build system that were removed at some point. I've submitted a fix in #37532, please have a look.

@neye-zhaw
Copy link
Author

Thanks, the fix works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: OpenThread bug The issue is a bug, or the PR is fixing a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants