Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSIS: Add support for parallel operations and make implementation thread-safe #44867

Closed
MariuszSkamra opened this issue Apr 14, 2022 · 3 comments
Assignees
Labels
area: Bluetooth Audio area: Bluetooth Enhancement Changes/Updates/Additions to existing features

Comments

@MariuszSkamra
Copy link
Collaborator

Is your enhancement proposal related to a problem? Please describe.
The current implementation disallows parallel operations on different set members. This might be problematic, as CSIS will be most likely used from different contexts.

Looking at the code, there is a static structure active_members that holds context. I guess the user might get into trouble when tries to use this API with multithreads and forbids concurrent operations on 2 sets.

@asbjornsabo
Copy link
Collaborator

Zephyr-bt F2F: Applies for all profiles in LA Audio.

@zephyrbot zephyrbot added Needs review This PR needs attention from Zephyr's maintainers and removed Needs review This PR needs attention from Zephyr's maintainers labels Feb 8, 2024
@jori-nordic jori-nordic removed their assignment Feb 9, 2024
@Thalley
Copy link
Collaborator

Thalley commented Feb 9, 2024

This is still valid, but needs to be split up into multiple issues, as fixing the entire LE Audio stack in a single go would be impossible

@Thalley
Copy link
Collaborator

Thalley commented May 9, 2024

The parallel operation support was added by #44867. The thread-safe part require a new issue.

@Thalley Thalley closed this as completed May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Bluetooth Audio area: Bluetooth Enhancement Changes/Updates/Additions to existing features
Projects
Status: Done
Development

No branches or pull requests

6 participants