Compilation failures on Cavs 18/20/25 GCC

[nklayman]

Describe the bug
Compilation failures on cavs 18/20/25 with GCC since 43371d0

To Reproduce
Build any zephyr application (ie west build -b intel_adsp_cavs25 samples/hello_world)
SOF build (xtensa-build-zephyr.py) also fails

Impact
Forces XCC usage in order to compile.

Logs and console output

❯ west build -b intel_adsp_cavs25 samples/hello_world
[1/155] Building C object zephyr/CMakeFiles/offsets.dir/arch/xtensa/core/offsets/offsets.c.obj
FAILED: zephyr/CMakeFiles/offsets.dir/arch/xtensa/core/offsets/offsets.c.obj 
ccache /home/vscode/zephyr-sdk-0.14.1/xtensa-intel_s1000_zephyr-elf/bin/xtensa-intel_s1000_zephyr-elf-gcc -DKERNEL -D_FORTIFY_SOURCE=2 -D__ZEPHYR__=1 -I/workspaces/zephyr/zephyr/kernel/include -I/workspaces/zephyr/zephyr/arch/xtensa/include -I/workspaces/zephyr/zephyr/include/zephyr -I/workspaces/zephyr/zephyr/include -I/workspaces/zephyr/zephyr/build/zephyr/include/generated -I/workspaces/zephyr/zephyr/soc/xtensa/intel_adsp/cavs -I/workspaces/zephyr/zephyr/soc/xtensa/intel_adsp/cavs/include -I/workspaces/zephyr/zephyr/soc/xtensa/intel_adsp/cavs/include/intel_tgl_adsp -I/workspaces/zephyr/zephyr/soc/xtensa/intel_adsp/common/include -I/workspaces/zephyr/modules/hal/xtensa/include -I/workspaces/zephyr/modules/hal/xtensa/zephyr/soc/intel_tgl_adsp -isystem /workspaces/zephyr/zephyr/lib/libc/minimal/include -isystem /home/vscode/zephyr-sdk-0.14.1/xtensa-intel_s1000_zephyr-elf/bin/../lib/gcc/xtensa-intel_s1000_zephyr-elf/10.3.0/include -isystem /home/vscode/zephyr-sdk-0.14.1/xtensa-intel_s1000_zephyr-elf/bin/../lib/gcc/xtensa-intel_s1000_zephyr-elf/10.3.0/include-fixed -Os -imacros /workspaces/zephyr/zephyr/build/zephyr/include/generated/autoconf.h -ffreestanding -fno-common -g -gdwarf-4 -fdiagnostics-color=always --sysroot=/home/vscode/zephyr-sdk-0.14.1/xtensa-intel_s1000_zephyr-elf/xtensa-intel_s1000_zephyr-elf -imacros /workspaces/zephyr/zephyr/include/zephyr/toolchain/zephyr_stdint.h -Wall -Wformat -Wformat-security -Wno-format-zero-length -Wno-main -Wno-pointer-sign -Wpointer-arith -Wexpansion-to-defined -Wno-unused-but-set-variable -Werror=implicit-int -fno-asynchronous-unwind-tables -fno-pie -fno-pic -fno-reorder-functions -fno-defer-pop -fmacro-prefix-map=/workspaces/zephyr/zephyr/samples/hello_world=CMAKE_SOURCE_DIR -fmacro-prefix-map=/workspaces/zephyr/zephyr=ZEPHYR_BASE -fmacro-prefix-map=/workspaces/zephyr=WEST_TOPDIR -ffunction-sections -fdata-sections -mlongcalls -std=c99 -nostdinc -MD -MT zephyr/CMakeFiles/offsets.dir/arch/xtensa/core/offsets/offsets.c.obj -MF zephyr/CMakeFiles/offsets.dir/arch/xtensa/core/offsets/offsets.c.obj.d -o zephyr/CMakeFiles/offsets.dir/arch/xtensa/core/offsets/offsets.c.obj -c /workspaces/zephyr/zephyr/arch/xtensa/core/offsets/offsets.c
In file included from /workspaces/zephyr/zephyr/include/zephyr/arch/xtensa/arch.h:27,
                 from /workspaces/zephyr/zephyr/include/zephyr/arch/cpu.h:27,
                 from /workspaces/zephyr/zephyr/include/zephyr/kernel_includes.h:33,
                 from /workspaces/zephyr/zephyr/include/zephyr/kernel.h:17,
                 from /workspaces/zephyr/zephyr/include/zephyr/init.h:11,
                 from /workspaces/zephyr/zephyr/include/zephyr/device.h:29,
                 from /workspaces/zephyr/zephyr/kernel/include/kernel_offsets.h:6,
                 from /workspaces/zephyr/zephyr/arch/xtensa/core/offsets/offsets.c:7:
/workspaces/zephyr/zephyr/include/zephyr/arch/xtensa/irq.h:10:10: fatal error: xtensa/config/core-isa.h: No such file or directory
   10 | #include <xtensa/config/core-isa.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
ninja: build stopped: subcommand failed.
FATAL ERROR: command exited with status 1: /usr/bin/cmake --build /workspaces/zephyr/zephyr/build

Environment (please complete the following information):

• OS: Linux
• Toolchain: Zephyr SDK 0.14.2
• Commit d5222f3 (latest main)

[nklayman]

Turns out this was due to an outdated hal_xtensa clone, updating that fixes it.