Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changes to included linker scripts are not picked up by the build system #5010

Closed
andrewboie opened this issue Nov 15, 2017 · 0 comments · Fixed by #5407
Closed

changes to included linker scripts are not picked up by the build system #5010

andrewboie opened this issue Nov 15, 2017 · 0 comments · Fixed by #5407
Assignees
@SebastianBoe
Labels
area: Build System bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug

Comments

@andrewboie
Copy link
Contributor

This was a problem in the old Kbuild build system as well.

There's no dependency tracking for included linker scripts, which is pretty much all of them since the base linker script is typically a very small file under arch/xxx/soc that just includes other stuff.

We use the GCC preprocessor to generate the final script that gets fed to ld. Need to use GCC options like -MD to create the dependencies so we can correctly rebuild if one of the included linker scripts changes.
@andrewboie andrewboie added area: Build System bug The issue is a bug, or the PR is fixing a bug labels Nov 15, 2017
@SebastianBoe SebastianBoe self-assigned this Nov 17, 2017
@linkmeyer linkmeyer added the priority: low Low impact/importance bug label Nov 20, 2017
SebastianBoe added a commit to SebastianBoe/zephyr that referenced this issue Dec 15, 2017
@SebastianBoe
cmake: ld: Ensure that a linker script change triggers a rebuild
0ecd533 
This fixes
zephyrproject-rtos#5010. CMake has a
simple parser that can parse C-like files to find header
dependencies. But the parser needs to know what the include
directories are to be able to follow #include pragmas.

Signed-off-by: Sebastian Bøe <sebastian.boe@nordicsemi.no>
@SebastianBoe SebastianBoe mentioned this issue Dec 15, 2017
Merged
nashif pushed a commit that referenced this issue Jan 4, 2018
@SebastianBoe
cmake: ld: Ensure that a linker script change triggers a rebuild
b1ab501 
This fixes
#5010. CMake has a
simple parser that can parse C-like files to find header
dependencies. But the parser needs to know what the include
directories are to be able to follow #include pragmas.

Signed-off-by: Sebastian Bøe <sebastian.boe@nordicsemi.no>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SebastianBoe SebastianBoe

Labels
area: Build System bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve get api and fix ld script issue SebastianBoe/zephyr
3 participants
@SebastianBoe @andrewboie @linkmeyer