Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kconfig search has white on white text #53568

Closed
decsny opened this issue Jan 6, 2023 · 2 comments · Fixed by #54451
Closed

Kconfig search has white on white text #53568

decsny opened this issue Jan 6, 2023 · 2 comments · Fixed by #54451
Assignees
@gmarull
Labels
area: Documentation Infrastructure area: DX Developer and User Experience bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug

Comments

@decsny
Copy link
Member

decsny commented Jan 6, 2023

Describe the bug
The Kconfig search on the documentation site has white text on the white background of the search bar, so you can only see entered text by highlighting as seen in the screenshot below:
image

Expected behavior
Perhaps the text is meant to be white, but the background of the search bar should be black? I don't know, but I just expected the text to be readable

Impact
Annoyance

Environment (please complete the following information):
Other people have the same issue as me, and the common factors seem to be 1) Firefox 2) Windows 10 3) Windows has the dark color theme. Switching the windows color theme to light results in black on white text in the Kconfig search bar, as would be expected
@decsny decsny added bug The issue is a bug, or the PR is fixing a bug area: Documentation Infrastructure labels Jan 6, 2023
@beriberikix
Copy link

Was just going to report this. I'm on Windows 11 and latest Chrome (108.0.5359.125 (Official Build) (64-bit))

@gmarull gmarull self-assigned this Jan 9, 2023
@stephanosio stephanosio added priority: low Low impact/importance bug area: DX Developer and User Experience labels Jan 10, 2023
@decsny
Copy link
Member Author

decsny commented Jan 29, 2023

I have also confirmed the issue exists on linux mint on firefox as well

danieldegrasse added a commit to nxp-zephyr/zephyr that referenced this issue Feb 4, 2023
@danieldegrasse
docs: kconfig: restore appearance of kconfig search
e662c67 
Restore appearance of kconfig search, with rounded corners and
black background. This should resolve visibility issues encountered
on some browsers when running in dark mode

Fixes zephyrproject-rtos#53568

Signed-off-by: Daniel DeGrasse <daniel.degrasse@nxp.com>
@danieldegrasse danieldegrasse mentioned this issue Feb 4, 2023
Merged
danieldegrasse added a commit to nxp-zephyr/zephyr that referenced this issue Feb 4, 2023
@danieldegrasse
docs: kconfig: restore appearance of kconfig search
f9a7b94 
Restore appearance of kconfig search, with rounded corners and
black background. This should resolve visibility issues encountered
on some browsers when running in dark mode

Fixes zephyrproject-rtos#53568

Signed-off-by: Daniel DeGrasse <daniel.degrasse@nxp.com>
carlescufi pushed a commit that referenced this issue Feb 7, 2023
@danieldegrasse @carlescufi
docs: kconfig: restore appearance of kconfig search
83d5ed5 
Restore appearance of kconfig search, with rounded corners and
black background. This should resolve visibility issues encountered
on some browsers when running in dark mode

Fixes #53568

Signed-off-by: Daniel DeGrasse <daniel.degrasse@nxp.com>
asemjonovs pushed a commit to asemjonovs/zephyr that referenced this issue Feb 13, 2023
@danieldegrasse @asemjonovs
docs: kconfig: restore appearance of kconfig search
7d4293f 
Restore appearance of kconfig search, with rounded corners and
black background. This should resolve visibility issues encountered
on some browsers when running in dark mode

Fixes zephyrproject-rtos#53568

Signed-off-by: Daniel DeGrasse <daniel.degrasse@nxp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gmarull gmarull

Labels
area: Documentation Infrastructure area: DX Developer and User Experience bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: kconfig: restore appearance of kconfig search nxp-zephyr/zephyr
4 participants
@beriberikix @stephanosio @gmarull @decsny