Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of old runner options caused downstream breakage #54384

Closed
mbolivar-nordic opened this issue Feb 2, 2023 · 0 comments · Fixed by #53951
Closed

Removal of old runner options caused downstream breakage #54384

mbolivar-nordic opened this issue Feb 2, 2023 · 0 comments · Fixed by #53951
Assignees
Labels
area: Debugging area: Flashing bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug

Comments

@mbolivar-nordic
Copy link
Contributor

Describe the bug

Commit 2cee5ff ("scripts: west_commands: runners: remove deprecated options") was merged without the maintainer's approval and subsequently broke at least one known environment where the removed options were still in use.

Although that reported breakage was worked around via other means, the possibility remains open that other workflows which used these options have regressed and no longer work.

To Reproduce
Steps to reproduce the behavior:

  1. git checkout 2cee5ff
  2. west update
  3. west build -b nrf52840dk_nrf52840 samples/hello_world
  4. west flash --snr <your_board_snr>
  5. bzzt

Expected behavior

We should, whenever it is practical and does not cause undue maintenance burden, maintain backwards compatibility with older runner command line options to avoid breaking automated workflows using these options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Debugging area: Flashing bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant