Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STM32 clock frequency calculation error #54719

Closed
Logiase opened this issue Feb 10, 2023 · 3 comments · Fixed by #54716
Closed

STM32 clock frequency calculation error #54719

Logiase opened this issue Feb 10, 2023 · 3 comments · Fixed by #54716
Assignees
@erwango
Labels
bug The issue is a bug, or the PR is fixing a bug platform: STM32 ST Micro STM32 priority: low Low impact/importance bug

Comments

@Logiase
Copy link
Contributor

Logiase commented Feb 10, 2023

Describe the bug
Some STM32 model use a wrong pll frequency calculation which will cause an overflow.

To Reproduce

Build sample samples/subsys/usb/console on board blackpill_stm32f411ce or other stm32 board (except H7 MP1 U5) which support USB.

Expected behavior

USB sample work fine.

Impact
What impact does this issue have on your progress (e.g., annoyance, showstopper)

USB clock check will not pass if CONFIG_USB_DC_STM32_CLOCK_CHECK=y

Logs and console output

<err> usb_dc_stm32: USB Clock is not 48MHz (5050327)

Environment (please complete the following information):
@Logiase Logiase added the bug The issue is a bug, or the PR is fixing a bug label Feb 10, 2023
@Logiase Logiase mentioned this issue Feb 10, 2023
Merged
@Logiase
Copy link
Contributor Author

Logiase commented Feb 10, 2023 •
edited
Loading

A PR has been created to fix this issue. See #54716

@FRASTM FRASTM added the platform: STM32 ST Micro STM32 label Feb 13, 2023
@FRASTM FRASTM changed the title STM32 clock frequency claculation error STM32 clock frequency calculation error Feb 13, 2023
@laurenmurphyx64 laurenmurphyx64 added the priority: low Low impact/importance bug label Feb 14, 2023
@whati001 whati001 mentioned this issue Feb 15, 2023
Closed
@erwango erwango reopened this Feb 22, 2023
@erwango
Copy link
Member

erwango commented Feb 22, 2023

Reopen to allow backport in V3.3

@erwango erwango mentioned this issue Feb 22, 2023
Merged
@FRASTM
Copy link
Collaborator

FRASTM commented Mar 10, 2023

backport is now merged: closing

@FRASTM FRASTM closed this as completed Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erwango erwango

Labels
bug The issue is a bug, or the PR is fixing a bug platform: STM32 ST Micro STM32 priority: low Low impact/importance bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

driver: clock_control: fix stm32 pll freq calculation Logiase/zephyr
4 participants
@laurenmurphyx64 @erwango @Logiase @FRASTM