Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RESET kconfig option selected at root level by #59876

Closed
manuargue opened this issue Jun 30, 2023 · 0 comments · Fixed by #59877
Closed

RESET kconfig option selected at root level by #59876

manuargue opened this issue Jun 30, 2023 · 0 comments · Fixed by #59877
Assignees
Labels
bug The issue is a bug, or the PR is fixing a bug platform: Nuvoton Nuvoton

Comments

@manuargue
Copy link
Member

Describe the bug
CMake warning No SOURCES given to Zephyr library: drivers__reset when building for #58332 even if CONFIG_RESET is not selected by this SoC/board.

To Reproduce
west build -p always -b mr_canhubk3 ./samples/hello_world

Expected behavior
No warning is issued if CONFIG_RESET is not selected by the SoC/board.

Impact
annoyance

Logs and console output

west build -p always -b mr_canhubk3 .\samples\hello_world\
-- west build: generating a build system
Loading Zephyr default modules (Zephyr base).
-- Application: C:/Users/user/zephyrproject/zephyr/samples/hello_world
-- CMake version: 3.25.1
-- Found Python3: C:/Users/user/AppData/Local/Programs/Python/Python311/python.exe 
(found suitable exact version "3.11.1") found components: Interpreter
-- Cache files will be written to: C:/Users/user/zephyrproject/zephyr/.cache
-- Zephyr version: 3.4.99 (C:/Users/user/zephyrproject/zephyr)
-- Found west (found suitable version "0.14.0", minimum required is "0.14.0")
-- Board: mr_canhubk3
-- ZEPHYR_TOOLCHAIN_VARIANT not set, trying to locate Zephyr SDK
-- Found host-tools: zephyr 0.16.0 (C:/Users/user/tools/zephyr-sdk-0.16.0)
-- Found toolchain: zephyr 0.16.0 (C:/Users/user/tools/zephyr-sdk-0.16.0)
-- Found Dtc: C:/ProgramData/chocolatey/bin/dtc.exe (found suitable version "1.5.0", minimum required is "1.4.6")
-- Found BOARD.dts: C:/Users/user/zephyrproject/zephyr/boards/arm/mr_canhubk3/mr_canhubk3.dts      
-- Generated zephyr.dts: C:/Users/user/zephyrproject/zephyr/build/zephyr/zephyr.dts
-- Generated devicetree_generated.h: C:/Users/user/zephyrproject/zephyr/build/zephyr/include/generated/devicetree_generated.h
-- Including generated dts.cmake file: C:/Users/user/zephyrproject/zephyr/build/zephyr/dts.cmake   
Parsing C:/Users/user/zephyrproject/zephyr/Kconfig
Loaded configuration 'C:/Users/user/zephyrproject/zephyr/boards/arm/mr_canhubk3/mr_canhubk3_defconfig'
Merged configuration 'C:/Users/user/zephyrproject/zephyr/samples/hello_world/prj.conf'
Configuration saved to 'C:/Users/user/zephyrproject/zephyr/build/zephyr/.config'
Kconfig header saved to 'C:/Users/user/zephyrproject/zephyr/build/zephyr/include/generated/autoconf-- Found GnuLd: c:/users/user/tools/zephyr-sdk-0.16.0/arm-zephyr-eabi/bin/../lib/gcc/arm-zephyryr-eabi/12.2.0/../../../../arm-zephyr-eabi/bin/ld.bfd.exe (found version "2.38")                   -eabi/12
-- The C compiler identification is GNU 12.2.0
-- The CXX compiler identification is GNU 12.2.0
-- The ASM compiler identification is GNU
-- Found assembler: C:/Users/user/tools/zephyr-sdk-0.16.0/arm-zephyr-eabi/bin/arm-zephyr-eabi-g-gcc.exe                                                                                           cc.exe  
Load components for S32K344:
driver_common component is included.
driver_reset component is included.
device_CMSIS component is included.
CMSIS_Include_core_cm component is included.
device_system component is included.
driver_lpuart component is included.
CMake Warning at C:/Users/user/zephyrproject/zephyr/CMakeLists.txt:886 (message):
  No SOURCES given to Zephyr library: drivers__reset

  Excluding target from build.


-- Configuring done
-- Generating done

Environment (please complete the following information):

  • OS: Linux, Windows
  • Toolchain: Zephyr SDK 0.16.0
  • Commit SHA 69f7fd9

Additional context
This is a regression of https://github.com/zephyrproject-rtos/zephyr/pull/55406. The. The option selection must be guarded to not appear at root level.

@manuargue manuargue added the bug The issue is a bug, or the PR is fixing a bug label Jun 30, 2023
manuargue added a commit to nxp-zephyr/zephyr that referenced this issue Jun 30, 2023
It must be guarded so the option selection doesn't appear at root level.

Fixes zephyrproject-rtos#59876

Signed-off-by: Manuel Argüelles <manuel.arguelles@nxp.com>
@manuargue manuargue self-assigned this Jun 30, 2023
cfriedt pushed a commit that referenced this issue Jun 30, 2023
It must be guarded so the option selection doesn't appear at root level.

Fixes #59876

Signed-off-by: Manuel Argüelles <manuel.arguelles@nxp.com>
hlord2000 pushed a commit to hlord2000/zephyr that referenced this issue Jul 3, 2023
It must be guarded so the option selection doesn't appear at root level.

Fixes zephyrproject-rtos#59876

Signed-off-by: Manuel Argüelles <manuel.arguelles@nxp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug, or the PR is fixing a bug platform: Nuvoton Nuvoton
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant