Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

armclang support broken #62589

Closed
tejlmand opened this issue Sep 13, 2023 · 0 comments · Fixed by #62590
Closed

armclang support broken #62589

tejlmand opened this issue Sep 13, 2023 · 0 comments · Fixed by #62590
Assignees
@tejlmand
Labels
bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug

Comments

@tejlmand
Copy link
Collaborator

Notes (delete this)
Merging of PR: #60031 broke armclang support.

Describe the bug
PR #60031 has remove build targets from the build system, causing failures when building with armclang.

CMake Error at /projects/github/ncs/zephyr/cmake/linker/armlink/target.cmake:74 (target_link_libraries):
  Error evaluating generator expression:                                                                                                                                                                                                      

    $<TARGET_OBJECTS:arch__arm__core__aarch32__cortex_m>                                                                                                                                                                                      

  Objects of target "arch__arm__core__aarch32__cortex_m" referenced but no                                                                                                                                                                    
  such target exists.                                                                                                                                                                                                                         
Call Stack (most recent call first):                                                                                                                                                                                                          
  /projects/github/ncs/zephyr/CMakeLists.txt:1427 (toolchain_ld_link_elf)                                                                                                                                                                     

....

To Reproduce
Set ZEPHYR_TOOLCHAIN_VARIANT=armclang and build.

Expected behavior

Impact
Not possible to build using armclang

Logs and console output
See above.

Environment (please complete the following information):

Additional context
Add any other context that could be relevant to your issue, such as pin setting,
target configuration, ...
@tejlmand tejlmand added bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug labels Sep 13, 2023
@tejlmand tejlmand self-assigned this Sep 13, 2023
tejlmand added a commit to tejlmand/zephyr that referenced this issue Sep 13, 2023
@tejlmand
cmake: armlink: update CMake library to arch__arm__core__cortex_m
b3fa879 
Fixes: zephyrproject-rtos#62589
Follow-up: zephyrproject-rtos#60331

The PR zephyrproject-rtos#60331 moved CMake code to new folder location causing generated
library names to change.
This change impacted the use of those libraries in the Zephyr armlink
CMake code, causing CMake failures at configure time.

This PR fixes this failure by updating the armlink CMake code to use
the new library names.

Signed-off-by: Torsten Rasmussen <Torsten.Rasmussen@nordicsemi.no>
@tejlmand tejlmand mentioned this issue Sep 13, 2023
Merged
tejlmand added a commit to tejlmand/zephyr that referenced this issue Sep 13, 2023
@tejlmand
cmake: armlink: update CMake library to arch__arm__core__cortex_m
261ef30 
Fixes: zephyrproject-rtos#62589
Follow-up: zephyrproject-rtos#60331

The PR zephyrproject-rtos#60331 moved CMake code to new folder location causing generated
library names to change.
This change impacted the use of those libraries in the Zephyr armlink
CMake code, causing CMake failures at configure time.

This PR fixes this failure by updating the armlink CMake code to use
the new library names.

Signed-off-by: Torsten Rasmussen <Torsten.Rasmussen@nordicsemi.no>
tejlmand added a commit to tejlmand/zephyr that referenced this issue Sep 13, 2023
@tejlmand
cmake: armlink: update CMake library to arch__arm__core__cortex_m
ef46229 
Fixes: zephyrproject-rtos#62589
Follow-up: zephyrproject-rtos#60031

The PR zephyrproject-rtos#60031 moved CMake code to new folder location causing generated
library names to change.
This change impacted the use of those libraries in the Zephyr armlink
CMake code, causing CMake failures at configure time.

This PR fixes this failure by updating the armlink CMake code to use
the new library names.

Signed-off-by: Torsten Rasmussen <Torsten.Rasmussen@nordicsemi.no>
fabiobaltieri pushed a commit that referenced this issue Sep 13, 2023
@tejlmand @fabiobaltieri
cmake: armlink: update CMake library to arch__arm__core__cortex_m
73605f1 
Fixes: #62589
Follow-up: #60031

The PR #60031 moved CMake code to new folder location causing generated
library names to change.
This change impacted the use of those libraries in the Zephyr armlink
CMake code, causing CMake failures at configure time.

This PR fixes this failure by updating the armlink CMake code to use
the new library names.

Signed-off-by: Torsten Rasmussen <Torsten.Rasmussen@nordicsemi.no>
Dat-NguyenDuy pushed a commit to nxp-zephyr/zephyr that referenced this issue Sep 20, 2023
@tejlmand @Dat-NguyenDuy
cmake: armlink: update CMake library to arch__arm__core__cortex_m
f39f72b 
Fixes: zephyrproject-rtos#62589
Follow-up: zephyrproject-rtos#60031

The PR zephyrproject-rtos#60031 moved CMake code to new folder location causing generated
library names to change.
This change impacted the use of those libraries in the Zephyr armlink
CMake code, causing CMake failures at configure time.

This PR fixes this failure by updating the armlink CMake code to use
the new library names.

Signed-off-by: Torsten Rasmussen <Torsten.Rasmussen@nordicsemi.no>
coran21 pushed a commit to coran21/zephyr that referenced this issue Sep 21, 2023
@tejlmand @coran21
cmake: armlink: update CMake library to arch__arm__core__cortex_m
bad8213 
Fixes: zephyrproject-rtos#62589
Follow-up: zephyrproject-rtos#60031

The PR zephyrproject-rtos#60031 moved CMake code to new folder location causing generated
library names to change.
This change impacted the use of those libraries in the Zephyr armlink
CMake code, causing CMake failures at configure time.

This PR fixes this failure by updating the armlink CMake code to use
the new library names.

Signed-off-by: Torsten Rasmussen <Torsten.Rasmussen@nordicsemi.no>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tejlmand tejlmand

Labels
bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cmake: armlink: update CMake library to arch__arm__core__cortex_m tejlmand/zephyr
1 participant
@tejlmand