Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

top level CMakeList.txt test if LINKER_SCRIPT points to existing file #6983

Closed
eyuval opened this issue Apr 9, 2018 · 0 comments · Fixed by #7039
Closed

top level CMakeList.txt test if LINKER_SCRIPT points to existing file #6983

eyuval opened this issue Apr 9, 2018 · 0 comments · Fixed by #7039
Assignees
@SebastianBoe
Labels
bug The issue is a bug, or the PR is fixing a bug

Comments

@eyuval
Copy link

eyuval commented Apr 9, 2018

In the top level CMakeList.txt the existence of a custom linker script is tested as follows:
if(NOT EXISTS LINKER_SCRIPT)
set(LINKER_SCRIPT ${CONFIG_CUSTOM_LINKER_SCRIPT})
if(NOT EXISTS LINKER_SCRIPT)

I think the tests should be for ${LINKER_SCRIPT} and not for LINKER_SCRIPT
SebastianBoe added a commit to SebastianBoe/zephyr that referenced this issue Apr 12, 2018
@SebastianBoe
cmake: Fix CONFIG_CUSTOM_LINKER_SCRIPT
904f4d3 
Specifying a custom linker script is supposed to be supported through
Kconfig, but evidently this has been unused and 100% broken at least
since the CMake migration.

This commit fixes
zephyrproject-rtos#6983

Signed-off-by: Sebastian Bøe <sebastian.boe@nordicsemi.no>
@SebastianBoe SebastianBoe mentioned this issue Apr 12, 2018
Merged
@nashif nashif added the bug The issue is a bug, or the PR is fixing a bug label Apr 12, 2018
nashif pushed a commit that referenced this issue Apr 12, 2018
@SebastianBoe
cmake: Fix CONFIG_CUSTOM_LINKER_SCRIPT
c1aa9d1 
Specifying a custom linker script is supposed to be supported through
Kconfig, but evidently this has been unused and 100% broken at least
since the CMake migration.

This commit fixes
#6983

Signed-off-by: Sebastian Bøe <sebastian.boe@nordicsemi.no>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SebastianBoe SebastianBoe

Labels
bug The issue is a bug, or the PR is fixing a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cmake: Fix CONFIG_CUSTOM_LINKER_SCRIPT SebastianBoe/zephyr
3 participants
@nashif @SebastianBoe @eyuval