Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LE Audio: bap_broadcast_assistant add_pa_sync command igores BIS index parameter #70835

Closed
Thalley opened this issue Mar 28, 2024 · 0 comments · Fixed by #72002
Closed

LE Audio: bap_broadcast_assistant add_pa_sync command igores BIS index parameter #70835

Thalley opened this issue Mar 28, 2024 · 0 comments · Fixed by #72002
Assignees
@pin-zephyr
Labels
area: Bluetooth Audio area: Bluetooth bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug

Comments

@Thalley
Copy link
Collaborator

Thalley commented Mar 28, 2024

Describe the bug
The bap_broadcast_assistant add_pa_sync command has optional parameters to set the BIS index that we want to remote side to sync to, but after setting it, it then parses the known BASE and override it with all the BIS indexes in the BASE.

Ideally it would only use the BASE to verify the BIS indexes, so that the command can also be used to only tell the remote side to sync to PA without BIS.

To Reproduce
N/A

Expected behavior
When calling bap_broadcast_assistant add_pa_sync true 0x112233 0x02 it should only set the BIS index field to 0x02 and not to whatever is in the BASE.

If setting e.g. 0x03 and the BASE only has a single BIS, then the command should be rejected.

Impact
Minor

Logs and console output
N/A

Environment (please complete the following information):

  • Commit SHA or Version used: 98aa10d

Additional context
N/A
@Thalley Thalley added bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug area: Bluetooth area: Bluetooth Audio labels Mar 28, 2024
@Thalley Thalley assigned pin-zephyr and unassigned Thalley Apr 2, 2024
pin-zephyr added a commit to pin-zephyr/zephyr that referenced this issue Apr 26, 2024
@pin-zephyr
Bluetooth: Audio: Shell: adds support for BIS index parameter
01d6753 
When calling bap_broadcast_assistant add_pa_sync, it should only
set the BIS index field as optional parameters and not to whatever
is in the BASE.

If setting BIS index which the BASE does not support, then the
command should be rejected.

This PR fixes zephyrproject-rtos#70835

Signed-off-by: Ping Wang <pinw@demant.com>
@pin-zephyr pin-zephyr mentioned this issue Apr 26, 2024
Merged
pin-zephyr added a commit to pin-zephyr/zephyr that referenced this issue Apr 29, 2024
@pin-zephyr
Bluetooth: Audio: Shell: adds support for BIS index parameter
2e9dad2 
When calling bap_broadcast_assistant add_pa_sync, it should only
set the BIS index field as optional parameters and not to whatever
is in the BASE.

If setting BIS index which the BASE does not support, then the
command should be rejected.

This PR fixes zephyrproject-rtos#70835

Signed-off-by: Ping Wang <pinw@demant.com>
pin-zephyr added a commit to pin-zephyr/zephyr that referenced this issue Apr 29, 2024
@pin-zephyr
Bluetooth: Audio: Shell: adds support for BIS index parameter
4e72b73 
When calling bap_broadcast_assistant add_pa_sync, it should only
set the BIS index field as optional parameters and not to whatever
is in the BASE.

If setting BIS index which the BASE does not support, then the
command should be rejected.

This PR fixes zephyrproject-rtos#70835

Signed-off-by: Ping Wang <pinw@demant.com>
pin-zephyr added a commit to pin-zephyr/zephyr that referenced this issue Apr 29, 2024
@pin-zephyr
Bluetooth: Audio: Shell: adds support for BIS index parameter
7ebb702 
When calling bap_broadcast_assistant add_pa_sync, it should only
set the BIS index field as optional parameters and not to whatever
is in the BASE.

If setting BIS index which the BASE does not support, then the
command should be rejected.

This PR fixes zephyrproject-rtos#70835

Signed-off-by: Ping Wang <pinw@demant.com>
pin-zephyr added a commit to pin-zephyr/zephyr that referenced this issue Apr 30, 2024
@pin-zephyr
Bluetooth: Audio: Shell: adds support for BIS index parameter
082343e 
When calling bap_broadcast_assistant add_pa_sync, it should only
set the BIS index field as optional parameters and not to whatever
is in the BASE.

If setting BIS index which the BASE does not support, then the
command should be rejected.

This PR fixes zephyrproject-rtos#70835

Signed-off-by: Ping Wang <pinw@demant.com>
pin-zephyr added a commit to pin-zephyr/zephyr that referenced this issue Apr 30, 2024
@pin-zephyr
Bluetooth: Audio: Shell: adds support for BIS index parameter
43bd7c3 
When calling bap_broadcast_assistant add_pa_sync, it should only
set the BIS index field as optional parameters and not to whatever
is in the BASE.

If setting BIS index which the BASE does not support, then the
command should be rejected.

This PR fixes zephyrproject-rtos#70835

Signed-off-by: Ping Wang <pinw@demant.com>
pin-zephyr added a commit to pin-zephyr/zephyr that referenced this issue May 2, 2024
@pin-zephyr
Bluetooth: Audio: Shell: adds support for BIS index parameter
9823b61 
When calling bap_broadcast_assistant add_pa_sync, it should only
set the BIS index field as optional parameters and not to whatever
is in the BASE.

If setting BIS index which the BASE does not support, then the
command should be rejected.

This PR fixes zephyrproject-rtos#70835

Signed-off-by: Ping Wang <pinw@demant.com>
fabiobaltieri pushed a commit that referenced this issue May 6, 2024
@pin-zephyr @fabiobaltieri
Bluetooth: Audio: Shell: adds support for BIS index parameter
6a02763 
When calling bap_broadcast_assistant add_pa_sync, it should only
set the BIS index field as optional parameters and not to whatever
is in the BASE.

If setting BIS index which the BASE does not support, then the
command should be rejected.

This PR fixes #70835

Signed-off-by: Ping Wang <pinw@demant.com>
fabiobaltieri pushed a commit that referenced this issue May 6, 2024
@pin-zephyr @fabiobaltieri
Bluetooth: Audio: Shell: adds support for BIS index parameter
1188305 
When calling bap_broadcast_assistant add_pa_sync, it should only
set the BIS index field as optional parameters and not to whatever
is in the BASE.

If setting BIS index which the BASE does not support, then the
command should be rejected.

This PR fixes #70835

Signed-off-by: Ping Wang <pinw@demant.com>
coreboot-org-bot pushed a commit to coreboot/zephyr-cros that referenced this issue May 7, 2024
@pin-zephyr
Bluetooth: Audio: Shell: adds support for BIS index parameter
9fad272 
When calling bap_broadcast_assistant add_pa_sync, it should only
set the BIS index field as optional parameters and not to whatever
is in the BASE.

If setting BIS index which the BASE does not support, then the
command should be rejected.

This PR fixes zephyrproject-rtos/zephyr#70835

(cherry picked from commit 6a02763)

Original-Signed-off-by: Ping Wang <pinw@demant.com>
GitOrigin-RevId: 6a02763
Change-Id: I18369345065499daf7d15a516f56b730426a8ce2
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/zephyr/+/5520815
Tested-by: Ting Shen <phoenixshen@chromium.org>
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
Tested-by: ChromeOS Prod (Robot) <chromeos-ci-prod@chromeos-bot.iam.gserviceaccount.com>
Commit-Queue: Ting Shen <phoenixshen@chromium.org>
coreboot-org-bot pushed a commit to coreboot/zephyr-cros that referenced this issue May 7, 2024
@pin-zephyr
Bluetooth: Audio: Shell: adds support for BIS index parameter
308714b 
When calling bap_broadcast_assistant add_pa_sync, it should only
set the BIS index field as optional parameters and not to whatever
is in the BASE.

If setting BIS index which the BASE does not support, then the
command should be rejected.

This PR fixes zephyrproject-rtos/zephyr#70835

(cherry picked from commit 1188305)

Original-Signed-off-by: Ping Wang <pinw@demant.com>
GitOrigin-RevId: 1188305
Change-Id: I890ea6fe3a995abc55c74bdd54949654a3c67a8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/zephyr/+/5520816
Commit-Queue: Ting Shen <phoenixshen@chromium.org>
Tested-by: Ting Shen <phoenixshen@chromium.org>
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
Tested-by: ChromeOS Prod (Robot) <chromeos-ci-prod@chromeos-bot.iam.gserviceaccount.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pin-zephyr pin-zephyr

Labels
area: Bluetooth Audio area: Bluetooth bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
Bluetooth LE Audio
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Le audio shell bis index pin-zephyr/zephyr
2 participants
@Thalley @pin-zephyr