Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VERSION file may be picked from root '/' #71384

Closed
tejlmand opened this issue Apr 11, 2024 · 0 comments · Fixed by #71385
Closed

VERSION file may be picked from root '/' #71384

tejlmand opened this issue Apr 11, 2024 · 0 comments · Fixed by #71385
Assignees
@tejlmand
Labels
area: Build System bug The issue is a bug, or the PR is fixing a bug

Comments

@tejlmand
Copy link
Collaborator

When a (stray?) VERSION file is present at the root of the filesystem, Linux / MacOS /VERSION, Windows <drive>:\VERSION, then it may be picked up accidentally by Zephyr.

As such a root VERSION file is not intended for Zephyr, then chances are high that it doesn't follow the Zephyr formatting of the VERSION file.

This may result in hard to understand errors like this:

CMake Error at <path>/zephyr/cmake/modules/version.cmake:74 (math):
math cannot parse the expression: "( << 16) + ( << 8) + ()": syntax error,
unexpected exp_SHIFTLEFT (4).

See more details here: https://devzone.nordicsemi.com/f/nordic-q-a/109058/cmake-error-math-cannot-parse-the-expression-with-ncs-2-4-2/478116
@tejlmand tejlmand added the bug The issue is a bug, or the PR is fixing a bug label Apr 11, 2024
@tejlmand tejlmand self-assigned this Apr 11, 2024
tejlmand added a commit to tejlmand/zephyr that referenced this issue Apr 11, 2024
@tejlmand
cmake: fix issue with parsing version file located in /VERSION
8563124 
Fixes: zephyrproject-rtos#71384

A VERSION file placed in `/` or `<drive>:\` was accidentally being
picked up during `find_package(Zephyr)`.

This happened because Zephyr loads the VERSION file to determine if it
is the correct Zephyr to use.

During initial phase of find_package(), then APPLICATION_SOURCE_DIR is
not defined, causing one version file to be picked up from `/VERSION`
instead of `<app>/VERSION`. `/VERSION` is outside any Zephyr repo, west
workspace, or the application itself and therefore should not be picked
up accidentally.

Fix this be checking that APPLICATION_SOURCE_DIR is defined, and only
when defined, look for a VERSION file there.

Signed-off-by: Torsten Rasmussen <Torsten.Rasmussen@nordicsemi.no>
@tejlmand tejlmand mentioned this issue Apr 11, 2024
Merged
aescolar pushed a commit that referenced this issue Apr 15, 2024
@tejlmand @aescolar
cmake: fix issue with parsing version file located in /VERSION
4959a02 
Fixes: #71384

A VERSION file placed in `/` or `<drive>:\` was accidentally being
picked up during `find_package(Zephyr)`.

This happened because Zephyr loads the VERSION file to determine if it
is the correct Zephyr to use.

During initial phase of find_package(), then APPLICATION_SOURCE_DIR is
not defined, causing one version file to be picked up from `/VERSION`
instead of `<app>/VERSION`. `/VERSION` is outside any Zephyr repo, west
workspace, or the application itself and therefore should not be picked
up accidentally.

Fix this be checking that APPLICATION_SOURCE_DIR is defined, and only
when defined, look for a VERSION file there.

Signed-off-by: Torsten Rasmussen <Torsten.Rasmussen@nordicsemi.no>
zephyrbot pushed a commit that referenced this issue Apr 15, 2024
@tejlmand @github-actions
cmake: fix issue with parsing version file located in /VERSION
4177d90 
Fixes: #71384

A VERSION file placed in `/` or `<drive>:\` was accidentally being
picked up during `find_package(Zephyr)`.

This happened because Zephyr loads the VERSION file to determine if it
is the correct Zephyr to use.

During initial phase of find_package(), then APPLICATION_SOURCE_DIR is
not defined, causing one version file to be picked up from `/VERSION`
instead of `<app>/VERSION`. `/VERSION` is outside any Zephyr repo, west
workspace, or the application itself and therefore should not be picked
up accidentally.

Fix this be checking that APPLICATION_SOURCE_DIR is defined, and only
when defined, look for a VERSION file there.

Signed-off-by: Torsten Rasmussen <Torsten.Rasmussen@nordicsemi.no>
(cherry picked from commit 4959a02)
@nordicjm nordicjm mentioned this issue Apr 25, 2024
Merged
MaureenHelm pushed a commit that referenced this issue May 1, 2024
@tejlmand @MaureenHelm
cmake: fix issue with parsing version file located in /VERSION
ed1f5b7 
Fixes: #71384

A VERSION file placed in `/` or `<drive>:\` was accidentally being
picked up during `find_package(Zephyr)`.

This happened because Zephyr loads the VERSION file to determine if it
is the correct Zephyr to use.

During initial phase of find_package(), then APPLICATION_SOURCE_DIR is
not defined, causing one version file to be picked up from `/VERSION`
instead of `<app>/VERSION`. `/VERSION` is outside any Zephyr repo, west
workspace, or the application itself and therefore should not be picked
up accidentally.

Fix this be checking that APPLICATION_SOURCE_DIR is defined, and only
when defined, look for a VERSION file there.

Signed-off-by: Torsten Rasmussen <Torsten.Rasmussen@nordicsemi.no>
(cherry picked from commit 4959a02)
Lahyllas pushed a commit to tsnlab/zephyr that referenced this issue May 16, 2024
@tejlmand @Lahyllas
cmake: fix issue with parsing version file located in /VERSION
ea1ee77 
Fixes: zephyrproject-rtos#71384

A VERSION file placed in `/` or `<drive>:\` was accidentally being
picked up during `find_package(Zephyr)`.

This happened because Zephyr loads the VERSION file to determine if it
is the correct Zephyr to use.

During initial phase of find_package(), then APPLICATION_SOURCE_DIR is
not defined, causing one version file to be picked up from `/VERSION`
instead of `<app>/VERSION`. `/VERSION` is outside any Zephyr repo, west
workspace, or the application itself and therefore should not be picked
up accidentally.

Fix this be checking that APPLICATION_SOURCE_DIR is defined, and only
when defined, look for a VERSION file there.

Signed-off-by: Torsten Rasmussen <Torsten.Rasmussen@nordicsemi.no>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tejlmand tejlmand

Labels
area: Build System bug The issue is a bug, or the PR is fixing a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cmake: fix issue with parsing version file located in /VERSION tejlmand/zephyr
2 participants
@henrikbrixandersen @tejlmand