Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated configurations around SPI_CS_GPIO #9695

Closed
Olivier-ProGlove opened this issue Aug 28, 2018 · 1 comment
Closed

Deprecated configurations around SPI_CS_GPIO #9695

Olivier-ProGlove opened this issue Aug 28, 2018 · 1 comment
Assignees
Labels
bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug

Comments

@Olivier-ProGlove
Copy link
Contributor

I was rebasing my Zephyr application on v1.13 RC1 when I noticed warning: SPI_CS_GPIO defined without a type.

Searching into Zephyr code base for the new feature that has been used to replace this configuration shows me there are few platforms (arch/x86/soc/intel_quark, boards/arc/arduino_101_sss, boards/x86/arduino_101) and SPI options (SPI_n_CS_GPIO_PORT and SPI_n_CS_GPIO_PIN) depending on this non-existing KConfig option.

I guess it should be fixed/cleaned for v1.13.

I am not sure if SPI_CS_GPIO, SPI_n_CS_GPIO_PORT and SPI_n_CS_GPIO_PIN can be simply removed.

@nashif nashif added bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug labels Aug 29, 2018
@galak
Copy link
Collaborator

galak commented Dec 7, 2018

Looks like we've removed these so closing this issue. Please re-open if I missed something.

@galak galak closed this as completed Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Development

No branches or pull requests

4 participants