Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bluetooth: host: att read by group type request #9713

Closed
kapi-no opened this issue Aug 29, 2018 · 2 comments
Closed

bluetooth: host: att read by group type request #9713

kapi-no opened this issue Aug 29, 2018 · 2 comments
Assignees
Labels
area: Bluetooth Enhancement Changes/Updates/Additions to existing features

Comments

@kapi-no
Copy link
Collaborator

kapi-no commented Aug 29, 2018

Currently, there is no way to discover all Primary Services with bt_gatt_discover() API. User can only discover a specific service by passing its UUID value to the bt_gatt_discover_params structure (e. g. HRS). This is achieved at the ATT level with Find By Type Value request.

We can add this feature by using ATT Read By Group Type request. It can be triggered when user doesn't pass any UUID value to the bt_gatt_discover() function.

@Vudentz
Copy link
Contributor

Vudentz commented Aug 29, 2018

This was to discourage such use since systems running zephyr normally are quite tight in terms of memory and normally target peripherals which implement a restrict number of profiles. That said Im not opposing to open it for discovering all primary services as long as that doesn't introduce caching to the stack, in the other hand if the following feature request is to introduce service caching then Id just keep it as it is since I don't think we would be willing to spend memory, and possible flash, on that.

@nashif nashif added the Enhancement Changes/Updates/Additions to existing features label Aug 29, 2018
@Vudentz
Copy link
Contributor

Vudentz commented Sep 18, 2018

@kapi-no Could please review the changes.

Vudentz added a commit to Vudentz/zephyr that referenced this issue Sep 19, 2018
This makes bt_gatt_discover perform discover all proceduce if no UUID
is given in the parameters.

Fixes zephyrproject-rtos#9713

Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
sjanc pushed a commit to sjanc/zephyr that referenced this issue Dec 17, 2018
This makes bt_gatt_discover perform discover all proceduce if no UUID
is given in the parameters.

Fixes zephyrproject-rtos#9713

Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
nashif pushed a commit that referenced this issue Jan 29, 2019
This makes bt_gatt_discover perform discover all proceduce if no UUID
is given in the parameters.

Fixes #9713

Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Bluetooth Enhancement Changes/Updates/Additions to existing features
Projects
None yet
Development

No branches or pull requests

4 participants