cmake: Fall back to ZEPHYR_BASE when the board is not in BOARD_ROOT #10267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Misc. refactorings that clean up how BOARD_ROOT and BOARD_DIR are used. Signed-off-by: Sebastian Bøe <sebastian.boe@nordicsemi.no>
It is very inconvenient to maintain an application that both runs on a Zephyr board and an out-of-tree board. It forces one to write build scripts like this in the app: if(BOARD STREQUAL my_out_of_tree_board) set(BOARD_ROOT some/out/of/tree/board/path) endif() To avoid this we change the semantics of BOARD_ROOT. Instead of it being a path to the board root it is now a prioritized list of board root directories. Zephyr will append ZEPHYR_BASE to BOARD_ROOT. This ensures that Zephyr boards can be used when the out-of-tree board directory can not supply the requested board. Signed-off-by: Sebastian Bøe <sebastian.boe@nordicsemi.no>
Codecov Report
@@ Coverage Diff @@
## master #10267 +/- ##
=======================================
Coverage 53.05% 53.05%
=======================================
Files 214 214
Lines 26200 26200
Branches 5646 5646
=======================================
Hits 13900 13900
Misses 10027 10027
Partials 2273 2273Continue to review full report at Codecov.
|
nashif
approved these changes
Sep 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is very inconvenient to maintain an application that both runs on a
Zephyr board and an out-of-tree board.
It forces one to write build scripts like this in the app:
if(BOARD STREQUAL my_out_of_tree_board)
set(BOARD_ROOT some/out/of/tree/board/path)
endif()
To avoid this we change the semantics of BOARD_ROOT. Instead of it
being a path to the board root it is now a prioritized list of board
root directories. Zephyr will append ZEPHYR_BASE to BOARD_ROOT.
This ensures that Zephyr boards can be used when the out-of-tree board
directory can not supply the requested board.