Network raw socket support #11229

jukkar · 2018-11-09T08:40:06Z

This is work-in-progress PR, it is by no means ready but is more in RFC state atm.

Things that are still missing:

adding BSD socket support
raw packet sending
adding code to network device drivers to support raw socket receiving
more testing
support disabling/removal L3 code if that is not needed

Add ETH_P_xxx protocol types if they are missing. After this we can use the protocol types when working with BSD sockets. Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>

Various defines and helpers for supporting raw sockets. Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>

These are used by the network device driver and net_core when receiving the network packet. Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>

This commit adds basic raw socket support to net_context and allows application to receive or send network packets in raw format. Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>

We need to store the used upper layer protocol information into the network packet so that the packet can be handled if raw socket support is enabled. Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>

Print information about raw network packets received. Do not send them back in this version. Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>

codecov-io · 2018-11-09T09:09:49Z

Codecov Report

Merging #11229 into master will decrease coverage by 0.09%.
The diff coverage is 27.94%.

@@            Coverage Diff            @@
##           master   #11229     +/-   ##
=========================================
- Coverage    53.1%   53.01%   -0.1%     
=========================================
  Files         218      218             
  Lines       26883    26926     +43     
  Branches     5952     5963     +11     
=========================================
- Hits        14277    14275      -2     
- Misses      10172    10209     +37     
- Partials     2434     2442      +8

Impacted Files	Coverage Δ
subsys/net/ip/net_core.c	`73.52% <ø> (ø)`	⬆️
include/net/ethernet.h	`56.25% <ø> (ø)`	⬆️
subsys/net/ip/net_stats.h	`39.16% <ø> (ø)`	⬆️
include/net/net_ip.h	`71.26% <ø> (ø)`	⬆️
drivers/ethernet/eth_native_posix.c	`24.8% <0%> (-0.4%)`	⬇️
include/net/net_pkt.h	`84.9% <0%> (-0.81%)`	⬇️
subsys/net/ip/net_context.c	`57.93% <3.12%> (-3.51%)`	⬇️
include/net/net_context.h	`66.66% <56.25%> (-11.91%)`	⬇️
boards/posix/native_posix/timer_model.c	`51.09% <0%> (-0.73%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bde26fb...ec10f87. Read the comment docs.

pfalcon

This PR says "sockets", but at its current state, it doens't have changes for anything in net/lib/sockets/ (that's mentioned in the current description, yeah).

Raw sockets is very peculiar matter. Recv/send sides are quite inconsistent regarding for lower-level protocol header they return/accept or not.

I would like to see a sample application, in the vein of existing samples/net/sockets/, which can be compiled on both Linux and Zephyr, and behaves the same on both. (That's as a replacement of properly spec'ing what this is supposed to do - as we can't see to make people first explain what they want to do, and only then start dumping code.)

tbursztyka · 2018-11-22T14:40:20Z

include/net/net_context.h

+	NET_CONTEXT_AF_INET = 0,
+	NET_CONTEXT_AF_INET6,
+	NET_CONTEXT_AF_PACKET,
+} __packed;


why __packed?

tbursztyka · 2018-11-22T14:40:25Z

include/net/net_context.h

+	NET_CONTEXT_SOCK_DGRAM = 0,
+	NET_CONTEXT_SOCK_STREAM,
+	NET_CONTEXT_SOCK_RAW,
+} __packed;


tbursztyka · 2018-11-22T14:44:04Z

include/net/net_context.h

 	}

-	return AF_INET;
+	return 0;


shall it return AF_UNSPEC here instead?

tbursztyka · 2018-11-22T14:47:56Z

subsys/net/ip/connection_raw.c

@@ -0,0 +1,164 @@
+/** @file
+ * @brief Generic raw socket connection related functions


Gruik. I really hope you are going to merge all in connection.c instead of c/p 95% of its bare logic here just to add small raw dedicated stuff.

tbursztyka · 2018-11-22T14:52:53Z

subsys/net/ip/net_context.c

@@ -212,9 +237,11 @@ int net_context_get(sa_family_t family,
 		net_context_set_type(&contexts[i], type);
 		net_context_set_ip_proto(&contexts[i], ip_proto);

+#if defined(CONFIG_NET_IPV4) || defined(CONFIG_NET_IPV6)


use IS_ENABLED()

tbursztyka · 2018-11-22T14:55:24Z

subsys/net/ip/net_context.c

@@ -997,6 +1097,28 @@ static int sendto(struct net_pkt *pkt,
 		}
 	} else
 #endif /* CONFIG_NET_IPV4 */
+
+#if defined(CONFIG_NET_SOCKET_RAW)


tbursztyka · 2018-11-22T14:57:02Z

include/net/net_stats.h

@@ -149,6 +149,17 @@ struct net_stats_udp {
 	net_stats_t chkerr;
 };

+struct net_stats_raw {


Move the stats related part into its own patch

tbursztyka · 2018-11-22T15:51:08Z

include/net/net_pkt.h

@@ -178,6 +178,12 @@ struct net_pkt {
 	u8_t ieee802154_rssi; /* Received Signal Strength Indication */
 	u8_t ieee802154_lqi;  /* Link Quality Indicator */
 #endif
+
+#if defined(CONFIG_NET_SOCKET_RAW)
+	u16_t l2_proto;   /* IEEE 802.3 protocol value of the L2 (in network


Let's put it in a union, I guess above 116 to 140 could be the right place: there are 2 u8_t, which would need to be combined in an anonymous struct, and that u16_t. something like that

Also, can you call it raw_proto instead?

tbursztyka · 2018-11-22T15:54:22Z

drivers/ethernet/eth_native_posix.c

@@ -321,6 +322,8 @@ static int read_data(struct eth_context *ctx, int fd)
 		count += frag->len;
 	} while (ret > 0);

+	type = NET_ETH_HDR(pkt)->type;


I think that's something we'll need to think about. It piles up more stuff to add in every driver, while it could be centralized. I still would like to see this put into ethernet l2 somehow, here at this point you don't know if the packet is meant for a raw socket or not (and this approach would also make the union stuff as seen in previous patch impossible).

tbursztyka · 2018-11-22T15:56:28Z

include/net/net_context.h

@@ -283,11 +298,14 @@ struct net_context {
 #endif
 	} options;

-	/** Network interface assigned to this context */
-	u8_t iface;
+	/** Protocol (UDP, TCP or IEEE 802.3 protocol value */


missing ')'

rveerama1 · 2019-01-18T09:34:06Z

Closing this PR due to #12564. Future development will continue in #12564.

jukkar added 6 commits November 9, 2018 10:33

net: ethernet: Add more IEEE 802.3 protocol types

1a3b30e

Add ETH_P_xxx protocol types if they are missing. After this we can use the protocol types when working with BSD sockets. Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>

net: ip: Add helpers for raw socket support

37db71d

Various defines and helpers for supporting raw sockets. Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>

net: pkt: Add helpers to set/get the L2 protocol

ac56085

These are used by the network device driver and net_core when receiving the network packet. Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>

net: Add raw socket support

ce9a1cd

This commit adds basic raw socket support to net_context and allows application to receive or send network packets in raw format. Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>

drivers: eth: native_posix: Add raw socket support

5d7fa0d

We need to store the used upper layer protocol information into the network packet so that the packet can be handled if raw socket support is enabled. Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>

samples: net: echo-server: Add raw socket support

ec10f87

Print information about raw network packets received. Do not send them back in this version. Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>

jukkar added In progress For PRs: is work in progress and should not be merged yet. For issues: Is being worked on area: Networking DNM This PR should not be merged (Do Not Merge) labels Nov 9, 2018

jukkar requested review from pfalcon and tbursztyka as code owners November 9, 2018 08:40

jukkar added the RFC Request For Comments: want input from the community label Nov 9, 2018

jukkar mentioned this pull request Nov 12, 2018

L2 rework #10547

Merged

pfalcon added the area: Sockets Networking sockets label Nov 17, 2018

pfalcon requested changes Nov 17, 2018

View reviewed changes

tbursztyka requested changes Nov 22, 2018

View reviewed changes

pfl mentioned this pull request Dec 12, 2018

[RFC] Add PF_CAN protocol for socket CAN #11454

Closed

rveerama1 closed this Jan 18, 2019

ghost removed the In progress For PRs: is work in progress and should not be merged yet. For issues: Is being worked on label Jan 18, 2019

rveerama1 mentioned this pull request Jan 18, 2019

Network packet socket support. See "man 7 packet" on Linux. #12564

Merged

jukkar deleted the raw-socket branch February 29, 2024 08:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Network raw socket support #11229

Network raw socket support #11229

jukkar commented Nov 9, 2018

codecov-io commented Nov 9, 2018

pfalcon left a comment

tbursztyka Nov 22, 2018

tbursztyka Nov 22, 2018

tbursztyka Nov 22, 2018

tbursztyka Nov 22, 2018

tbursztyka Nov 22, 2018

tbursztyka Nov 22, 2018

tbursztyka Nov 22, 2018

tbursztyka Nov 22, 2018

tbursztyka Nov 22, 2018

tbursztyka Nov 22, 2018

rveerama1 commented Jan 18, 2019

		@@ -0,0 +1,164 @@
		/** @file
		* @brief Generic raw socket connection related functions

Network raw socket support #11229

Network raw socket support #11229

Conversation

jukkar commented Nov 9, 2018

codecov-io commented Nov 9, 2018

Codecov Report

pfalcon left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rveerama1 commented Jan 18, 2019