samples: net: lwm2m_client: build break fixes for k64F and pca10056 #11448
Conversation
During the modem overlay move from the K64F board directory to the LwM2M sample code, 2 DTS entries were dropped: current-speed = <115200>; status = "ok"; Without these entries the DTS defines for UART2 and CURRENT_SPEED are missing from the generated_dts_board.h file. Signed-off-by: Michael Scott <mike@foundries.io>
mike-scott
added
bug
Codecov Report
@@ Coverage Diff @@
## master #11448 +/- ##
=======================================
Coverage 48.38% 48.38%
=======================================
Files 265 265
Lines 42193 42193
Branches 10137 10137
=======================================
Hits 20413 20413
Misses 17703 17703
Partials 4077 4077Continue to review full report at Codecov.
|
When the WNC-14A2A modem binding was originally introduced, I thought the base_label would shorten the define keeping the result short and easily portable. Turns out with the latest changes, it has a side effect of removing the "DT_*" prefix which is breaking the build. Let's remove "base_label" from the modem binding and adjust all of the dts_fixups referring to the WNC14A2A defines. NOTE: This commit moves the left-over WNC14A2A dts_fixup defines from the nRF52 soc into samples/net/lwm2m_client as the new values. They will stay there until the modem can be re-configured as a shield. Signed-off-by: Michael Scott <mike@foundries.io>
mike-scott
changed the title
|
@galak So you're putting my build break patch on hold until I add a feature to the .yaml? |
Well how is the build breaking? I'm just saying w/o the yaml fix we aren't actually able to regress your fix ;). |
|
Which targets would we like to test build? I've tested: k64f, BLENano2, reel_board, disco_l475_iot1, nrf52840_pca10056, etc. However, there are often overlays involved (such as overlay-bt.conf). And of course if we want to test the modem we need k64f or nrf52840_pca10056 w/ overlay-wncm14a2a.conf. |
|
start with k64f and pca10056 |
Let's expand the sanity build testing for the lwm2m_client by doing the following: - Add variant builds for DTLS, bluetooth and modem - Check various combinations of hardware across each of these variant builds: frdm_k64f, nrf52_pca10040, nrf52840_pca10056, disco_l475_iot1 Signed-off-by: Michael Scott <mike@foundries.io>
|
I've added sanity testing for all of the various overlays so that we should be covered. If it's too much, let me know. |
Thanks! |
Over the last 2 weeks we've seen several DTS related changes which are causing build breaks when using the modem overlay in the lwm2m_client sample: