MHU: Add MHU driver support for SSE-200 subsystem #12722

karl-zh · 2019-01-25T05:50:15Z

MHU (Message Handling Unit) enable software to raise interrupts to
the processor cores.

This patch enable MHU driver on Musca A which has 2 MHU elements. It helps to communicate between 2 cores.

Signed-off-by: Karl Zhang karl.zhang@linaro.org

zephyrbot · 2019-01-25T05:54:45Z

All checks are passing now.

Review history of this comment for details about previous failed status.
Note that some checks might have not completed yet.

codecov-io · 2019-01-25T07:03:27Z

Codecov Report

Merging #12722 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #12722   +/-   ##
=======================================
  Coverage   52.46%   52.46%           
=======================================
  Files         322      322           
  Lines       46597    46597           
  Branches    10769    10769           
=======================================
  Hits        24446    24446           
  Misses      17246    17246           
  Partials     4905     4905

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cda6145...a8d626a. Read the comment docs.

MaureenHelm

Please look at implementing the IPM interface (include/ipm.h) rather than introducing a new interface.

galak · 2019-01-25T16:14:49Z

Please look at implementing the IPM interface (include/ipm.h) rather than introducing a new interface.

Agreed, please use the IPM interface for this driver.

Also, do we need some code and support for bringing up the second core in Zephyr, and running Zephyr on it?

karl-zh · 2019-01-26T12:15:56Z

Please look at implementing the IPM interface (include/ipm.h) rather than introducing a new interface.

Agreed, please use the IPM interface for this driver.

Also, do we need some code and support for bringing up the second core in Zephyr, and running Zephyr on it?

Okay, updated to ipm interface. I was thought that the MHU has no data transfer compare to ipm.
Yes, it needs some change to wake up another core on musca, I will have a sample about use MHU on Musca.

stanislav-poboril

Looks good, I have some comments to the commit message:

Maybe it should start with "drivers/ipm: "?
Shouldn't the word "enables" be here: MHU (Message Handling Unit) enable software
And "It enabled in SSE 200 subsystems." seems to miss "is" perhaps.

stanislav-poboril · 2019-01-28T07:04:38Z

drivers/ipm/ipm_mhu.c

+#define DEV_DATA(dev) \
+	((struct ipm_mhu_data *)(dev)->driver_data)
+#define IPM_MHU_REGS(dev) \
+	((volatile struct ipm_mhu_reg_map_t  *)(DEV_CFG(dev))->base)


two spaces between ipm_mhu_reg_map_t and *

Thanks for all you corrections, I will update them at next push.

drivers/ipm/ipm_mhu.h

galak · 2019-01-29T15:59:48Z

drivers/ipm/Kconfig

+	help
+	  Driver for SSE 200 MHU (Message Handling Unit)
+
+config IPM_MHU0


Do we need instance defines, can we get this from DT?

DT_ARM_MHU_0 or DT_ARM_MHU_1

DT_ARM_MHU_0 and DT_ARM_MHU_1 are always defined after mhu added into dts file, are they?
The config here provide a choice which MHU device should add as in this sub system include 2 MHU.
When enabling MHU device, there will be settings in the prj.conf like:

CONFIG_IPM=y
CONFIG_IPM_MHU=y
CONFIG_IPM_MHU0=y
CONFIG_IPM_MHU1=y

But that choice of which MHU can and should be handled by whats in the DTS. I don't think we need the Kconfig options here.

galak · 2019-01-29T16:00:54Z

drivers/ipm/ipm_mhu.c

+#define IPM_MHU_REGS(dev) \
+	((volatile struct ipm_mhu_reg_map_t  *)(DEV_CFG(dev))->base)
+
+#if defined(CONFIG_IPM_MHU0) || defined(CONFIG_IPM_MHU1)


This ifdef shouldn't be needed.

CONFIG_IPM=y
CONFIG_IPM_MHU=y
#CONFIG_IPM_MHU0=y
#CONFIG_IPM_MHU1=y

If config file above, there are warnings about some symbols declared but not used. Do we need to consider this scenario?

galak · 2019-01-29T16:01:16Z

drivers/ipm/ipm_mhu.c

+
+	p_mhu_dev_base = (volatile u32_t *)IPM_MHU_REGS(d);
+
+	p_cpu_id = (volatile u32_t *)(((u32_t)p_mhu_dev_base & 0xF0000000) +


Can we add a #define for the magic number 0xF0000000

boards/arm/v2m_musca/v2m_musca-common.dtsi

dts/bindings/mhu/arm,mhu.yaml

galak

Looks good, some minor review comments in a few places.

samples/subsys/ipc/ipm_mhu_dual_core/prj.conf

samples/subsys/ipc/ipm_mhu_dual_core/src/main.c

samples/subsys/ipc/ipm_mhu_dual_core/README.rst

dbkinder

getting closer on the docs...

samples/subsys/ipc/ipm_mhu_dual_core/README.rst

karl-zh · 2019-02-20T02:24:19Z

getting closer on the docs...

Thanks, updated now.

drivers/ipm/ipm_mhu.c

samples/subsys/ipc/ipm_mhu_dual_core/sample.yaml

samples/subsys/ipc/ipm_mhu_dual_core/src/main.c

drivers/ipm/ipm_mhu.c

dts/bindings/mhu/arm,mhu.yaml

samples/subsys/ipc/ipm_mhu_dual_core/CMakeLists.txt

samples/subsys/ipc/ipm_mhu_dual_core/src/main.c

drivers/ipm/ipm_mhu.c

samples/subsys/ipc/ipm_mhu_dual_core/src/main.c

MHU (Message Handling Unit) enables software to raise interrupts to the processor cores. It is enabled in SSE 200 subsystems. This patch aims to implement inter processor communication. Signed-off-by: Karl Zhang <karl.zhang@linaro.org>

Sample walk through: 1. CPU 0 will wake up CPU 1 after initialization 2. CPU 1 will send to CPU 0 an interrupt over MHU0 3. CPU 0 return the same to CPU 1 when received MHU0 interrupt 4. Test done when CPU 1 received MHU0 interrupt The wake up second core and private core ID are soc specific. Signed-off-by: Karl Zhang <karl.zhang@linaro.org>

karl-zh requested review from galak and MaureenHelm as code owners January 25, 2019 05:50

karl-zh force-pushed the MHU_driver branch from 748ecbc to da68aab Compare January 25, 2019 06:23

MaureenHelm requested changes Jan 25, 2019

View reviewed changes

MaureenHelm requested a review from stanislav-poboril January 25, 2019 15:02

karl-zh force-pushed the MHU_driver branch from da68aab to cece68c Compare January 26, 2019 10:28

stanislav-poboril approved these changes Jan 28, 2019

View reviewed changes

galak reviewed Jan 29, 2019

View reviewed changes

boards/arm/v2m_musca/v2m_musca-common.dtsi Show resolved Hide resolved

galak reviewed Jan 29, 2019

View reviewed changes

dts/bindings/mhu/arm,mhu.yaml Show resolved Hide resolved

galak requested changes Jan 29, 2019

View reviewed changes

karl-zh force-pushed the MHU_driver branch from cece68c to 8bb0865 Compare January 31, 2019 03:30

karl-zh requested a review from dbkinder as a code owner January 31, 2019 03:30

karl-zh commented Jan 31, 2019

View reviewed changes

samples/subsys/ipc/ipm_mhu_dual_core/prj.conf Outdated Show resolved Hide resolved

samples/subsys/ipc/ipm_mhu_dual_core/src/main.c Show resolved Hide resolved

samples/subsys/ipc/ipm_mhu_dual_core/src/main.c Show resolved Hide resolved

dbkinder suggested changes Jan 31, 2019

View reviewed changes

samples/subsys/ipc/ipm_mhu_dual_core/README.rst Outdated Show resolved Hide resolved

samples/subsys/ipc/ipm_mhu_dual_core/README.rst Outdated Show resolved Hide resolved

karl-zh force-pushed the MHU_driver branch 2 times, most recently from c291990 to 1a0632c Compare February 11, 2019 09:11

dbkinder suggested changes Feb 19, 2019

View reviewed changes

samples/subsys/ipc/ipm_mhu_dual_core/README.rst Show resolved Hide resolved

samples/subsys/ipc/ipm_mhu_dual_core/README.rst Outdated Show resolved Hide resolved

karl-zh force-pushed the MHU_driver branch from 1a0632c to a8d626a Compare February 20, 2019 02:21

karl-zh closed this Feb 20, 2019

karl-zh reopened this Feb 20, 2019

dbkinder approved these changes Feb 27, 2019

View reviewed changes

karl-zh commented Apr 19, 2019

View reviewed changes

drivers/ipm/ipm_mhu.c Outdated Show resolved Hide resolved

galak reviewed Apr 19, 2019

View reviewed changes

samples/subsys/ipc/ipm_mhu_dual_core/sample.yaml Outdated Show resolved Hide resolved

karl-zh force-pushed the MHU_driver branch from a8d626a to e84f8d4 Compare April 22, 2019 06:31

MaureenHelm reviewed Apr 22, 2019

View reviewed changes

samples/subsys/ipc/ipm_mhu_dual_core/src/main.c Outdated Show resolved Hide resolved

galak requested a review from ioannisg April 25, 2019 15:59

MaureenHelm requested changes May 13, 2019

View reviewed changes

karl-zh force-pushed the MHU_driver branch from e84f8d4 to 31d6ec2 Compare May 14, 2019 09:13

karl-zh requested a review from nashif as a code owner May 14, 2019 09:13

karl-zh force-pushed the MHU_driver branch from 31d6ec2 to 40b65d9 Compare May 14, 2019 12:20

MaureenHelm requested changes May 14, 2019

View reviewed changes

drivers/ipm/ipm_mhu.c Outdated Show resolved Hide resolved

drivers/ipm/ipm_mhu.c Outdated Show resolved Hide resolved

samples/subsys/ipc/ipm_mhu_dual_core/src/main.c Outdated Show resolved Hide resolved

karl-zh force-pushed the MHU_driver branch from 40b65d9 to 4991a37 Compare May 15, 2019 00:23

MaureenHelm approved these changes May 15, 2019

View reviewed changes

galak approved these changes May 15, 2019

View reviewed changes

Karl Zhang added 2 commits May 15, 2019 13:31

drivers: ipm: mhu: Add MHU driver for V2M Musca

bdc204e

MHU (Message Handling Unit) enables software to raise interrupts to the processor cores. It is enabled in SSE 200 subsystems. This patch aims to implement inter processor communication. Signed-off-by: Karl Zhang <karl.zhang@linaro.org>

galak force-pushed the MHU_driver branch from 4991a37 to f5a5599 Compare May 15, 2019 18:33

galak merged commit d75f3ce into zephyrproject-rtos:master May 15, 2019

karl-zh deleted the MHU_driver branch May 16, 2019 01:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MHU: Add MHU driver support for SSE-200 subsystem #12722

MHU: Add MHU driver support for SSE-200 subsystem #12722

karl-zh commented Jan 25, 2019

zephyrbot commented Jan 25, 2019 •

edited

codecov-io commented Jan 25, 2019 •

edited

MaureenHelm left a comment

galak commented Jan 25, 2019

karl-zh commented Jan 26, 2019

stanislav-poboril left a comment •

edited

stanislav-poboril Jan 28, 2019

karl-zh Jan 29, 2019 •

edited

galak Jan 29, 2019

karl-zh Jan 31, 2019

galak Apr 19, 2019

galak Jan 29, 2019

karl-zh Jan 31, 2019

galak Jan 29, 2019

galak left a comment

dbkinder left a comment

karl-zh commented Feb 20, 2019


		p_mhu_dev_base = (volatile u32_t *)IPM_MHU_REGS(d);

		p_cpu_id = (volatile u32_t *)(((u32_t)p_mhu_dev_base & 0xF0000000) +

MHU: Add MHU driver support for SSE-200 subsystem #12722

MHU: Add MHU driver support for SSE-200 subsystem #12722

Conversation

karl-zh commented Jan 25, 2019

zephyrbot commented Jan 25, 2019 • edited

codecov-io commented Jan 25, 2019 • edited

Codecov Report

MaureenHelm left a comment

Choose a reason for hiding this comment

galak commented Jan 25, 2019

karl-zh commented Jan 26, 2019

stanislav-poboril left a comment • edited

Choose a reason for hiding this comment

stanislav-poboril Jan 28, 2019

Choose a reason for hiding this comment

karl-zh Jan 29, 2019 • edited

Choose a reason for hiding this comment

galak Jan 29, 2019

Choose a reason for hiding this comment

karl-zh Jan 31, 2019

Choose a reason for hiding this comment

galak Apr 19, 2019

Choose a reason for hiding this comment

galak Jan 29, 2019

Choose a reason for hiding this comment

karl-zh Jan 31, 2019

Choose a reason for hiding this comment

galak Jan 29, 2019

Choose a reason for hiding this comment

galak left a comment

Choose a reason for hiding this comment

dbkinder left a comment

Choose a reason for hiding this comment

karl-zh commented Feb 20, 2019

zephyrbot commented Jan 25, 2019 •

edited

codecov-io commented Jan 25, 2019 •

edited

stanislav-poboril left a comment •

edited

karl-zh Jan 29, 2019 •

edited