uart/ns16550: Use DT_ prefix for remaining device configs

[dcpleung]

Previous rename from CONFIG_* to DT_* left a few remaining
CONFIG_*. So rename them manually now.

Fix #13753

Signed-off-by: Daniel Leung daniel.leung@intel.com

[ulfalizer]

Will e.g. {CONFIG/DT}_UART_NS16550_PORT_0_BAUD_RATE always come from DTS? There's still a Kconfig symbol definition for it in drivers/serial/Kconfig.ns16550, within an if !HAS_DTS block.

I think the thinking behind it is that dts_fixup.h will have a #define CONFIG_* for cases where the value could come from either DTS or Kconfig (so that code that uses the setting can work for both cases). That's not the case for e.g. *_UART_NS16550_PORT_2_BAUD_RATE (note, 2 instead of 0) though, because there is no Kconfig symbol called UART_NS16550_PORT_2_BAUD_RATE (unlike for index 0).

[dcpleung]

I think we should unify how all NS16550 ports are being configured. So if there is a baud rate kconfig for one, all four ports should have that. However, I think we should all move to DTS configuration. Though, if we go that route, can we remove those options now, after feature freeze? If not, I can always change those DT_* back to CONFIG_*.

[ulfalizer]

@dcpleung
Don't know what our policy is there. @nashif or @galak might.

I'm happy with getting rid of Kconfig symbols at least. We have too many.

[codecov-io]

Codecov Report

Merging #13760 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #13760   +/-   ##
=======================================
  Coverage   52.24%   52.24%           
=======================================
  Files         307      307           
  Lines       45413    45413           
  Branches    10508    10508           
=======================================
  Hits        23726    23726           
  Misses      16898    16898           
  Partials     4789     4789

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5951cd...c1e7b4e. Read the comment docs.