test/mempool: bug demonstration test #16728
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Tests
|
Found the following issues, please fix and resubmit: Codeowners issues |
npitre
force-pushed
the
mempoolbroken
branch
2 times, most recently
from
f12f146
to
1eef8c0
Compare
andyross
approved these changes
Jun 20, 2019
There was a problem hiding this comment.
This should absolutely go in as a regression check. Would be good to clean up the commit message to describe the symptom being tested ("Check that blocks of different levels don't overlap", etc...) and not just label it a "serious bug".
Ideally it would also be folded into one of the existing mem_pool tests, as the build time involved in separate test cases is a performance annoyance in CI; we try to keep things to a minimum of processes. But we could come along later and do that.
(Obviously needs to wait for a fix to land before merging, of course.)
andyross
pushed a commit
to andyross/zephyr
that referenced
this pull request
Jun 24, 2019
The block_fits() predicate was borked. It would check that a block fits within the bounds of the whole heap. But that's not enough: because of alignment changes between levels the sub-blocks may be adjusted forward. It needs to fit inside the PARENT block that it was split from. What could happen at runtime is that the last subblocks of a misaligned parent block would overlap memory from subsequent blocks, or even run off the end of the heap. That's bad. Change the API of block_fits() a little so it can extract the parent region and do this properly. Fixes zephyrproject-rtos#15279. Passes test introduced in zephyrproject-rtos#16728 to demonstrate what seems like the same issue. Signed-off-by: Andy Ross <andrew.j.ross@intel.com>
andrewboie
pushed a commit
that referenced
this pull request
Jun 26, 2019
The block_fits() predicate was borked. It would check that a block fits within the bounds of the whole heap. But that's not enough: because of alignment changes between levels the sub-blocks may be adjusted forward. It needs to fit inside the PARENT block that it was split from. What could happen at runtime is that the last subblocks of a misaligned parent block would overlap memory from subsequent blocks, or even run off the end of the heap. That's bad. Change the API of block_fits() a little so it can extract the parent region and do this properly. Fixes #15279. Passes test introduced in #16728 to demonstrate what seems like the same issue. Signed-off-by: Andy Ross <andrew.j.ross@intel.com>
This test demonstrates a serious bugs that exist in the mem-pool code as ovf Zephyr v1.14.0, and probably earlier versions too. This bug is fixed with PR zephyrproject-rtos#16966. Signed-off-by: Nicolas Pitre <npitre@baylibre.com>
npitre
pushed a commit
to npitre/zephyr
that referenced
this pull request
Jul 18, 2019
The block_fits() predicate was borked. It would check that a block fits within the bounds of the whole heap. But that's not enough: because of alignment changes between levels the sub-blocks may be adjusted forward. It needs to fit inside the PARENT block that it was split from. What could happen at runtime is that the last subblocks of a misaligned parent block would overlap memory from subsequent blocks, or even run off the end of the heap. That's bad. Change the API of block_fits() a little so it can extract the parent region and do this properly. Fixes zephyrproject-rtos#15279. Passes test introduced in zephyrproject-rtos#16728 to demonstrate what seems like the same issue. Signed-off-by: Andy Ross <andrew.j.ross@intel.com>
andrewboie
pushed a commit
to andrewboie/zephyr
that referenced
this pull request
Jul 24, 2019
The block_fits() predicate was borked. It would check that a block fits within the bounds of the whole heap. But that's not enough: because of alignment changes between levels the sub-blocks may be adjusted forward. It needs to fit inside the PARENT block that it was split from. What could happen at runtime is that the last subblocks of a misaligned parent block would overlap memory from subsequent blocks, or even run off the end of the heap. That's bad. Change the API of block_fits() a little so it can extract the parent region and do this properly. Fixes zephyrproject-rtos#15279. Passes test introduced in zephyrproject-rtos#16728 to demonstrate what seems like the same issue. Signed-off-by: Andy Ross <andrew.j.ross@intel.com>
nashif
pushed a commit
that referenced
this pull request
Aug 14, 2019
The block_fits() predicate was borked. It would check that a block fits within the bounds of the whole heap. But that's not enough: because of alignment changes between levels the sub-blocks may be adjusted forward. It needs to fit inside the PARENT block that it was split from. What could happen at runtime is that the last subblocks of a misaligned parent block would overlap memory from subsequent blocks, or even run off the end of the heap. That's bad. Change the API of block_fits() a little so it can extract the parent region and do this properly. Fixes #15279. Passes test introduced in #16728 to demonstrate what seems like the same issue. Signed-off-by: Andy Ross <andrew.j.ross@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test demonstrates one of the serious bugs that exist in the
mem-pool implementation as ovf Zephyr v1.14.0, and probably earlier
versions too.
Fixes for those bugs are contained in PR #16703.