Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts: elf_helper: correct kernel object address check range #17360

Merged
merged 1 commit into from Jul 8, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 3 additions & 6 deletions scripts/elf_helper.py
Expand Up @@ -385,10 +385,8 @@ def find_kobjects(self, syms):
sys.stderr.write("ELF file has no DWARF information\n")
sys.exit(1)

kram_start = syms["__kernel_ram_start"]
kram_end = syms["__kernel_ram_end"]
krom_start = syms["_image_rom_start"]
krom_end = syms["_image_rom_end"]
app_smem_start = syms["_app_smem_start"]
app_smem_end = syms["_app_smem_end"]

di = self.elf.get_dwarf_info()

Expand Down Expand Up @@ -501,8 +499,7 @@ def find_kobjects(self, syms):

_, user_ram_allowed = kobjects[ko.type_obj.name]
if (not user_ram_allowed and
(addr < kram_start or addr >= kram_end) and
(addr < krom_start or addr >= krom_end)):
(addr >= app_smem_start and addr < app_smem_end)):

self.debug_die(die,
"object '%s' found in invalid location %s"
Expand Down