fcb: start using errno codes #17481
Merged
fcb: start using errno codes #17481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvlsianpu
added
area: Storage
zephyrbot
added
area: Settings
nvlsianpu
force-pushed
the
fcb/use_errno
branch
from
dd0f61e
to
1a04cd0
Compare
nvlsianpu
force-pushed
the
fcb/use_errno
branch
from
1a04cd0
to
938e577
Compare
|
cc @carlescufi |
carlescufi
approved these changes
Aug 8, 2019
|
@nvlsianpu #17425 is merged. |
|
@nvlsianpu is this needed for 2.0? |
|
@ioannisg Not need - but still wort to merge, this is cleanup patch IMO. |
|
@nvlsianpu there's a typo |
nvlsianpu
force-pushed
the
fcb/use_errno
branch
from
938e577
to
aeee50f
Compare
|
@carlescufi ^^ fixed |
Switch form using privater FCB error codes to errno codes. FCB private codes convention were compatible with <errno.h> codes: - 0 mean success - negative values mean errors - similar error types. There was no sense to kept private FCB error codes. Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>
nvlsianpu
force-pushed
the
fcb/use_errno
branch
from
aeee50f
to
e953f1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch form using privater FCB error codes to
errno codes. FCB private codes convention were compatible
with <errno.h> codes:
There was no sense to kept private FCB error codes.
merge after #17425 as need to remove codes from fcb.hmergedSigned-off-by: Andrzej Puzdrowski andrzej.puzdrowski@nordicsemi.no