Add support for Nordic's nRF52833 SoC #20222

barsok · 2019-10-29T16:30:29Z

The PR together with another PR in hal_nordic (zephyrproject-rtos/hal_nordic#12) provide support for compiling code for the nRF52833 cpu and PCA10100 development kit board.

zephyrbot · 2019-10-29T16:33:21Z

All checks are passing now.

checkpatch (informational only, not a failure)

-:390: WARNING:UNDOCUMENTED_DT_STRING: DT compatible string "nordic,pca10100-dk" appears un-documented -- check ./dts/bindings/
#390: FILE: boards/arm/nrf52833_pca10100/nrf52833_pca10100.dts:12:
+	compatible = "nordic,pca10100-dk", "nordic,nrf52833-qiaa",

-:390: WARNING:UNDOCUMENTED_DT_STRING: DT compatible string "nordic,nrf52833-qiaa" appears un-documented -- check ./dts/bindings/
#390: FILE: boards/arm/nrf52833_pca10100/nrf52833_pca10100.dts:12:
+	compatible = "nordic,pca10100-dk", "nordic,nrf52833-qiaa",

-:583: WARNING:LONG_LINE_COMMENT: line over 80 characters
#583: FILE: boards/arm/nrf52833_pca10100/nrf52833_pca10100.dts:205:
+	 * http://docs.zephyrproject.org/latest/guides/dts/index.html#flash-partitions

-:1018: WARNING:LONG_LINE_COMMENT: line over 80 characters
#1018: FILE: dts/arm/nordic/nrf52833.dtsi:95:
+			/* uart can be either UART or UARTE, for the user to pick */

-:1019: WARNING:LONG_LINE_COMMENT: line over 80 characters
#1019: FILE: dts/arm/nordic/nrf52833.dtsi:96:
+			/* compatible = "nordic,nrf-uarte" or "nordic,nrf-uart"; */

-:1341: WARNING:UNDOCUMENTED_DT_STRING: DT compatible string "nordic,nRF52833-QIAA" appears un-documented -- check ./dts/bindings/
#1341: FILE: dts/arm/nordic/nrf52833_qiaa.dtsi:20:
+		compatible = "nordic,nRF52833-QIAA", "nordic,nRF52833", "nordic,nRF52", "simple-bus";

-:1341: WARNING:UNDOCUMENTED_DT_STRING: DT compatible string "nordic,nRF52833" appears un-documented -- check ./dts/bindings/
#1341: FILE: dts/arm/nordic/nrf52833_qiaa.dtsi:20:
+		compatible = "nordic,nRF52833-QIAA", "nordic,nRF52833", "nordic,nRF52", "simple-bus";

-:1341: WARNING:UNDOCUMENTED_DT_STRING: DT compatible string "nordic,nRF52" appears un-documented -- check ./dts/bindings/
#1341: FILE: dts/arm/nordic/nrf52833_qiaa.dtsi:20:
+		compatible = "nordic,nRF52833-QIAA", "nordic,nRF52833", "nordic,nRF52", "simple-bus";

-:1341: WARNING:UNDOCUMENTED_DT_STRING: DT compatible string "simple-bus" appears un-documented -- check ./dts/bindings/
#1341: FILE: dts/arm/nordic/nrf52833_qiaa.dtsi:20:
+		compatible = "nordic,nRF52833-QIAA", "nordic,nRF52833", "nordic,nRF52", "simple-bus";

-:1341: WARNING:LONG_LINE: line over 80 characters
#1341: FILE: dts/arm/nordic/nrf52833_qiaa.dtsi:20:
+		compatible = "nordic,nRF52833-QIAA", "nordic,nRF52833", "nordic,nRF52", "simple-bus";

-:2156: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#2156: FILE: tests/drivers/adc/adc_api/src/test_adc.c:37:
+      defined(CONFIG_BOARD_NRF52833_PCA10100) || \$

- total: 0 errors, 11 warnings, 2003 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Your patch has style problems, please review.

NOTE: Ignored message types: AVOID_EXTERNS BRACES CONFIG_EXPERIMENTAL CONST_STRUCT DATE_TIME FILE_PATH_CHANGES MINMAX NETWORKING_BLOCK_COMMENT_STYLE PRINTK_WITHOUT_KERN_LEVEL SPLIT_STRING VOLATILE

NOTE: If any of the errors are false positives, please report
      them to the maintainers.

Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

dbkinder

Is there a documentation update needed for this change?

@dbkinder I have included the doc for the development board to this PR

dbkinder

@ioannisg A couple of tweaks, otherwise LGTM.

boards/arm/nrf52833_pca10100/doc/index.rst

carlescufi · 2019-11-08T18:55:15Z

@dbkinder could you take another look?

dbkinder

docs LGTM, thanks!

carlescufi · 2019-11-08T19:19:43Z

Thanks @dbkinder!

This commit adds basic support for nRF52833 SoC. Changes affect introducing: - architecuture files (dtsi) - configuration of nrfx drivers - adaptation of inclusions based on chosen SoC - configuration of NFCT_PINS_AS_GPIOS depends on HAS_HW_NRF_NFCT. Signed-off-by: Emil Obalski <emil.obalski@nordicsemi.no>

This commit adds support for nRF52833 development board. Changes afffects: - Introduce files related to board description. - Add blank documentation file (for future update). - configuration files for build process. Signed-off-by: Emil Obalski <emil.obalski@nordicsemi.no>

By adding new SoC to Zephyr drivers has to be updated. Commit affects: - USB driver - support for nRF52833 added. - support for USB_DEVICE_REMOTE_WAKEUP in hid-mouse added. - SPI - IEEE 802.15.4 - CLOCK CONTROL Signed-off-by: Emil Obalski <emil.obalski@nordicsemi.no>

Name convention for nordic USB driver changed Kconfig files for custom boards have to be udapted accordingly. Changes affect only name convention change. Signed-off-by: Emil Obalski <emil.obalski@nordicsemi.no>

This commit adds support for bluetooth in nRF52833 SoC. Bluetooth radio related files created and added to Zephyr. Signed-off-by: Emil Obalski <emil.obalski@nordicsemi.no>

add support for nrf52833 and pca10100 Signed-off-by: Bartosz Sokolski <bartosz.sokolski@nordicsemi.no>

Update Zephyr manifest so it picks the tip of hal_nordic. Signed-off-by: Bartosz Sokolski <bartosz.sokolski@nordicsemi.no> Signed-off-by: Ioannis Glaropoulos <Ioannis.Glaropoulos@nordicsemi.no>

ioannisg · 2019-11-11T15:23:44Z

Marking this with TSC, to consider pushing this after -rc1 tag, as exception, during feature-freeze. Although this does not really count as exception simply because the PR was ready before freeze, but could not be merged due to upstream CI issues.

MaureenHelm · 2019-11-12T21:32:43Z

boards/arm/nrf52833_pca10100/doc/index.rst

+Applications for the ``nrf52833_pca10100`` board configuration can be
+built and flashed in the usual way (see :ref:`build_an_application`
+and :ref:`application_run` for more details); however, the standard
+debugging targets are not currently available.


why not? you enabled jlink, pyocd, and openocd runners

Agree, this looks like a copy/paste error

galak · 2019-11-13T16:33:23Z

Approved by TSC for merge into 2.1

barsok requested review from carlescufi, cvinayak, dbkinder, finikorg, galak, ioannisg, jfischer-no, lemrey, MaureenHelm, nashif, nordic-krch, tbursztyka and thoh-ot as code owners October 29, 2019 16:30

zephyrbot added area: Devicetree area: SPI SPI bus area: Boards area: Bluetooth area: API Changes to public APIs area: Samples Samples labels Oct 29, 2019

anangl mentioned this pull request Oct 30, 2019

hal: nordic: add support for nrf52833 zephyrproject-rtos/hal_nordic#12

Merged

barsok force-pushed the bsokol-support-nrf52833-pr branch 2 times, most recently from 27da06b to 28e2df5 Compare October 30, 2019 15:45

zephyrbot added the area: Modules label Oct 30, 2019

barsok added DNM This PR should not be merged (Do Not Merge) Blocked Blocked by another PR or issue labels Oct 30, 2019

barsok force-pushed the bsokol-support-nrf52833-pr branch from 28e2df5 to 337399d Compare October 30, 2019 15:52

dbkinder reviewed Oct 30, 2019

View reviewed changes

thoh-ot removed their request for review October 31, 2019 11:07

barsok force-pushed the bsokol-support-nrf52833-pr branch from 337399d to 203ad61 Compare October 31, 2019 15:04

anangl approved these changes Nov 8, 2019

View reviewed changes

ioannisg force-pushed the bsokol-support-nrf52833-pr branch from 654c469 to 4826560 Compare November 8, 2019 14:24

ioannisg requested a review from SebastianBoe November 8, 2019 16:54

ioannisg removed Blocked Blocked by another PR or issue DNM This PR should not be merged (Do Not Merge) labels Nov 8, 2019

carlescufi approved these changes Nov 8, 2019

View reviewed changes

dbkinder suggested changes Nov 8, 2019

View reviewed changes

boards/arm/nrf52833_pca10100/doc/index.rst Outdated Show resolved Hide resolved

boards/arm/nrf52833_pca10100/doc/index.rst Outdated Show resolved Hide resolved

ioannisg force-pushed the bsokol-support-nrf52833-pr branch from 4826560 to 8f3ce9c Compare November 8, 2019 18:42

ioannisg requested a review from dbkinder November 8, 2019 18:43

carlescufi changed the title ~~Add support for compilation for Nordic nRF52833~~ Add support for Nordic's nRF52833 SoC Nov 8, 2019

dbkinder approved these changes Nov 8, 2019

View reviewed changes

ioannisg force-pushed the bsokol-support-nrf52833-pr branch from 8f3ce9c to c9c3cf5 Compare November 8, 2019 22:50

Emil Obalski and others added 7 commits November 11, 2019 09:41

boards: Update defconfigs after renaming to USB_NRFX

0ae220f

Name convention for nordic USB driver changed Kconfig files for custom boards have to be udapted accordingly. Changes affect only name convention change. Signed-off-by: Emil Obalski <emil.obalski@nordicsemi.no>

bluetooth: Add bluetooth support for nRF52833

8fc4e1d

This commit adds support for bluetooth in nRF52833 SoC. Bluetooth radio related files created and added to Zephyr. Signed-off-by: Emil Obalski <emil.obalski@nordicsemi.no>

tests: drivers: add support for nrf52833 and pca10100

f06cd66

add support for nrf52833 and pca10100 Signed-off-by: Bartosz Sokolski <bartosz.sokolski@nordicsemi.no>

manifest: update manifest for hal_nordic

ff716b9

Update Zephyr manifest so it picks the tip of hal_nordic. Signed-off-by: Bartosz Sokolski <bartosz.sokolski@nordicsemi.no> Signed-off-by: Ioannis Glaropoulos <Ioannis.Glaropoulos@nordicsemi.no>

ioannisg force-pushed the bsokol-support-nrf52833-pr branch from c9c3cf5 to ff716b9 Compare November 11, 2019 08:41

SebastianBoe approved these changes Nov 11, 2019

View reviewed changes

ioannisg added the TSC Topics that need TSC discussion label Nov 11, 2019

MaureenHelm approved these changes Nov 12, 2019

View reviewed changes

galak removed the TSC Topics that need TSC discussion label Nov 13, 2019

galak merged commit ecb0993 into zephyrproject-rtos:master Nov 13, 2019

barsok deleted the bsokol-support-nrf52833-pr branch January 31, 2024 12:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for Nordic's nRF52833 SoC #20222

Add support for Nordic's nRF52833 SoC #20222

barsok commented Oct 29, 2019 •

edited

zephyrbot commented Oct 29, 2019 •

edited

dbkinder left a comment •

edited by barsok

dbkinder left a comment •

edited

carlescufi commented Nov 8, 2019

dbkinder left a comment

carlescufi commented Nov 8, 2019

ioannisg commented Nov 11, 2019

MaureenHelm Nov 12, 2019

mbolivar Nov 13, 2019

galak commented Nov 13, 2019

Add support for Nordic's nRF52833 SoC #20222

Add support for Nordic's nRF52833 SoC #20222

Conversation

barsok commented Oct 29, 2019 • edited

zephyrbot commented Oct 29, 2019 • edited

checkpatch (informational only, not a failure)

dbkinder left a comment • edited by barsok

Choose a reason for hiding this comment

dbkinder left a comment • edited

Choose a reason for hiding this comment

carlescufi commented Nov 8, 2019

dbkinder left a comment

Choose a reason for hiding this comment

carlescufi commented Nov 8, 2019

ioannisg commented Nov 11, 2019

MaureenHelm Nov 12, 2019

Choose a reason for hiding this comment

mbolivar Nov 13, 2019

Choose a reason for hiding this comment

galak commented Nov 13, 2019

barsok commented Oct 29, 2019 •

edited

zephyrbot commented Oct 29, 2019 •

edited

dbkinder left a comment •

edited by barsok

dbkinder left a comment •

edited