dts: edtlib: Improve error for wrong reg/ranges/interrupts size + add helper for testing error messages from edtlib #21615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulfalizer
force-pushed
the
size-hint
branch
2 times, most recently
from
0f13594
to
0ae9b5f
Compare
pabigot
reviewed
Jan 6, 2020
Show how the element size was calculated in the error message when a 'reg', 'ranges', or 'interrupts' property has the wrong size. This should help with debugging. Also mention that #*-cells properties come from the parent node, which can be subtle. Came up in zephyrproject-rtos#21607 (though it seems the comment disappeared). Signed-off-by: Ulf Magnusson <Ulf.Magnusson@nordicsemi.no>
Add a helper function verify_error() to testedtlib.py that takes a DTS source and verifies that it generates a particular EDTError. Use it to test the hints that the previous commit added to errors generated by _slice(). Signed-off-by: Ulf Magnusson <Ulf.Magnusson@nordicsemi.no>
Added a helper for testing error messages from |
ulfalizer
changed the title
carlescufi
approved these changes
Jan 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show how the element size was calculated in the error message when a
'reg', 'ranges', or 'interrupts' property has the wrong size. This
should help with debugging. Also mention that #*-cells properties come
from the parent node, which can be subtle.
Came up in #21607
(though it seems the comment disappeared).
Also add a helper for testing error messages from
edtlib(error messages fromdtlibare already tested), and use it to verify the new hints: