[topic-gpio] samples: reel_board: mesh_badge: Convert to the new GPIO API #22137

carlescufi · 2020-01-23T15:24:58Z

See commit messages.

carlescufi · 2020-01-23T15:26:49Z

Partially tested on the reel_board. @jhedberg could you please test it a bit more to make sure I haven't missed anything?

zephyrbot · 2020-01-23T15:27:36Z

All checks are passing now.

checkpatch (informational only, not a failure)

-:191: WARNING:LONG_LINE: line over 80 characters
#191: FILE: samples/boards/reel_board/mesh_badge/src/reel_board.c:70:
+	{ .name = DT_ALIAS_LED0_GPIOS_CONTROLLER, .pin = DT_ALIAS_LED0_GPIOS_PIN,

-:193: WARNING:LONG_LINE: line over 80 characters
#193: FILE: samples/boards/reel_board/mesh_badge/src/reel_board.c:72:
+	{ .name = DT_ALIAS_LED1_GPIOS_CONTROLLER, .pin = DT_ALIAS_LED1_GPIOS_PIN,

-:195: WARNING:LONG_LINE: line over 80 characters
#195: FILE: samples/boards/reel_board/mesh_badge/src/reel_board.c:74:
+	{ .name = DT_ALIAS_LED2_GPIOS_CONTROLLER, .pin = DT_ALIAS_LED2_GPIOS_PIN,

- total: 0 errors, 3 warnings, 233 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Your patch has style problems, please review.

NOTE: Ignored message types: AVOID_EXTERNS BRACES CONFIG_EXPERIMENTAL CONST_STRUCT DATE_TIME FILE_PATH_CHANGES MINMAX NETWORKING_BLOCK_COMMENT_STYLE PRINTK_WITHOUT_KERN_LEVEL SPLIT_STRING VOLATILE

NOTE: If any of the errors are false positives, please report
      them to the maintainers.

Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

Use the flags included in the new GPIO API to describe the properties of LEDs and buttons in the device tree source files. Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>

anangl · 2020-01-24T12:23:49Z

samples/boards/reel_board/mesh_badge/src/reel_board.c

-	gpio_init_callback(&button_cb, button_interrupt, BIT(DT_ALIAS_SW0_GPIOS_PIN));
-	gpio_add_callback(gpio, &button_cb);
+	gpio_pin_interrupt_configure(gpio, DT_ALIAS_SW0_GPIOS_PIN,
+				     GPIO_INT_EDGE_TO_ACTIVE);


It should be GPIO_INT_EDGE_BOTH, see the definition of EDGE, which is no longer needed BTW.

Very well spotted. Fixed.

jhedberg · 2020-01-24T13:45:41Z

@jfischer-phytec-iot you might be interested to take a look as well

pabigot

Only required change is handling an error return from gpio_pin_get(), which can be treated as "not pressed". Others are commentary.

pabigot · 2020-01-24T16:39:05Z

samples/boards/reel_board/mesh_badge/src/reel_board.c

@@ -67,10 +65,14 @@ static struct {
 	struct device *dev;
 	const char *name;
 	u32_t pin;


gpio_pin_t would save some space.

Indeed, changed.

pabigot · 2020-01-24T16:39:44Z

samples/boards/reel_board/mesh_badge/src/reel_board.c

-	{ .name = DT_ALIAS_LED0_GPIOS_CONTROLLER, .pin = DT_ALIAS_LED0_GPIOS_PIN, },
-	{ .name = DT_ALIAS_LED1_GPIOS_CONTROLLER, .pin = DT_ALIAS_LED1_GPIOS_PIN, },
-	{ .name = DT_ALIAS_LED2_GPIOS_CONTROLLER, .pin = DT_ALIAS_LED2_GPIOS_PIN, },
+	{ .name = DT_ALIAS_LED0_GPIOS_CONTROLLER, .pin = DT_ALIAS_LED0_GPIOS_PIN,


You could just do DT_ALIAS_LED0_GPIOS which expands to the controller name, pin, and flags in a single initializer expression. Though without a pre-defined standard structure synchronized to generation of that expression it's technically more future-proof to spelling out each element.

Oh, thanks for letting me know of this DT-generated macro. As you yourself mention, since this uses designated initializers I'd rather not change it at this point.

pabigot · 2020-01-24T16:40:43Z

samples/boards/reel_board/mesh_badge/src/reel_board.c

-	gpio_pin_read(gpio, DT_ALIAS_SW0_GPIOS_PIN, &val);
-
-	return !val;
+	return gpio_pin_get(gpio, DT_ALIAS_SW0_GPIOS_PIN);


Note gpio_pin_get can return a negative value to indicate a failure to read a value. There's also an essential type error here. gpio_pin_get(...) > 0 would be better.

Agreed, fixed.

Convert to the new GPIO API using logical levels, and remove the duplicate implementation of LED control that existed. Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>

carlescufi requested review from galak, MaureenHelm and nashif as code owners January 23, 2020 15:24

carlescufi requested review from jfischer-no, jhedberg, mnkp, pabigot and anangl January 23, 2020 15:25

zephyrbot added area: Boards area: Samples Samples labels Jan 23, 2020

carlescufi mentioned this pull request Jan 23, 2020

Convert GPIO users to new GPIO API #20017

Closed

carlescufi force-pushed the mesh_badge-gpio-sample branch from 22b8877 to f0148fc Compare January 23, 2020 15:31

boards: reel_board: Use the new GPIO flags in the DT source

71f5a88

Use the flags included in the new GPIO API to describe the properties of LEDs and buttons in the device tree source files. Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>

carlescufi force-pushed the mesh_badge-gpio-sample branch from f0148fc to 7fd50f8 Compare January 23, 2020 20:39

anangl approved these changes Jan 24, 2020

View reviewed changes

anangl requested changes Jan 24, 2020

View reviewed changes

carlescufi force-pushed the mesh_badge-gpio-sample branch from 7fd50f8 to 6c83ce2 Compare January 24, 2020 13:09

anangl approved these changes Jan 24, 2020

View reviewed changes

jhedberg approved these changes Jan 24, 2020

View reviewed changes

pabigot requested changes Jan 24, 2020

View reviewed changes

samples: reel_board: mesh_badge: Convert to the new GPIO API

77ad2e8

Convert to the new GPIO API using logical levels, and remove the duplicate implementation of LED control that existed. Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>

carlescufi force-pushed the mesh_badge-gpio-sample branch from 6c83ce2 to 77ad2e8 Compare January 24, 2020 16:49

pabigot approved these changes Jan 24, 2020

View reviewed changes

mnkp approved these changes Jan 24, 2020

View reviewed changes

carlescufi changed the title ~~samples: reel_board: mesh_badge: Convert to the new GPIO API~~ [topic-gpio] samples: reel_board: mesh_badge: Convert to the new GPIO API Jan 25, 2020

MaureenHelm approved these changes Jan 25, 2020

View reviewed changes

MaureenHelm merged this pull request into zephyrproject-rtos:topic-gpio Jan 25, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[topic-gpio] samples: reel_board: mesh_badge: Convert to the new GPIO API #22137

[topic-gpio] samples: reel_board: mesh_badge: Convert to the new GPIO API #22137

carlescufi commented Jan 23, 2020

carlescufi commented Jan 23, 2020

zephyrbot commented Jan 23, 2020 •

edited

anangl Jan 24, 2020 •

edited

carlescufi Jan 24, 2020

jhedberg commented Jan 24, 2020

pabigot left a comment

pabigot Jan 24, 2020

carlescufi Jan 24, 2020

pabigot Jan 24, 2020

carlescufi Jan 24, 2020

pabigot Jan 24, 2020

carlescufi Jan 24, 2020

[topic-gpio] samples: reel_board: mesh_badge: Convert to the new GPIO API #22137

[topic-gpio] samples: reel_board: mesh_badge: Convert to the new GPIO API #22137

Conversation

carlescufi commented Jan 23, 2020

carlescufi commented Jan 23, 2020

zephyrbot commented Jan 23, 2020 • edited

checkpatch (informational only, not a failure)

anangl Jan 24, 2020 • edited

Choose a reason for hiding this comment

carlescufi Jan 24, 2020

Choose a reason for hiding this comment

jhedberg commented Jan 24, 2020

pabigot left a comment

Choose a reason for hiding this comment

pabigot Jan 24, 2020

Choose a reason for hiding this comment

carlescufi Jan 24, 2020

Choose a reason for hiding this comment

pabigot Jan 24, 2020

Choose a reason for hiding this comment

carlescufi Jan 24, 2020

Choose a reason for hiding this comment

pabigot Jan 24, 2020

Choose a reason for hiding this comment

carlescufi Jan 24, 2020

Choose a reason for hiding this comment

zephyrbot commented Jan 23, 2020 •

edited

anangl Jan 24, 2020 •

edited