Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SAM4S Enable USART feature #22634

Merged
merged 3 commits into from
Mar 10, 2020
Merged

SAM4S Enable USART feature #22634

merged 3 commits into from
Mar 10, 2020

Conversation

nandojve
Copy link
Member

@nandojve nandojve commented Feb 8, 2020

Add missing dts_fixups and soc_pinmap symbols to properly use USART serial driver. A cosmetic alignments on dts_fixups was necessary. Last thing, added USART entry at 'Supported Features' table on documentation.

@nandojve nandojve requested a review from galak February 8, 2020 16:41
@zephyrbot
Copy link
Collaborator

zephyrbot commented Feb 8, 2020 •
edited

All checks passed.

checkpatch (informational only, not a failure)

-:23: WARNING:LONG_LINE: line over 80 characters
#23: FILE: soc/arm/atmel_sam/sam4s/dts_fixup.h:15:
+#define DT_NUM_IRQ_PRIO_BITS                 DT_ARM_V7M_NVIC_E000E100_ARM_NUM_IRQ_PRIORITY_BITS

-:41: WARNING:LONG_LINE: line over 80 characters
#41: FILE: soc/arm/atmel_sam/sam4s/dts_fixup.h:18:
+#define DT_GPIO_SAM_PORTA_BASE_ADDRESS       DT_ATMEL_SAM_GPIO_400E0E00_BASE_ADDRESS

-:43: WARNING:LONG_LINE: line over 80 characters
#43: FILE: soc/arm/atmel_sam/sam4s/dts_fixup.h:20:
+#define DT_GPIO_SAM_PORTA_IRQ_PRIO           DT_ATMEL_SAM_GPIO_400E0E00_IRQ_0_PRIORITY

-:44: WARNING:LONG_LINE: line over 80 characters
#44: FILE: soc/arm/atmel_sam/sam4s/dts_fixup.h:21:
+#define DT_GPIO_SAM_PORTA_PERIPHERAL_ID      DT_ATMEL_SAM_GPIO_400E0E00_PERIPHERAL_ID

-:46: WARNING:LONG_LINE: line over 80 characters
#46: FILE: soc/arm/atmel_sam/sam4s/dts_fixup.h:23:
+#define DT_GPIO_SAM_PORTB_BASE_ADDRESS       DT_ATMEL_SAM_GPIO_400E1000_BASE_ADDRESS

-:48: WARNING:LONG_LINE: line over 80 characters
#48: FILE: soc/arm/atmel_sam/sam4s/dts_fixup.h:25:
+#define DT_GPIO_SAM_PORTB_IRQ_PRIO           DT_ATMEL_SAM_GPIO_400E1000_IRQ_0_PRIORITY

-:49: WARNING:LONG_LINE: line over 80 characters
#49: FILE: soc/arm/atmel_sam/sam4s/dts_fixup.h:26:
+#define DT_GPIO_SAM_PORTB_PERIPHERAL_ID      DT_ATMEL_SAM_GPIO_400E1000_PERIPHERAL_ID

-:51: WARNING:LONG_LINE: line over 80 characters
#51: FILE: soc/arm/atmel_sam/sam4s/dts_fixup.h:28:
+#define DT_GPIO_SAM_PORTC_BASE_ADDRESS       DT_ATMEL_SAM_GPIO_400E1200_BASE_ADDRESS

-:53: WARNING:LONG_LINE: line over 80 characters
#53: FILE: soc/arm/atmel_sam/sam4s/dts_fixup.h:30:
+#define DT_GPIO_SAM_PORTC_IRQ_PRIO           DT_ATMEL_SAM_GPIO_400E1200_IRQ_0_PRIORITY

-:54: WARNING:LONG_LINE: line over 80 characters
#54: FILE: soc/arm/atmel_sam/sam4s/dts_fixup.h:31:
+#define DT_GPIO_SAM_PORTC_PERIPHERAL_ID      DT_ATMEL_SAM_GPIO_400E1200_PERIPHERAL_ID

-:68: WARNING:LONG_LINE: line over 80 characters
#68: FILE: soc/arm/atmel_sam/sam4s/dts_fixup.h:33:
+#define DT_I2C_0_BASE_ADDRESS                DT_ATMEL_SAM_I2C_TWI_40018000_BASE_ADDRESS

-:70: WARNING:LONG_LINE: line over 80 characters
#70: FILE: soc/arm/atmel_sam/sam4s/dts_fixup.h:35:
+#define DT_I2C_0_BITRATE                     DT_ATMEL_SAM_I2C_TWI_40018000_CLOCK_FREQUENCY

-:72: WARNING:LONG_LINE: line over 80 characters
#72: FILE: soc/arm/atmel_sam/sam4s/dts_fixup.h:37:
+#define DT_I2C_0_IRQ_PRI                     DT_ATMEL_SAM_I2C_TWI_40018000_IRQ_0_PRIORITY

-:73: WARNING:LONG_LINE: line over 80 characters
#73: FILE: soc/arm/atmel_sam/sam4s/dts_fixup.h:38:
+#define DT_I2C_0_PERIPHERAL_ID               DT_ATMEL_SAM_I2C_TWI_40018000_PERIPHERAL_ID

-:74: WARNING:LONG_LINE: line over 80 characters
#74: FILE: soc/arm/atmel_sam/sam4s/dts_fixup.h:39:
+#define DT_I2C_1_BASE_ADDRESS                DT_ATMEL_SAM_I2C_TWI_4001C000_BASE_ADDRESS

-:76: WARNING:LONG_LINE: line over 80 characters
#76: FILE: soc/arm/atmel_sam/sam4s/dts_fixup.h:41:
+#define DT_I2C_1_BITRATE                     DT_ATMEL_SAM_I2C_TWI_4001C000_CLOCK_FREQUENCY

-:78: WARNING:LONG_LINE: line over 80 characters
#78: FILE: soc/arm/atmel_sam/sam4s/dts_fixup.h:43:
+#define DT_I2C_1_IRQ_PRI                     DT_ATMEL_SAM_I2C_TWI_4001C000_IRQ_0_PRIORITY

-:79: WARNING:LONG_LINE: line over 80 characters
#79: FILE: soc/arm/atmel_sam/sam4s/dts_fixup.h:44:
+#define DT_I2C_1_PERIPHERAL_ID               DT_ATMEL_SAM_I2C_TWI_4001C000_PERIPHERAL_ID

-:86: WARNING:LONG_LINE: line over 80 characters
#86: FILE: soc/arm/atmel_sam/sam4s/dts_fixup.h:46:
+#define DT_SPI_0_BASE_ADDRESS                DT_ATMEL_SAM_SPI_40008000_BASE_ADDRESS

-:89: WARNING:LONG_LINE: line over 80 characters
#89: FILE: soc/arm/atmel_sam/sam4s/dts_fixup.h:49:
+#define DT_SPI_0_IRQ_PRI                     DT_ATMEL_SAM_SPI_40008000_IRQ_0_PRIORITY

-:90: WARNING:LONG_LINE: line over 80 characters
#90: FILE: soc/arm/atmel_sam/sam4s/dts_fixup.h:50:
+#define DT_SPI_0_PERIPHERAL_ID               DT_ATMEL_SAM_SPI_40008000_PERIPHERAL_ID

-:105: WARNING:LONG_LINE: line over 80 characters
#105: FILE: soc/arm/atmel_sam/sam4s/dts_fixup.h:53:
+#define DT_UART_SAM_PORT_0_BAUD_RATE         DT_ATMEL_SAM_UART_400E0600_CURRENT_SPEED

-:107: WARNING:LONG_LINE: line over 80 characters
#107: FILE: soc/arm/atmel_sam/sam4s/dts_fixup.h:55:
+#define DT_UART_SAM_PORT_0_IRQ_PRIO          DT_ATMEL_SAM_UART_400E0600_IRQ_0_PRIORITY

-:109: WARNING:LONG_LINE: line over 80 characters
#109: FILE: soc/arm/atmel_sam/sam4s/dts_fixup.h:57:
+#define DT_UART_SAM_PORT_1_BAUD_RATE         DT_ATMEL_SAM_UART_400E0800_CURRENT_SPEED

-:111: WARNING:LONG_LINE: line over 80 characters
#111: FILE: soc/arm/atmel_sam/sam4s/dts_fixup.h:59:
+#define DT_UART_SAM_PORT_1_IRQ_PRIO          DT_ATMEL_SAM_UART_400E0800_IRQ_0_PRIORITY

-:118: WARNING:LONG_LINE: line over 80 characters
#118: FILE: soc/arm/atmel_sam/sam4s/dts_fixup.h:62:
+#define DT_USART_SAM_PORT_0_BAUD_RATE        DT_ATMEL_SAM_USART_40024000_CURRENT_SPEED

-:120: WARNING:LONG_LINE: line over 80 characters
#120: FILE: soc/arm/atmel_sam/sam4s/dts_fixup.h:64:
+#define DT_USART_SAM_PORT_0_IRQ_PRIO         DT_ATMEL_SAM_USART_40024000_IRQ_0_PRIORITY

-:121: WARNING:LONG_LINE: line over 80 characters
#121: FILE: soc/arm/atmel_sam/sam4s/dts_fixup.h:65:
+#define DT_USART_SAM_PORT_0_PERIPHERAL_ID    DT_ATMEL_SAM_USART_40024000_PERIPHERAL_ID

-:123: WARNING:LONG_LINE: line over 80 characters
#123: FILE: soc/arm/atmel_sam/sam4s/dts_fixup.h:67:
+#define DT_USART_SAM_PORT_1_BAUD_RATE        DT_ATMEL_SAM_USART_40028000_CURRENT_SPEED

-:125: WARNING:LONG_LINE: line over 80 characters
#125: FILE: soc/arm/atmel_sam/sam4s/dts_fixup.h:69:
+#define DT_USART_SAM_PORT_1_IRQ_PRIO         DT_ATMEL_SAM_USART_40028000_IRQ_0_PRIORITY

-:126: WARNING:LONG_LINE: line over 80 characters
#126: FILE: soc/arm/atmel_sam/sam4s/dts_fixup.h:70:
+#define DT_USART_SAM_PORT_1_PERIPHERAL_ID    DT_ATMEL_SAM_USART_40028000_PERIPHERAL_ID

-:130: WARNING:LONG_LINE: line over 80 characters
#130: FILE: soc/arm/atmel_sam/sam4s/dts_fixup.h:72:
+#define DT_WDT_SAM_IRQ                       DT_ATMEL_SAM_WATCHDOG_400E1450_IRQ_0

-:131: WARNING:LONG_LINE: line over 80 characters
#131: FILE: soc/arm/atmel_sam/sam4s/dts_fixup.h:73:
+#define DT_WDT_SAM_IRQ_PRIORITY              DT_ATMEL_SAM_WATCHDOG_400E1450_IRQ_0_PRIORITY

-:132: WARNING:LONG_LINE: line over 80 characters
#132: FILE: soc/arm/atmel_sam/sam4s/dts_fixup.h:74:
+#define DT_WDT_SAM_LABEL                     DT_ATMEL_SAM_WATCHDOG_400E1450_LABEL

-:133: WARNING:LONG_LINE: line over 80 characters
#133: FILE: soc/arm/atmel_sam/sam4s/dts_fixup.h:75:
+#define DT_WDT_SAM_BASE_ADDRESS              DT_ATMEL_SAM_WATCHDOG_400E1450_BASE_ADDRESS

-:135: WARNING:LONG_LINE: line over 80 characters
#135: FILE: soc/arm/atmel_sam/sam4s/dts_fixup.h:77:
+#define DT_FLASH_DEV_BASE_ADDRESS            DT_ATMEL_SAM_FLASH_CONTROLLER_400E0A00_BASE_ADDRESS

-:136: WARNING:LONG_LINE: line over 80 characters
#136: FILE: soc/arm/atmel_sam/sam4s/dts_fixup.h:78:
+#define DT_FLASH_DEV_NAME                    DT_ATMEL_SAM_FLASH_CONTROLLER_400E0A00_LABEL

- total: 0 errors, 37 warnings, 153 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Your patch has style problems, please review.

NOTE: Ignored message types: AVOID_EXTERNS BRACES CONFIG_EXPERIMENTAL CONST_STRUCT DATE_TIME FILE_PATH_CHANGES MINMAX NETWORKING_BLOCK_COMMENT_STYLE PRINTK_WITHOUT_KERN_LEVEL SPLIT_STRING VOLATILE

NOTE: If any of the errors are false positives, please report
      them to the maintainers.

Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

@stephanosio stephanosio added area: UART Universal Asynchronous Receiver-Transmitter platform: Microchip SAM Microchip SAM Platform (formerly Atmel SAM) labels Feb 22, 2020
@nandojve
soc: arm: atmel: sam4s: Fix code align
50ff30c 
Fix dts_fixup.h code align.

Signed-off-by: Gerson Fernando Budke <nandojve@gmail.com>
@nandojve
soc: arm: atmel: sam4s: Add missing symbols for usart
a10de3b 
This add dts_fixup and soc_pinmap to enable usart serial driver.

Signed-off-by: Gerson Fernando Budke <nandojve@gmail.com>
@nandojve
boards: arm: sam4s_xplained: Add usart entry on table
0500b93 
Add usart entry on 'Supported Features' table.

Signed-off-by: Gerson Fernando Budke <nandojve@gmail.com>
@nandojve nandojve mentioned this pull request Mar 5, 2020
Closed
61 tasks
@nandojve nandojve closed this Mar 9, 2020
@nandojve nandojve reopened this Mar 9, 2020
@jhedberg jhedberg merged commit 34ac208 into zephyrproject-rtos:master Mar 10, 2020
@nandojve nandojve deleted the sam4s_fixes branch March 10, 2020 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galak galak galak approved these changes

@fallrisk fallrisk Awaiting requested review from fallrisk

@nashif nashif Awaiting requested review from nashif

Assignees
No one assigned
Labels
area: Boards area: UART Universal Asynchronous Receiver-Transmitter platform: Microchip SAM Microchip SAM Platform (formerly Atmel SAM)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nandojve @zephyrbot @galak @jhedberg @stephanosio