Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arch arm userspace fix syscal eval #23323

Merged
merged 2 commits into from Mar 7, 2020
Merged

Arch arm userspace fix syscal eval #23323

merged 2 commits into from Mar 7, 2020

Conversation

ioannisg
Copy link
Member

@ioannisg ioannisg commented Mar 6, 2020 •
edited

@zephyrbot zephyrbot added area: ARM ARM (32-bit) Architecture area: Tests Issues related to a particular existing or missing test area: Kernel labels Mar 6, 2020
@ioannisg ioannisg requested a review from d3zd3z March 6, 2020 16:29
@ioannisg ioannisg self-assigned this Mar 6, 2020
@ioannisg ioannisg requested a review from jhedberg March 6, 2020 16:53
@ioannisg ioannisg added the bug The issue is a bug, or the PR is fixing a bug label Mar 6, 2020
@ioannisg ioannisg marked this pull request as ready for review March 6, 2020 20:14
@jhedberg jhedberg added this to the v2.2.0 milestone Mar 6, 2020
@ioannisg
arch: arm: aarch32: userspace: fix syscall ID validation
c64bd9f 
We need an unsigned comparison when evaluating whether
the supplied syscall ID is lower than the syscall ID limit.

Signed-off-by: Ioannis Glaropoulos <Ioannis.Glaropoulos@nordicsemi.no>
@ioannisg
tests: kernel: userspace: extend bad syscall-ID test-case
e0487fc 
Extend the bad syscall-ID test case to cover
erroneously supplied larged unsiged syscall-ID
values.

Signed-off-by: Ioannis Glaropoulos <Ioannis.Glaropoulos@nordicsemi.no>
@ioannisg ioannisg force-pushed the arch_arm_userspace_fix_syscal_eval branch from 186d2e3 to e0487fc Compare March 6, 2020 21:19
@jhedberg jhedberg merged commit 61fc061 into zephyrproject-rtos:master Mar 7, 2020
@ioannisg ioannisg mentioned this pull request Mar 7, 2020
Closed
18 tasks
@ioannisg ioannisg mentioned this pull request Mar 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d3zd3z d3zd3z d3zd3z approved these changes

@ceolin ceolin ceolin approved these changes

@jhedberg jhedberg jhedberg approved these changes

@andrewboie andrewboie andrewboie approved these changes

@andyross andyross Awaiting requested review from andyross

@galak galak Awaiting requested review from galak

@MaureenHelm MaureenHelm Awaiting requested review from MaureenHelm

@nashif nashif Awaiting requested review from nashif

Assignees

@ioannisg ioannisg

Labels
area: ARM ARM (32-bit) Architecture area: Kernel area: Tests Issues related to a particular existing or missing test bug The issue is a bug, or the PR is fixing a bug
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ioannisg @d3zd3z @ceolin @jhedberg @andrewboie @zephyrbot