soc: arm: atmel_sam: Clock clean-up #24487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nandojve
requested review from
fallrisk,
galak,
ioannisg and
MaureenHelm
as code owners
61 tasks
stephanosio
reviewed
Apr 19, 2020
stephanosio
added
area: Clock Control
platform: Microchip SAM
galak
reviewed
Apr 19, 2020
nandojve
force-pushed
the
sam_clock_cleanup
branch
from
a078c20
to
2e65925
Compare
stephanosio
reviewed
Apr 21, 2020
There was a problem hiding this comment.
In general, I am not sure about moving SOC_ATMEL_SAM_HCLK_FREQ_HZ and SOC_ATMEL_SAM_MCK_FREQ_HZ to atmel_sam_dt.h since these are not entirely derived from the device tree.
For the time being, I believe it is more advantageous to keep them in the each soc.h, as that is more straight forward and we do not need extra ifdefs that way.
These macros should be moved to atmel_sam_dt.h when we do proper device tree-based clock system specification, as I previously commented.
nandojve
force-pushed
the
sam_clock_cleanup
branch
from
2e65925
to
09c2457
Compare
stephanosio
reviewed
Apr 21, 2020
nandojve
force-pushed
the
sam_clock_cleanup
branch
from
b57770c
to
beb8919
Compare
stephanosio
approved these changes
Apr 21, 2020
nandojve
force-pushed
the
sam_clock_cleanup
branch
from
beb8919
to
2c00629
Compare
|
rebase |
stephanosio
reviewed
Apr 22, 2020
nandojve
force-pushed
the
sam_clock_cleanup
branch
from
2c00629
to
21c84d1
Compare
ioannisg
approved these changes
Apr 22, 2020
|
@galak pls, see if your fb is addressed |
Small clock clean-up. This moves all devicetree entries on SoC to atmel_sam_dt.h. Signed-off-by: Gerson Fernando Budke <nandojve@gmail.com>
nandojve
force-pushed
the
sam_clock_cleanup
branch
from
21c84d1
to
f7e6f09
Compare
|
rebase and switch from DT_NODELABEL to DT_PATH following same approach on #24602. |
galak
approved these changes
Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small clock clean-up. This moves all devicetree entries on SoC to atmel_sam_dt.h.
Signed-off-by: Gerson Fernando Budke nandojve@gmail.com