dts: ethernet: rework how we deal with mac-address setting #24651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galak
requested review from
jukkar,
MaureenHelm,
nandojve,
pfalcon and
tbursztyka
as code owners
zephyrbot
added
area: Boards
area: native port
|
All checks passed. checkpatch (informational only, not a failure)Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages. |
jukkar
approved these changes
Apr 24, 2020
| mac_addr[3] = entropy >> 8; | ||
| mac_addr[4] = entropy >> 16; | ||
| /* Locally administered, unicast */ | ||
| mac_addr[5] = ((entropy >> 0) & 0xfc) | 0x02; |
There was a problem hiding this comment.
The liteeth driver seems to have set the LAA bit to wrong byte earlier.
MaureenHelm
reviewed
Apr 24, 2020
drivers/ethernet/eth_mcux.c
Outdated
| #if defined(CONFIG_ETH_MCUX_0_UNIQUE_MAC) || \ | ||
| defined(CONFIG_ETH_MCUX_1_UNIQUE_MAC) | ||
| #if !DT_INST_NODE_HAS_PROP(0, local_mac_address) || \ | ||
| DT_HAS_NODE(DT_DRV_INST(1)) && !DT_INST_NODE_HAS_PROP(1, local_mac_address) |
There was a problem hiding this comment.
Why does generating eth0 depend on instance 1?
There was a problem hiding this comment.
Because generate_eth1_unique_mac calls generate_eth0_unique_mac. And we technically could have a case in which local-mac-address is set on inst0 and not on inst1.
pabigot
requested changes
Apr 25, 2020
MaureenHelm
previously requested changes
May 1, 2020
61 tasks
Rather than having each driver have its own slightly different way of generating a random mac address, add a helper function that they all can call so we do it one way. Signed-off-by: Kumar Gala <kumar.gala@linaro.org>
pabigot
approved these changes
May 8, 2020
Add definition of zephyr,random-mac-address property that conveys to a driver to utilize a random MAC address if the driver supports this feature. Signed-off-by: Kumar Gala <kumar.gala@linaro.org>
Utilize the devicetree property "zephyr,random-mac-address" to determine if a driver should use a random mac address and remove the associated Kconfig options that enabled this feature. Signed-off-by: Kumar Gala <kumar.gala@linaro.org>
Move from a Kconfig to select/initialize the MAC address to using the "local-mac-address" property in devicetree. If the property is set the drivers will initialize the mac-address from the devicetree (unless the mac address is all 0's). The MAC address might get overwritten by either a driver specific means or by the setting of "zephyr,random-mac-address" in the devicetree. Signed-off-by: Kumar Gala <kumar.gala@linaro.org>
Instead of having a Kconfig property, if there is no local-mac-address property in the devicetree than we'll generate a unique MAC address based on unique ID registers on the SoC. We remove the local-mac-address properties in the SoC dtsi files to match the default behavior that existed before (ie, unique MAC address) Signed-off-by: Kumar Gala <kumar.gala@linaro.org>
carlescufi
approved these changes
May 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework the ethernet drivers to determine how they set the mac-address. In the majority of cases with just utilize devicetree and a combination of 'local-mac-address' property and 'zephyr,random-mac-address' property.