boards: MikroE Clicker 2: Added board #27345

pbeTrifork · 2020-08-03T11:50:43Z

Added MikroE Clicker 2 board.

Discussed with @henrikbrixandersen the best way to cope with the two mikrobus ports on the board, didn't get anything conclusive so added as aliases for now

Signed-off-by: Paul M. Bendixen pbe@trifork.com

henrikbrixandersen

Looks good, a few minor corrections below.

boards/arm/mikroe_clicker_2/CMakeLists.txt

boards/arm/mikroe_clicker_2/Kconfig.board

boards/arm/mikroe_clicker_2/Kconfig.defconfig

boards/arm/mikroe_clicker_2/board.cmake

boards/arm/mikroe_clicker_2/doc/mikroe_clicker_2.rst

boards/arm/mikroe_clicker_2/mikroe_clicker_2.dts

boards/arm/mikroe_clicker_2/pinmux.c

pbeTrifork · 2020-08-04T08:42:59Z

boards/arm/mikroe_clicker_2/mikroe_clicker_2.dts

+};
+
+&adc1 {
+	status ="okay";


Would it be possible to have labels for the channels here ? I couldn't find (or understand) the documentation of it.
e.g.:

mikrobus_1_adc: adc1_ch2 { label = "mikroBUS 1 ADC"; channel = <2>; }; mikrobus_2_adc: adc1_ch3 { label = "mikroBUS 2 ADC"; channel = <3>; };

That's not currently possible. We would need something along the line of the gpio-nexus for ADCs in order to support this...

boards/arm/mikroe_clicker_2/Kconfig.board

boards/arm/mikroe_clicker_2/Kconfig.defconfig

henrikbrixandersen · 2020-08-04T13:47:00Z

boards/arm/mikroe_clicker_2/mikroe_clicker_2.dts

+};
+
+&adc1 {
+	status ="okay";


That's not currently possible. We would need something along the line of the gpio-nexus for ADCs in order to support this...

pbeTrifork · 2020-08-05T09:47:05Z

Ok so it seems the problem in the tests is that I use defconfig to get a uart console on the usb interface, but when running the non-multithreaded kernel test POSIX is not defined and then the USB stack cannot be defined.
Should I move UART_CONFIG_ON_DEV_NAME to Kconfig.defconfig and make it depend on USB or something?
Any ideas on fixing this would be appreciated.

boards/arm/mikroe_clicker_2/mikroe_clicker_2.yaml

boards/arm/mikroe_clicker_2/mikroe_clicker_2_defconfig

erwango · 2020-10-13T12:56:44Z

@pbeSmartDevice Sorry, it seems I missed your PR.
If you're still interesting in getting it merged (which would be nice), can you rebase on top of master and move UART configuration to device tree ?

pbeTrifork · 2020-10-13T14:30:05Z

@pbeSmartDevice Sorry, it seems I missed your PR.
If you're still interesting in getting it merged (which would be nice), can you rebase on top of master and move UART configuration to device tree ?

That's fine
I've rebased, but what exactly do you mean by moving the UART configuration to device tree, apart from the pinmux it is already defined in the .dts?

erwango · 2020-10-13T15:03:59Z

I've rebased, but what exactly do you mean by moving the UART configuration to device tree, apart from the pinmux it is already defined in the .dts?

I meant the pinmux actually. I2C and ADC are on their way too. Cf #28999 for more info.
Actually, it might be worthy waiting one or 2 more weeks so the transition is completed.

pbeTrifork · 2020-10-13T15:50:40Z

I tried to update it, but I can't seem to find the right include and I can't figure out how to include something that is not a file in my .dts

erwango · 2020-10-14T10:23:07Z

I tried to update it, but I can't seem to find the right include and I can't figure out how to include something that is not a file in my .dts

Do you mean this #include <st/f4/stm32f407v(e-g)tx-pinctrl.dtsi> ?
If not working, please try to run west update and check that the latest hal_stm32 module version is correctly pulled.

pbeTrifork · 2020-10-14T10:50:49Z

I tried to update it, but I can't seem to find the right include and I can't figure out how to include something that is not a file in my .dts

Do you mean this #include <st/f4/stm32f407v(e-g)tx-pinctrl.dtsi> ?
If not working, please try to run west update and check that the latest hal_stm32 module version is correctly pulled.

Yes that was exactly it, everything seems to be working now.

pbeTrifork · 2020-10-19T14:22:40Z

@erwango So is this sufficient?

erwango · 2020-10-19T14:50:58Z

@pbeSmartDevice It seems fine aside from the pinmux part that should be moved to device tree.
I'd advise to wait a few days that SPI and USB are available

erwango

Please squash 2 first commit.
And it would be good to confirm this is working, otherwise there is not point ...

pbeTrifork · 2020-10-20T11:30:34Z

I've Added ADC and SPI as well, should I hold out for USB (I can see it doesn't have a PR yet, at least according to #28999) or should I just squash the three board related ones and have it upstreamed?

Also could I get feedback about the ADC if this is the correct way to go?

erwango · 2020-10-21T11:38:20Z

Also could I get feedback about the ADC if this is the correct way to go?

Looks good indeed.

I've Added ADC and SPI as well, should I hold out for USB (I can see it doesn't have a PR yet, at least according to #28999) or should I just squash the three board related ones and have it upstreamed?

USB is on its way, but it might take longer to merge. So let's do the squash and we'll try to merge.

pbeTrifork · 2020-10-23T14:55:33Z

So @erwango I could guess that you would want me to update to get me to use the dts for the USB as well, however I haven't been able to get serial port over USB to work with the new patch and I have no idea why.
The device doesn't come up in dmesg when I attach it and the hello-world example therefore can't really work.
blinky works fine, so it's not the setup.

erwango · 2020-10-23T15:20:50Z

@pbeTrifork

You mean that this is working fine if you configure uart4 pins using pinmux.c ?

You would be able to compare GPIO (A in your case) register settings after pins have been configured (let's say end of uart_stm32_init) ?
And if that's equivalent (which I expect to be, since I've verified that several times on various targets), would you be able to look at generated signals in both cases?
I'm thinking this can be a timing issue or a glitch generated on the line. Which would be strange as uart is generally quite error resilient. But I'm not familiar with the probe you're using.

Last point, is there a working branch you can share?

pbeTrifork · 2020-10-29T16:12:06Z

No, what I mean is that no matter what setting I try out I can't get the hello world sample to work.
When setting the config to

CONFIG_UART_INTERRUPT_DRIVEN=y
CONFIG_UART_CONSOLE_ON_DEV_NAME="CDC_ACM_0"
CONFIG_CONSOLE=y
CONFIG_USB_UART_CONSOLE=y
CONFIG_SERIAL=y
CONFIG_USB=y
CONFIG_USB_DEVICE_STACK=y
CONFIG_USB_DEVICE_OS_DESC=y

Then the /dev/ttyACM0 doesn't show up, when I omit fdb6c46 ( changing pinmux settings to dts settings ) it still doesn't show up and dmesg also doesn't show any new connected devices.

erwango · 2020-11-04T10:11:33Z

@pbeTrifork, do you know if there's any life? Is blinky working ?

pbeTrifork · 2020-11-04T16:07:29Z

Yes, blinky is working, my main project for this is also working, I can read the sensor outputs from my program using gdb, but it still doesn't show up on dmesg or as a serial port, so the output doesn't come out.

pbeTrifork · 2020-11-25T16:56:38Z

Merged with master and tried the cdc usb sample, which worked fine.
Seems like I have a problem in my application configuration

erwango

Two minor changes and we're good to go, if you're ready.

erwango · 2020-11-26T08:01:15Z

boards/arm/mikroe_clicker_2/pinmux.c

+ * Copyright (c) 2020 Trifork
+ *
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+#include <kernel.h>
+#include <device.h>
+#include <init.h>
+#include <drivers/pinmux.h>
+#include <sys/sys_io.h>
+
+#include <pinmux/stm32/pinmux_stm32.h>
+
+/* Pin assignments for MikroE Clicker 2 board for STM32 */
+static const struct pin_config pinconf[] = {
+};
+
+static int pinmux_mikroe_clicker_2_init(const struct device *port)
+{


This file could be removed now

Ok, I thought I read that the idea was to keep it in, but ok.

erwango · 2020-11-26T08:01:30Z

boards/arm/mikroe_clicker_2/CMakeLists.txt

+# SPDX-License-Identifier: Apache-2.0
+
+if(CONFIG_PINMUX)
+zephyr_library()
+zephyr_library_sources(pinmux.c)
+endif()


Please remove this file

Added support for the Clicker 2 for STM32 board from MikroElektronika Signed-off-by: Paul M. Bendixen <pbe@trifork.com>

Modified the drivers.adc test to include the MikroE Clicker 2 board Signed-off-by: Paul M. Bendixen <pbe@trifork.com>

carlescufi

LGTM

pbeTrifork requested review from galak, MaureenHelm and nashif as code owners August 3, 2020 11:50

github-actions bot added area: Boards area: Devicetree area: Documentation labels Aug 3, 2020

pbeTrifork force-pushed the Mikroe_clicker_2 branch 3 times, most recently from 2799edd to d6bde65 Compare August 3, 2020 13:39

henrikbrixandersen requested changes Aug 3, 2020

View reviewed changes

henrikbrixandersen requested a review from erwango August 3, 2020 21:05

pbeTrifork force-pushed the Mikroe_clicker_2 branch from 1ebae7e to 2ae1db9 Compare August 4, 2020 08:04

pbeTrifork commented Aug 4, 2020

View reviewed changes

pbeTrifork requested a review from henrikbrixandersen August 4, 2020 11:25

henrikbrixandersen requested changes Aug 4, 2020

View reviewed changes

pbeTrifork force-pushed the Mikroe_clicker_2 branch from 2ae1db9 to f10a3d5 Compare August 5, 2020 07:28

henrikbrixandersen approved these changes Aug 5, 2020

View reviewed changes

github-actions bot added the area: Tests Issues related to a particular existing or missing test label Aug 5, 2020

erwango requested changes Aug 12, 2020

View reviewed changes

boards/arm/mikroe_clicker_2/mikroe_clicker_2.yaml Outdated Show resolved Hide resolved

boards/arm/mikroe_clicker_2/mikroe_clicker_2_defconfig Outdated Show resolved Hide resolved

pbeTrifork force-pushed the Mikroe_clicker_2 branch from f10a3d5 to 5d4a002 Compare August 14, 2020 11:21

pbeTrifork requested a review from erwango August 17, 2020 14:20

pbeTrifork force-pushed the Mikroe_clicker_2 branch from 5d4a002 to e2f8e18 Compare October 13, 2020 14:27

pbeTrifork force-pushed the Mikroe_clicker_2 branch from e2f8e18 to c3d67bc Compare October 13, 2020 15:49

pbeTrifork force-pushed the Mikroe_clicker_2 branch 2 times, most recently from 001ca45 to 904421b Compare October 14, 2020 10:01

pbeTrifork force-pushed the Mikroe_clicker_2 branch from 904421b to 4c8dca3 Compare October 19, 2020 14:10

erwango requested changes Oct 19, 2020

View reviewed changes

pbeTrifork force-pushed the Mikroe_clicker_2 branch from 4c8dca3 to fac97f2 Compare October 20, 2020 11:16

erwango added the platform: STM32 ST Micro STM32 label Oct 21, 2020

pbeTrifork force-pushed the Mikroe_clicker_2 branch 4 times, most recently from f78ba7c to 339e020 Compare October 23, 2020 14:47

pbeTrifork force-pushed the Mikroe_clicker_2 branch from 339e020 to 47e05b9 Compare November 25, 2020 16:55

erwango requested changes Nov 26, 2020

View reviewed changes

pbeTrifork added 2 commits November 26, 2020 09:36

boards: MikroE Clicker 2: Added board

8060153

Added support for the Clicker 2 for STM32 board from MikroElektronika Signed-off-by: Paul M. Bendixen <pbe@trifork.com>

tests: Modified ADC test for clicker 2

025bca0

Modified the drivers.adc test to include the MikroE Clicker 2 board Signed-off-by: Paul M. Bendixen <pbe@trifork.com>

pbeTrifork force-pushed the Mikroe_clicker_2 branch from 47e05b9 to 025bca0 Compare November 26, 2020 08:38

erwango approved these changes Nov 26, 2020

View reviewed changes

carlescufi approved these changes Nov 30, 2020

View reviewed changes

carlescufi merged commit e5d36db into zephyrproject-rtos:master Nov 30, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

boards: MikroE Clicker 2: Added board #27345

boards: MikroE Clicker 2: Added board #27345

pbeTrifork commented Aug 3, 2020

henrikbrixandersen left a comment

pbeTrifork Aug 4, 2020 •

edited

henrikbrixandersen Aug 4, 2020

henrikbrixandersen Aug 4, 2020

pbeTrifork commented Aug 5, 2020

erwango commented Oct 13, 2020

pbeTrifork commented Oct 13, 2020

erwango commented Oct 13, 2020

pbeTrifork commented Oct 13, 2020

erwango commented Oct 14, 2020

pbeTrifork commented Oct 14, 2020

pbeTrifork commented Oct 19, 2020

erwango commented Oct 19, 2020

erwango left a comment

pbeTrifork commented Oct 20, 2020

erwango commented Oct 21, 2020

pbeTrifork commented Oct 23, 2020

erwango commented Oct 23, 2020

pbeTrifork commented Oct 29, 2020

erwango commented Nov 4, 2020

pbeTrifork commented Nov 4, 2020

pbeTrifork commented Nov 25, 2020

erwango left a comment

erwango Nov 26, 2020

pbeTrifork Nov 26, 2020

erwango Nov 26, 2020

carlescufi left a comment

boards: MikroE Clicker 2: Added board #27345

boards: MikroE Clicker 2: Added board #27345

Conversation

pbeTrifork commented Aug 3, 2020

henrikbrixandersen left a comment

Choose a reason for hiding this comment

pbeTrifork Aug 4, 2020 • edited

Choose a reason for hiding this comment

henrikbrixandersen Aug 4, 2020

Choose a reason for hiding this comment

henrikbrixandersen Aug 4, 2020

Choose a reason for hiding this comment

pbeTrifork commented Aug 5, 2020

erwango commented Oct 13, 2020

pbeTrifork commented Oct 13, 2020

erwango commented Oct 13, 2020

pbeTrifork commented Oct 13, 2020

erwango commented Oct 14, 2020

pbeTrifork commented Oct 14, 2020

pbeTrifork commented Oct 19, 2020

erwango commented Oct 19, 2020

erwango left a comment

Choose a reason for hiding this comment

pbeTrifork commented Oct 20, 2020

erwango commented Oct 21, 2020

pbeTrifork commented Oct 23, 2020

erwango commented Oct 23, 2020

pbeTrifork commented Oct 29, 2020

erwango commented Nov 4, 2020

pbeTrifork commented Nov 4, 2020

pbeTrifork commented Nov 25, 2020

erwango left a comment

Choose a reason for hiding this comment

erwango Nov 26, 2020

Choose a reason for hiding this comment

pbeTrifork Nov 26, 2020

Choose a reason for hiding this comment

erwango Nov 26, 2020

Choose a reason for hiding this comment

carlescufi left a comment

Choose a reason for hiding this comment

pbeTrifork Aug 4, 2020 •

edited