tests: lib: cmsis:transform: cf64 min_ram 128k #27850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ABOSTM
added
the
area: Tests
stephanosio
reviewed
Aug 31, 2020
There was a problem hiding this comment.
Could you split the changes in testcase.yml and cf64.c into separate commits?
Ideally, updating the memory requirement in testcase.yml should be sufficient; but, it seems an additional change (reordering) is required due to something funny going on inside newlib malloc -- which ought to be investigated and fixed; after which, it should no longer be necessary and therefore reverted.
tests/lib/cmsis_dsp/transform/ with config: * libraries.cmsis_dsp.transform.cf64 Needs more than 64k RAM. Signed-off-by: Alexandre Bourdiol <alexandre.bourdiol@st.com>
tests/lib/cmsis_dsp/transform/ with config: * libraries.cmsis_dsp.transform.cf64 96k is sufficient if tests steps are reordered (decreasing malloc size) Tested on nucleo_l476rg Signed-off-by: Alexandre Bourdiol <alexandre.bourdiol@st.com>
ABOSTM
force-pushed
the
CF64_MIN_RAM_128K
branch
from
fcb9f5d
to
44e98bb
Compare
|
Similar PR for tests/lib/cmsis_dsp/matrix/: #27925 |
carlescufi
approved these changes
Sep 4, 2020
erwango
approved these changes
Sep 4, 2020
ioannisg
reviewed
Sep 4, 2020
ioannisg
reviewed
Sep 4, 2020
|
Not urgent to be merged before the 2.4 freeze - this is probably fixing a bug, so it can be dealt with later. |
stephanosio
approved these changes
Sep 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tests: lib: cmsis:transform: cf64 min_ram 128k
tests/lib/cmsis_dsp/transform/ with config:
Needs more than 64k RAM.
128k is sufficient if tests steps are reordered
(decreasing malloc size)
Fixes #27849